[patch] Remove TARGET_FLOAT128_ENABLE_TYPE setting for VxWorks

[patch] Remove TARGET_FLOAT128_ENABLE_TYPE setting for VxWorks

[Olivier Hainque]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Hello,

We have, in vxworks.h:

  /* linux64.h enables this, not supported in vxWorks.  */
  #undef TARGET_FLOAT128_ENABLE_TYPE
  #define TARGET_FLOAT128_ENABLE_TYPE 0

We inherit linux64.h for a few reasons, but don't really support
float128 for vxworks, so the setting made sense.

Many tests rely on the linux default (1) though, so resetting is
causing lots of failures on compilation tests that would pass otherwise.

Not resetting lets users write code declaring floa128
objects but linking will typically fail at some point, so
there's no real adverse effect.

Bottom line is we don't have any particular incentive to alter
the default, whatever the default, so better leave the parameter
alone.

Tested with internal testsuites for VxWorks and the dg
testsuite on a variety of gcc-11 based compilers.

Checked that the compiler still builds and passes a few
internal testsuites with a gcc-12 compiler for ppc64-vx7r2.

Committing to mainline.

Olivier

2022-04-19  Olivier Hainque  <hainque@adacore.com>

	* config/vxworks.h (TARGET_FLOAT128_ENABLE_TYPE): Remove
	resetting to 0.



[-- Attachment #2: 0002-Remove-TARGET_FLOAT128_ENABLE_TYPE-setting-for-VxWor.patch --]
[-- Type: application/octet-stream, Size: 1686 bytes --]

From 3ebde07b2811d5ac2073ec2f89260e582279a563 Mon Sep 17 00:00:00 2001
From: Olivier Hainque <hainque@adacore.com>
Date: Tue, 19 Apr 2022 09:07:32 +0000
Subject: [PATCH 02/18] Remove TARGET_FLOAT128_ENABLE_TYPE setting for VxWorks

We have, in vxworks.h:

  /* linux64.h enables this, not supported in vxWorks.  */
  #undef TARGET_FLOAT128_ENABLE_TYPE
  #define TARGET_FLOAT128_ENABLE_TYPE 0

We inherit linux64.h for a few reasons, but don't really support
float128 for vxworks, so the setting made sense.

Many tests rely on the linux default (1) though, so resetting is
causing lots of failures on compilation tests that would pass otherwise.

Not resetting lets users write code declaring floa128
objects but linking will typically fail at some point, so
there's no real adverse effect.

Bottom line is we don't have any particular incentive to alter
the default, whatever the default, so better leave the parameter
alone.

2022-04-19  Olivier Hainque  <hainque@adacore.com>

	* config/vxworks.h (TARGET_FLOAT128_ENABLE_TYPE): Remove
	resetting to 0.
---
 gcc/config/rs6000/vxworks.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gcc/config/rs6000/vxworks.h b/gcc/config/rs6000/vxworks.h
index 6f11de6c579..e9626505d4b 100644
--- a/gcc/config/rs6000/vxworks.h
+++ b/gcc/config/rs6000/vxworks.h
@@ -265,9 +265,5 @@ along with GCC; see the file COPYING3.  If not see
 #undef LINK_OS_EXTRA_SPEC64
 #define LINK_OS_EXTRA_SPEC64 VXWORKS_LINK_SPEC
 
-/* linux64.h enables this, not supported in vxWorks.  */
-#undef TARGET_FLOAT128_ENABLE_TYPE
-#define TARGET_FLOAT128_ENABLE_TYPE 0
-
 #endif /* TARGET_VXWORKS7 */
 
-- 
2.25.1