From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id A75613858414 for ; Fri, 2 Feb 2024 12:07:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A75613858414 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A75613858414 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706875640; cv=none; b=eaFZcqipF0ugoXhK2qunIWyIA80l+v9cM23iJTPWTTS5+qNKV8wO6kkpoqJa7nba2pVinPfLpw6R0ZCAMzOaVGu5HLpYE7CloZfju5gBt7eoIh5j9TJeVqNxBrWB8IQwvO3EqG1ZRu0ZpfGeHlZnaahLrgmWdffueUWj5nOTgEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706875640; c=relaxed/simple; bh=l7kOa1svVde5m7jmcbo/+SKQH7jMi9YYt5DaMp9uxDk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=st02M4uedl6WX72ZrIntFTFRFELEr8d71GEZxJgL8JUdwY9DWBmo3nv2CgAVqcooC3TGL4atRdFr8ObkMXu0WCQhdqhhhEMA6bJ/QVWTvPwkaHKYPt06ZSRRwH16zW3rrU4fbXzrNTmaXl7TdAL6vWAfyr7TIkMpwBrkz4rjwMo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-55f15762840so2489083a12.0 for ; Fri, 02 Feb 2024 04:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706875636; x=1707480436; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=XiY9atqYMwxR4F0U8JLO5Id/0c69lRX5SZVZdBoDcKc=; b=R2Ix7kAZkSyxTzkyLS66GOrGs0Cmn4RfzDVtLn/v7E+AT4SXsAb/vZZtPAfReHc3BF iXh3uJS1y1S7d1PVRePUlFiUwDelMmCrbQPvTNe8Y4y4dPdWEpGLiSTSjSUtrpLn/pjb My8rjpu5uOdoeAxZZ02OKWHPqQkTGkqiXTy+6em9ZFVImbejLuvXooYgIM0lJcQA2Fhv X3xAtEYc6pg94f1d/GxIIacNUuboF34tepvysFeAs6av31WUGvirwCKYTOrH4xKvbCgq DDnkqLLNsGzMMeQLhqOSF0C+JBVmVh2ODgBY4+kf/lkanTbJgtHA7VTbCeTSHipS/0uy 0KuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706875636; x=1707480436; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XiY9atqYMwxR4F0U8JLO5Id/0c69lRX5SZVZdBoDcKc=; b=dRV1HJi2t4XN/sS4qykazsqDwOyDuAOS9RVqB/3ymWkMoBAh9zhkWnWS9QFyuJbi9W 0ZoPtxCDPRkbNcwWbFaF/5dpBdDtUelDlxkVuA0B0hNrDOlfqdgYGTBwVKcMAnbLLOoQ MWWDIecq3GW4ZwiImtdt8+vyRAhh7yeCIADLMvT1c0d1mLgAk8tGwIL/iYRk1jqHDbhT CRINo+Q6GTiXRvmjztReKltSUUJqH9yzTg6lGHesaQG9+djip4IDj67NDM2RpuhdZQV3 KKGgtX+dPvNMVSWC9hdWobRvshAyosl1dUt8sTNKNK3lOXXyppmjnCazSfXJXeEadQHB 14ew== X-Gm-Message-State: AOJu0YydD/PsRIO6GRgcsXfGWdyYoZLA3otYBB2NZX/hkWo7nxEyPpL6 r1vgV+h9yM4UVG4mglk2RIizDexb6PeJHxSQgP4Ybndr0yFzAI+jaA1uAMr5 X-Google-Smtp-Source: AGHT+IEK+NscdYMpFgRSCEwkdD8fLaFVIChqEWLx+jG89gmSmzymCBlf1j+wXdLHit3PZyh3WMicHA== X-Received: by 2002:a17:906:53c4:b0:a37:1e9a:c94b with SMTP id p4-20020a17090653c400b00a371e9ac94bmr516674ejo.51.1706875635519; Fri, 02 Feb 2024 04:07:15 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUownKeigedcbUPPlZKZjFyW5HqWYtOkh5iDtk0OkeHqcghvjfbSsWagf/A8JVBp+sf7AMsmQfNvUjOxEaDCTKHtnFJFwY4uPukuHpRnf5pIAMcPa0cZgyBNMMQxJ9CvLO8fUqoPuWLXSE6k48= Received: from [127.0.0.1] (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id vu12-20020a170907a64c00b00a31c5caa750sm823744ejc.177.2024.02.02.04.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Feb 2024 04:07:15 -0800 (PST) Date: Fri, 02 Feb 2024 13:07:10 +0100 From: rep.dot.nop@gmail.com To: gcc-patches@gcc.gnu.org, "H.J. Lu" , Jakub Jelinek Subject: Re: [PATCH] x86-64: Find a scratch register for large model profiling In-Reply-To: References: <20240201181530.99684-1-hjl.tools@gmail.com> Message-ID: <72D525E2-2F15-40FD-AA9A-4C334F8CB5FA@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2 February 2024 00:02:54 CET, "H=2EJ=2E Lu" wr= ote: >On Thu, Feb 1, 2024 at 10:32=E2=80=AFAM Jakub Jelinek wrote: >> >> On Thu, Feb 01, 2024 at 10:15:30AM -0800, H=2EJ=2E Lu wrote: >> > --- a/gcc/config/i386/i386=2Ecc >> > +++ b/gcc/config/i386/i386=2Ecc >> > @@ -22749,6 +22749,31 @@ current_fentry_section (const char **name) >> > return true; >> > } >> > >> > +/* Return an unused caller-saved register at entry for profile=2E *= / >> > + >> > +static int >> > +x86_64_select_profile_regnum (bool r11_ok ATTRIBUTE_UNUSED) >> > +{ >> > + int i; >> >> Why not just return R10_REG here if flag_entry !=3D 0 (i=2Ee=2E keep ex= isting >> behavior unless emitting profiler after prologue)? > >Fixed in v2=2E Nit: r10_ok is now superfluous, but lets wait for Jakub=2E thanks