From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1E5373858D28 for ; Sun, 10 Dec 2023 18:19:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E5373858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E5373858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702232363; cv=none; b=xR5Glm6cFi9kVFTnuiXyeoTZsaJo5uebCEkrd3uhrZ+1MPFtj2AH825Dm601XjNNyAx51vGujwH9kvojWJhZ8EtOD4iYuVpqvapGU7XF57Dk3OCRMIBupbjYmO18+KPiN9OLM2EQhIsp7a1EKo8p1d8Vf2Qe2j7OWQwOlD7Khy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702232363; c=relaxed/simple; bh=fqp2BisuOFcMF3XE9ea+Yep3AO9tRNPEt5U2/S1Kmng=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=IxVzJnbDtoMnm+mtpDsMGdfLWuV9cN/gAr7W4Jrv2wuSaYfdmIX6mJT6fknP3/KY3itoohvExvRNutJVoKc6XbrNhqcP14zngVecq2XVfV87w57+lDjs1Iw0lRHiTJdTTynchgp+IBMIMP7f/f98uy0+/sh5nq0jT+qty9lzyjg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702232357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VnF2HajzJb+dFP+V5Xiy5Aq8Aa5wxt2hfle+TcZ5C7k=; b=WZ/dUaoP+YHA0UbQbve+hTMKicrfrgd8ahngJfj5dmJ7jTyh/AqGdJJm45R3QIte7tvTAP a592vEmisOITz873G8duufrA0CF1yngtFlC2ji1vVmrqDvGgy9Pg1RTKQqyBSCftPcLsn3 QcNHM39sCoeXMxE+NxdcNVxnkOEkxr8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-6tTXr7mDOuGmvDJpWpXa9Q-1; Sun, 10 Dec 2023 13:19:16 -0500 X-MC-Unique: 6tTXr7mDOuGmvDJpWpXa9Q-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-77f4699beeeso466519885a.2 for ; Sun, 10 Dec 2023 10:19:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702232355; x=1702837155; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jZbb77in3A/K4ttxNK+q0V+X1m38qMI9dhIasqK4Nmk=; b=JsxkCTkjXwe5rHiFs2Uqt+9vu92U/p7nyZOePjrbjFPUt/pYnEKwiNftq+DvnQSbmo aSnt+4JuZv5ZLKpYvAJOu11RW9w0QXuM3o1BE9NFbnkbguEpq2mDAwASVDiKfO6ycH58 7O7EAdRyHgP64o3fE/R5kd8UlrVAu/WtEboSUZgYkB1zl4yEfnbYi8X5218CVVPZ9UwI km7tYt9CR1015sausGnmVyQf8d11QpEuO3UhdA/CPmPvi6sie6VKzZHM1QtNpKfL1Tz8 hMwyejbYaY2qi2mhI8lID4XH2DaAA+8xK60hmAmAaqztayXNYfbZksWJ0N8WXTbF9Yse cUzQ== X-Gm-Message-State: AOJu0YyvZkHx2e7qlYLoOa2c5HJvP0LRtdxMr76L2CWfshzCRXsQt8gi ylDTWrQ8QqLMK04lhfgma6bL94GBf8nE8IFhvUV4SXD1haIew+/Uo3wwJVK0s2rrBT0IyvDrmvg NiZxm465iLRVhhl+jyw== X-Received: by 2002:a05:620a:102c:b0:77e:fba4:3a0b with SMTP id a12-20020a05620a102c00b0077efba43a0bmr4414646qkk.97.1702232355655; Sun, 10 Dec 2023 10:19:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKuGabLJrl9Mqx6y+T5oUhIUo+t1S3qwkzwP4fp6FYpa5enJY6NQviNI5NGLt590ulCZeqqg== X-Received: by 2002:a05:620a:102c:b0:77e:fba4:3a0b with SMTP id a12-20020a05620a102c00b0077efba43a0bmr4414634qkk.97.1702232355370; Sun, 10 Dec 2023 10:19:15 -0800 (PST) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id dt8-20020a05620a478800b007749dc7881dsm2282638qkb.48.2023.12.10.10.19.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Dec 2023 10:19:14 -0800 (PST) Message-ID: <72a53d86-b4d8-4321-9e75-fe1f16099887@redhat.com> Date: Sun, 10 Dec 2023 13:19:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v26 00/23] Optimize type traits compilation performance To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20231024020424.699427-1-kmatsui@gcc.gnu.org> <20231207051513.969952-1-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20231207051513.969952-1-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------SXnAhXAyyze3WDS0jc6P9aMk" Content-Language: en-US X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------SXnAhXAyyze3WDS0jc6P9aMk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/7/23 00:11, Ken Matsui wrote: > This patch series optimizes type traits compilation performance by > implementing built-in type traits and using them in libstdc++. > > Changes in v26: > > * Rebased on top of trunk. > * Moved is_function_v under is_const_v. > * Isolated patches for is_const, is_volatile, is_pointer, and > is_unbounded_array, which contain performance regression, from > this patch series since they are not ready for review yet. I've applied all the compiler patches, with a few small tweaks, including this one as a separate commit. One other was a formatting fix, the lats was using TYPE_PTRDATAMEM_P for CPTK_IS_MEMBER_OBJECT_POINTER. I'm leaving the library patches for library folks to apply. Thanks! Jason --------------SXnAhXAyyze3WDS0jc6P9aMk Content-Type: text/x-patch; charset=UTF-8; name="0001-c-trait-patch-tweak.patch" Content-Disposition: attachment; filename="0001-c-trait-patch-tweak.patch" Content-Transfer-Encoding: base64 RnJvbSBlNDEwMzAzZjc2OGZhN2IwMjBlNDZmM2JkN2QyODM4MTE0NGU1MzQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXNvbiBNZXJyaWxsIDxqYXNvbkByZWRoYXQuY29tPgpEYXRl OiBGcmksIDggRGVjIDIwMjMgMTU6NTU6NDkgLTA1MDAKU3ViamVjdDogW1BBVENIIDAxLzExXSBj Kys6IHRyYWl0IHBhdGNoIHR3ZWFrClRvOiBnY2MtcGF0Y2hlc0BnY2MuZ251Lm9yZwoKQXMgUGF0 cmljayBzdWdnZXN0ZWQgZWxzZXdoZXJlLCBsZXQncyBtb3ZlIHRoaXMgaW50byB0aGUgZGVmYXVs dCBjYXNlLgoKZ2NjL2NwL0NoYW5nZUxvZzoKCgkqIHBhcnNlci5jYyAoY3BfcGFyc2VyX3NpbXBs ZV90eXBlX3NwZWNpZmllcik6IE1vdmUgdHJhaXQKCWhhbmRsaW5nIHRvIGRlZmF1bHQgbGFiZWwu Ci0tLQogZ2NjL2NwL3BhcnNlci5jYyB8IDI2ICsrKysrKysrKysrKystLS0tLS0tLS0tLS0tCiAx IGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvZ2NjL2NwL3BhcnNlci5jYyBiL2djYy9jcC9wYXJzZXIuY2MKaW5kZXggOWU3NjQyNjU2 NmIuLmI5ODczMjRmNjY5IDEwMDY0NAotLS0gYS9nY2MvY3AvcGFyc2VyLmNjCisrKyBiL2djYy9j cC9wYXJzZXIuY2MKQEAgLTIwMTY0LDIyICsyMDE2NCwyMiBAQCBjcF9wYXJzZXJfc2ltcGxlX3R5 cGVfc3BlY2lmaWVyIChjcF9wYXJzZXIqIHBhcnNlciwKICAgICAgIHJldHVybiB0eXBlOwogCiAg ICAgZGVmYXVsdDoKKyAgICAgIC8qIElmIHRva2VuIGlzIGEgdHlwZS15aWVsZGluZyBidWlsdC1p biB0cmFpdHMsIHBhcnNlIGl0LiAgKi8KKyAgICAgIGNvbnN0IGNwX3RyYWl0KiB0cmFpdCA9IGNw X2xleGVyX3BlZWtfdHJhaXRfdHlwZSAocGFyc2VyLT5sZXhlcik7CisgICAgICBpZiAodHJhaXQp CisJeworCSAgdHlwZSA9IGNwX3BhcnNlcl90cmFpdCAocGFyc2VyLCB0cmFpdCk7CisJICBpZiAo ZGVjbF9zcGVjcykKKwkgICAgY3BfcGFyc2VyX3NldF9kZWNsX3NwZWNfdHlwZSAoZGVjbF9zcGVj cywgdHlwZSwKKwkJCQkJICB0b2tlbiwKKwkJCQkJICAvKnR5cGVfZGVmaW5pdGlvbl9wPSovZmFs c2UpOworCisJICByZXR1cm4gdHlwZTsKKwl9CisKICAgICAgIGJyZWFrOwogICAgIH0KIAotICAv KiBJZiB0b2tlbiBpcyBhIHR5cGUteWllbGRpbmcgYnVpbHQtaW4gdHJhaXRzLCBwYXJzZSBpdC4g ICovCi0gIGNvbnN0IGNwX3RyYWl0KiB0cmFpdCA9IGNwX2xleGVyX3BlZWtfdHJhaXRfdHlwZSAo cGFyc2VyLT5sZXhlcik7Ci0gIGlmICh0cmFpdCkKLSAgICB7Ci0gICAgICB0eXBlID0gY3BfcGFy c2VyX3RyYWl0IChwYXJzZXIsIHRyYWl0KTsKLSAgICAgIGlmIChkZWNsX3NwZWNzKQotCWNwX3Bh cnNlcl9zZXRfZGVjbF9zcGVjX3R5cGUgKGRlY2xfc3BlY3MsIHR5cGUsCi0JCQkJICAgICAgdG9r ZW4sCi0JCQkJICAgICAgLyp0eXBlX2RlZmluaXRpb25fcD0qL2ZhbHNlKTsKLQotICAgICAgcmV0 dXJuIHR5cGU7Ci0gICAgfQotCiAgIC8qIElmIHRva2VuIGlzIGFuIGFscmVhZHktcGFyc2VkIGRl Y2x0eXBlIG5vdCBmb2xsb3dlZCBieSA6OiwKICAgICAgaXQncyBhIHNpbXBsZS10eXBlLXNwZWNp Zmllci4gICovCiAgIGlmICh0b2tlbi0+dHlwZSA9PSBDUFBfREVDTFRZUEUKLS0gCjIuMzkuMwoK --------------SXnAhXAyyze3WDS0jc6P9aMk--