From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61505 invoked by alias); 30 Nov 2016 11:13:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60888 invoked by uid 89); 30 Nov 2016 11:13:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=20161130 X-HELO: einhorn.in-berlin.de Received: from einhorn.in-berlin.de (HELO einhorn.in-berlin.de) (192.109.42.8) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 11:13:21 +0000 X-Envelope-From: doko@ubuntu.com Received: from [192.168.178.26] (ip5f5af460.dynamic.kabel-deutschland.de [95.90.244.96]) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id uAUBDElc021194 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 30 Nov 2016 12:13:14 +0100 Subject: Re: [patch] boehm-gc removal and libobjc changes to build with an external bdw-gc To: Jakub Jelinek , Richard Biener References: <98216026-e0e2-f253-0346-94071d7dc5c7@ubuntu.com> <20161130105256.GO3541@tucnak.redhat.com> Cc: Andreas Schwab , GCC Patches , Andrew Pinski , Nicola Pero , Jeff Law From: Matthias Klose Message-ID: <72e423b2-a9b8-aa42-91a6-1c8cdd38d700@ubuntu.com> Date: Wed, 30 Nov 2016 11:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161130105256.GO3541@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg03009.txt.bz2 On 30.11.2016 11:52, Jakub Jelinek wrote: > On Wed, Nov 30, 2016 at 11:17:32AM +0100, Richard Biener wrote: >> On Wed, Nov 30, 2016 at 11:06 AM, Matthias Klose wrote: >>> On 30.11.2016 09:29, Andreas Schwab wrote: >>>> configure: error: no --with-target-bdw-gc options and no bdw-gc pkg-config module found >>>> make[1]: *** [Makefile:19775: configure-target-libobjc] Error 1 >>>> >>>> Andreas. >>> >>> that's a bit terse. Could you send the complete output for the configuration of >>> the libobjc subdir and the config.log? >>> >>> I assume that is a configuration with --enable-objc-gc and then the pkg-config >>> module cannot be found. Are gc/gc.h and libgc.so in standard paths without >>> having the bdw-gc pkg-config module available? Which libgc version is installed? >> >> I see the same failure with just >> >> ../configure --enable-languages=objc >> >> usually we disable languages (with a diagnostic) if requirements >> cannot be fulfilled. >> >> But it seems the default chosen is bad somehow... (and breaks my bootstraps with >> default languages). > > I'm now testing the default (no --enable-objc-gc, --enable-objc-gc=*, > --disable-objc-gc) with. Ok for trunk if it succeeds? > > 2016-11-30 Jakub Jelinek > > * configure.ac (--enable-objc-gc): If not given, default to > enable_objc_gc=no. > * configure: Regenerated. > > --- libobjc/configure.ac.jj 2016-11-30 08:57:26.000000000 +0100 > +++ libobjc/configure.ac 2016-11-30 11:47:33.085828683 +0100 > @@ -203,7 +203,7 @@ gt_BITFIELD_TYPE_MATTERS > AC_ARG_ENABLE(objc-gc, > [AS_HELP_STRING([--enable-objc-gc], > [enable use of Boehm's garbage collector with the > - GNU Objective-C runtime])]) > + GNU Objective-C runtime])],,enable_objc_gc=no) > AC_ARG_WITH([target-bdw-gc], > [AS_HELP_STRING([--with-target-bdw-gc=PATHLIST], > [specify prefix directory for installed bdw-gc package. > --- libobjc/configure.jj 2016-11-30 08:57:26.000000000 +0100 > +++ libobjc/configure 2016-11-30 11:47:44.720680375 +0100 > @@ -11509,6 +11509,8 @@ $as_echo "#define HAVE_BITFIELD_TYPE_MAT > # Check whether --enable-objc-gc was given. > if test "${enable_objc_gc+set}" = set; then : > enableval=$enable_objc_gc; > +else > + enable_objc_gc=no > fi > I can confirm, that this works for any configureation not enabling the objc-gc. I found another issue with enabling objc-gc, but your patch restores the standard bootstrap. Matthias