From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc36.google.com (mail-oo1-xc36.google.com [IPv6:2607:f8b0:4864:20::c36]) by sourceware.org (Postfix) with ESMTPS id A39E53858C54 for ; Wed, 7 Jun 2023 12:59:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A39E53858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-558565cc58fso5609934eaf.0 for ; Wed, 07 Jun 2023 05:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686142784; x=1688734784; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wMtWMc2Z5tZJVZufix75P6F5ca4fZYfcACBJXXRQRSo=; b=d4/wILxIwkYuwUOfDuTiJFtbtIeTvCx28RoHPMXBziudlS3iIkfuLxCTDptewuA/OD EnR8QhVrhcuFT2UN4FYZGLtMU3jryTuWjfzhJ7iOlQIWTfQVpeIj12EVGEFUcpdHfBgC hReePT7vR7doS3PJL62HPUrXo39Ly+BLjyXw7biz2wR+IZ+tS3OimPvvtyGngH+KKRHn lQh2eni+4LAAOdS8DpQVmFtMdtsHG9/p6Y6VQ/xvFH0USy1DYqIK/zGgHlTiSjFspLnq NlLHuU6+0HyGawDZuJy6lnZAeBD1/lQhG9uNuOyd/6RG9M1w4tOvG57c7SUALmJLcHpK hp6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686142784; x=1688734784; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wMtWMc2Z5tZJVZufix75P6F5ca4fZYfcACBJXXRQRSo=; b=GPAVtbxCxAdS83bqQoE6pd4nfps7m6OJjCa0AKgv5VY8catjtlu7WkLZ8jvSIUV7a+ 651q2eTu74mxp6M1PTbgL4iglF3xpRnPz/0LV4cIhWlH8mlgq8PjX41nS1b1DHLvsiSW IM9CTRLeIzpNuhpxFqAhUam6VL7k9xYs4h1RhqjfTwEMQUpwZU+c6xUIuDjKMVeddFCy GNibD4L/2ckS/plyfwCt0PocT/n82Xavk3ZnswLOWJLU3r8rf4PVips929AIKD03VdSl miKzSKGM3KvKWojRNvzpvfxSW/FeFbiqclQxKrK1PfZ5ZBf5JW2HamK2v9tdNmUozNBx sjAw== X-Gm-Message-State: AC+VfDzV31SYFcHMml5GMoXFbJtEhyLtP6EGb41Xm2PS7daQUQAbWEFE x9XTHhNH6JRzSMJob34gSX0= X-Google-Smtp-Source: ACHHUZ5v4yN7eHXm4Ez+Qe4RSlMKafksuPU/lineP9iW7pwYCSj3a47kJRpv0SYtbNuzr+rPI6MK8Q== X-Received: by 2002:a05:6359:a96:b0:129:cce3:a877 with SMTP id em22-20020a0563590a9600b00129cce3a877mr3849319rwb.1.1686142783521; Wed, 07 Jun 2023 05:59:43 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id t7-20020a654087000000b00520f4ecd71esm8221424pgp.93.2023.06.07.05.59.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 05:59:43 -0700 (PDT) Message-ID: <72e6ae5f-e921-b912-63cb-6050cdf2389b@gmail.com> Date: Wed, 7 Jun 2023 06:59:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] libiberty: pex-unix.c: Make pex_unix_cleanup signature always match body. Content-Language: en-US To: Costas Argyris , gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/7/23 04:21, Costas Argyris via Gcc-patches wrote: > I saw this while working on something else: > > pex_unix_cleanup signature doesn't always match the > body of the function in terms of ATTRIBUTE_UNUSED. > If the conditional code in the body is compiled, then > ATTRIBUTE_UNUSED isn't correct. > > This change makes it always match, thereby making it > a bit cleaner IMO. ATTRIBUTE_UNUSED is meant to be a "maybe unused" decoration. I'd just leave it as-is. jeff