From: Jeff Law <law@redhat.com>
To: "Jakub Jelinek" <jakub@redhat.com>,
"Dominique d'Humières" <dominiq@lps.ens.fr>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Bump the default thread stack size on Darwin in libgomp (PR libgomp/79876)
Date: Mon, 03 Apr 2017 16:56:00 -0000 [thread overview]
Message-ID: <72fda698-ef0c-c1b3-9aef-6fa5cde859a5@redhat.com> (raw)
In-Reply-To: <20170401122418.GU17461@tucnak>
On 04/01/2017 06:24 AM, Jakub Jelinek wrote:
> Hi!
>
> Apparently Darwin has insane default stack size for pthread_create
> unless overridden through pthread_attr_setstacksize - 512kB, compared e.g.
> to Linux usual default of around 8MB. For typical OpenMP uses that is way
> too low, so the following patch is an attempt to bump it to 2MB just on
> Darwin, and on other targets keep the default. Everything can be in any
> case overridden through {,G}OMP_STACKSIZE env variables.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, can anyone please test it
> on darwin?
>
> 2017-04-01 Jakub Jelinek <jakub@redhat.com>
>
> PR libgomp/79876
> * config/posix/thread-stacksize.h: New file.
> * config/darwin/thread-stacksize.h: New file.
> * config/nvptx/thread-stacksize.h: New file.
> * env.c: Include thread-stacksize.h.
> (initialize_env): Initialize stacksize to GOMP_DEFAULT_STACKSIZE
> instead of 0. Call pthread_attr_setstacksize even if
> GOMP_DEFAULT_STACKSIZE is non-zero.
I've got a build started, but it's on an ancient macbook pro, so it'll
take a long time. Someone else with modern hardware could certainly get
this done faster :-)
jeff
next prev parent reply other threads:[~2017-04-03 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 12:24 Jakub Jelinek
2017-04-03 16:56 ` Jeff Law [this message]
2017-04-03 17:00 ` Jakub Jelinek
2017-04-03 17:02 ` Jeff Law
2017-04-04 9:21 ` Dominique d'Humières
2017-04-04 15:25 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72fda698-ef0c-c1b3-9aef-6fa5cde859a5@redhat.com \
--to=law@redhat.com \
--cc=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).