From: "Martin Liška" <mliska@suse.cz>
To: Ian Lance Taylor <iant@golang.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/4] Remove unused functions and fields.
Date: Mon, 22 Oct 2018 13:05:00 -0000 [thread overview]
Message-ID: <73202094-fef4-9659-4ca4-3384b1ce96e6@suse.cz> (raw)
In-Reply-To: <CAKOQZ8zDq9tQC8Ynq_qmRt3DNCTb0bbUSxoXmyZ22VJq3SKpkQ@mail.gmail.com>
On 10/19/18 1:02 AM, Ian Lance Taylor wrote:
> On Sat, Sep 22, 2018 at 12:08 PM, marxin <mliska@suse.cz> wrote:
>>
>> gcc/go/ChangeLog:
>>
>> 2018-09-24 Martin Liska <mliska@suse.cz>
>>
>> * gofrontend/escape.cc (Gogo::analyze_escape): Remove
>> usage of a parameter.
>> (Gogo::assign_connectivity): Likewise.
>> (class Escape_analysis_tag): Likewise.
>> (Gogo::tag_function): Likewise.
>> * gofrontend/expressions.cc (Call_expression::do_type): Likewise.
>> * gofrontend/gogo.h (class Gogo): Likewise.
>> * gofrontend/types.cc (class Call_multiple_result_type): Likewise.
>> (Type::make_call_multiple_result_type): Likewise.
>> * gofrontend/types.h (class Type): Likewise.
>> * gofrontend/wb.cc (class Check_escape): Likewise.
>> (Gogo::add_write_barriers): Likewise.
>
> HI, unfortunately this is wrong. As described in
> gcc/go/gofrontend/README, the files in that directory are mirrored
> from a separate repository (the same is true of the files in the libgo
> directory). You should not make changes to them directly in the GCC
> repository. I have reverted these changes, as follows. Sorry.
>
> Ian
>
Hi Ian.
Got it. Is it possible that the removed chunks of code are somehow alive
in original repository in some conditional build?
Martin
next prev parent reply other threads:[~2018-10-22 12:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 7:37 [PATCH 0/4] Clean-up warnings spotted by Rtags marxin
2018-09-24 7:37 ` [PATCH 4/4] Fix scaling of a sreal number marxin
2018-09-24 14:42 ` Jeff Law
2018-09-24 7:37 ` [PATCH 3/4] Fix small coding style issues (PR fortran/87394) marxin
2018-09-24 14:39 ` Jeff Law
2018-09-24 7:37 ` [PATCH 1/4] Add filter-rtags-warnings.py script marxin
2018-09-24 14:45 ` Jeff Law
2018-09-24 7:39 ` [PATCH 2/4] Remove unused functions and fields marxin
2018-09-24 14:42 ` Jeff Law
2018-09-25 7:18 ` Martin Liška
2018-09-25 12:31 ` Richard Biener
2018-09-25 13:40 ` Jeff Law
2018-09-26 9:01 ` Martin Liška
2018-09-27 11:18 ` Bernhard Reutner-Fischer
2018-10-03 16:46 ` Jeff Law
2018-10-03 19:35 ` Bernhard Reutner-Fischer
2018-10-05 2:19 ` Bernhard Reutner-Fischer
2018-10-05 13:41 ` Martin Liška
2018-10-09 8:52 ` [PATCH] Remove dead functions and fix VMS target by moving back some functions Martin Liška
2018-10-09 22:53 ` Martin Jambor
2018-10-10 11:13 ` Martin Liška
2018-10-10 11:17 ` Martin Jambor
2018-10-18 23:55 ` [PATCH 2/4] Remove unused functions and fields Ian Lance Taylor
2018-10-22 13:05 ` Martin Liška [this message]
2018-10-22 17:50 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73202094-fef4-9659-4ca4-3384b1ce96e6@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@golang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).