public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: Lulu Cheng <chenglulu@loongson.cn>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: [PATCH 1/2] LoongArch: Add the macro implementation of mcmodel=extreme.
Date: Thu, 04 Jan 2024 11:51:41 +0800	[thread overview]
Message-ID: <734aebe3f8159485e2e823699bf987c2f605eaa5.camel@xry111.site> (raw)
In-Reply-To: <20231227084654.20614-2-chenglulu@loongson.cn>

On Wed, 2023-12-27 at 16:46 +0800, Lulu Cheng wrote:
> +(define_insn "movdi_pcrel64"
> + [(set (match_operand:DI 0 "register_operand" "=&r")
> +       (match_operand:DI 1 "symbolic_pcrel64_operand"))
> +  (unspec:DI [(const_int 0)]
> +    UNSPEC_MOV_PCREL64)
> +  (use (reg:DI T3_REGNUM))
> +  (clobber (reg:DI T3_REGNUM))]

It's better not to hard code $t3 here.  We can write

[(set (match_operand:DI 0 "register_operand" "=r")
      (match_operand:DI 1 "symbolic_pcrel64_operand"))
 (clobber (match_operand:DI 2 "register_operand "=&r"))]

And use

  gen_movdi_pcrel64 (operands[0], operands[1], gen_reg_rtx(DImode))

in expand.

> + "TARGET_64BIT"
> + "la.local %0,$r15,%1"
> + [(set_attr "mode" "DI")
> +  (set_attr "length" "5")])

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

  reply	other threads:[~2024-01-04  3:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-27  8:46 [PATCH 0/2] When cmodel=extreme, add macro support and only Lulu Cheng
2023-12-27  8:46 ` [PATCH 1/2] LoongArch: Add the macro implementation of mcmodel=extreme Lulu Cheng
2024-01-04  3:51   ` Xi Ruoyao [this message]
2024-01-04  3:58     ` chenglulu
2024-01-04  4:05       ` Xi Ruoyao
2024-01-04  9:05         ` chenglulu
2024-01-04  9:33           ` chenglulu
2023-12-27  8:46 ` [PATCH 2/2] LoongArch: When the code model is extreme, the symbol address is obtained through macro instructions regardless of the value of -mexplicit-relocs Lulu Cheng
2023-12-27  9:18 ` [PATCH 0/2] When cmodel=extreme, add macro support and only chenglulu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734aebe3f8159485e2e823699bf987c2f605eaa5.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=chenglulu@loongson.cn \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=i@xen0n.name \
    --cc=xuchenghua@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).