From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout04.t-online.de (mailout04.t-online.de [194.25.134.18]) by sourceware.org (Postfix) with ESMTPS id E74B73850414 for ; Tue, 11 Aug 2020 02:16:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E74B73850414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oleg.endo@t-online.de Received: from fwd04.aul.t-online.de (fwd04.aul.t-online.de [172.20.26.149]) by mailout04.t-online.de (Postfix) with SMTP id 68A6941B287B; Tue, 11 Aug 2020 04:16:33 +0200 (CEST) Received: from localhost.localdomain (Ewy3L-ZHohDdzgKGXxf0ZJgluTKQFN9YWvG9IG5fzvcrtbp5q2-4HNbY731HYY4ZZ1@[115.165.108.210]) by fwd04.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1k5Jpx-17G7jk0; Tue, 11 Aug 2020 04:16:25 +0200 Message-ID: <7353d6159e348cebf46494ff4829f680aa62a456.camel@t-online.de> Subject: Re: PING [PATCH] RX new builtin function From: Oleg Endo To: Darius Galis , gcc-patches@gcc.gnu.org Date: Tue, 11 Aug 2020 11:16:21 +0900 In-Reply-To: <91d30008-6745-ed9e-12f7-1d77d3707293@cyberthorstudios.com> References: <91d30008-6745-ed9e-12f7-1d77d3707293@cyberthorstudios.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-ID: Ewy3L-ZHohDdzgKGXxf0ZJgluTKQFN9YWvG9IG5fzvcrtbp5q2-4HNbY731HYY4ZZ1 X-TOI-EXPURGATEID: 150726::1597112186-00004F6D-D63C2153/0/0 CLEAN NORMAL X-TOI-MSGID: d5ab6962-0d19-4952-be55-0020af3011bd X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2020 02:16:36 -0000 On Mon, 2020-08-10 at 13:51 +0300, Darius Galis wrote: > > I've found the following patch > https://gcc.gnu.org/legacy-ml/gcc-patches/2018-11/msg00983.html, but it > is not in the latest sources. > Could please let me know why it was not added? I'm willing to do any > rework necessary in order for it to be accepted to the latest sources. I think it'd be better to fix and/or improve the backend code so that the compiler generates the bset instruction automatically. Otherwise this built-in is not very useful for user code. Except for the use case of atomic-or on byte memory location, as a "side effect". But that should be implemented as such -- as atomics. There are a couple of PRs that might be relevant/interesting https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93587 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83832 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81823 Cheers, Oleg