From: Simon Wright <simon@pushface.org>
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Arnaud Charlet <charlet@adacore.com>
Subject: Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime
Date: Tue, 28 Nov 2023 12:16:23 +0000 [thread overview]
Message-ID: <7355626B-1174-4F4E-9FD5-55D85C3C366B@pushface.org> (raw)
In-Reply-To: <4D16812A-4FBC-49FE-8F90-7B503E781176@pushface.org>
[-- Attachment #1: Type: text/plain, Size: 2487 bytes --]
> On 22 Nov 2023, at 15:13, Simon Wright <simon@pushface.org> wrote:
>
>
>
>> On 22 Nov 2023, at 15:03, Iain Sandoe <iain@sandoe.co.uk> wrote:
>>
>>
>>
>>> On 22 Nov 2023, at 14:48, Iain Sandoe <iain@sandoe.co.uk> wrote:
>>>
>>>
>>>
>>>> On 22 Nov 2023, at 13:55, Arnaud Charlet <charlet@adacore.com> wrote:
>>>>
>>>>>>> #if defined (__APPLE__)
>>>>>>> -#include <unistd.h>
>>>>>>
>>>>>> If removing unistd.h is intentional (i.e. you determined that it’s no longer
>>>>>> needed for Darwin), then we should make that a separate patch.
>>>>>
>>>>> I thought that I’d had to include unistd.h for the first patch in this thread; clearly not!
>>>>>
>>>>> What I hope will be the final version:
>>>>
>>>> OK here.
>>>
>>> also OK here, thanks
>>
>> I think this fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111909 ?
>> if you agree then please add that to the commit.
>> Iain
>
> git format-patch does so much, I forgot this, sorry:
>
> gcc/ada/Changelog:
>
> 2023-11-22 Simon Wright <simon@pushface.org <mailto:simon@pushface.org>>
>
> PR ada/111909
Can we commit this one now, please?
—S
>
>>
>>> Iain
>>>
>>>>
>>>>> ——— 8< .———
>>>>>
>>>>> In gcc/ada/adaint.c(__gnat_get_file_names_case_sensitive), the current
>>>>> assumption for __APPLE__ is that file names are case-insensitive
>>>>> unless __arm__ or __arm64__ are defined, in which case file names are
>>>>> declared case-sensitive.
>>>>>
>>>>> The associated comment is
>>>>> "By default, we suppose filesystems aren't case sensitive on
>>>>> Windows and Darwin (but they are on arm-darwin)."
>>>>>
>>>>> This means that on aarch64-apple-darwin, file names are treated as
>>>>> case-sensitive, which is not the default case.
>>>>>
>>>>> The true default position is that macOS file systems are
>>>>> case-insensitive, iOS file systems are case-sensitive.
>>>>>
>>>>> Apple provide a header file <TargetConditionals.h> which permits a
>>>>> compile-time check for the compiler target (e.g. OSX vs IOS); if
>>>>> TARGET_OS_IOS is defined as 1, this is a build for iOS.
>>>>>
>>>>> * gcc/ada/adaint.c
>>>>> (__gnat_get_file_names_case_sensitive): Split out the __APPLE__
>>>>> check and remove the checks for __arm__, __arm64__.
>>>>> For Apple, file names are by default case-insensitive unless
>>>>> TARGET_OS_IOS is set.
>>>>>
>>>>> Signed-off-by: Simon Wright <simon@pushface.org>
>>
>
next prev parent reply other threads:[~2023-11-28 12:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 11:51 Simon Wright
2023-10-31 8:07 ` Iain Sandoe
2023-11-03 8:39 ` Arnaud Charlet
2023-11-04 17:02 ` Simon Wright
2023-11-04 23:28 ` Iain Sandoe
2023-11-06 8:36 ` Arnaud Charlet
2023-11-11 17:47 ` Simon Wright
2023-11-11 18:10 ` Iain Sandoe
2023-11-13 16:03 ` Simon Wright
2023-11-13 16:18 ` Arnaud Charlet
2023-11-16 20:56 ` Simon Wright
2023-11-17 8:37 ` Arnaud Charlet
2023-11-17 9:06 ` Simon Wright
2023-11-17 9:29 ` Arnaud Charlet
2023-11-17 12:53 ` Simon Wright
2023-11-17 13:36 ` Arnaud Charlet
2023-11-17 13:39 ` Arnaud Charlet
2023-11-17 13:43 ` Simon Wright
2023-11-21 11:22 ` Iain Sandoe
2023-11-21 20:25 ` Simon Wright
2023-11-21 23:13 ` Iain Sandoe
2023-11-22 13:54 ` Simon Wright
2023-11-22 13:55 ` Arnaud Charlet
2023-11-22 14:48 ` Iain Sandoe
2023-11-22 15:03 ` Iain Sandoe
2023-11-22 15:13 ` Simon Wright
2023-11-28 12:16 ` Simon Wright [this message]
2023-11-28 13:50 ` Marc Poulhiès
2023-11-28 16:48 ` Marc Poulhiès
2023-11-22 14:41 ` Paul Koning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7355626B-1174-4F4E-9FD5-55D85C3C366B@pushface.org \
--to=simon@pushface.org \
--cc=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).