From: Bernd Schmidt <bschmidt@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Aldy Hernandez <aldyh@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
David Malcolm <dmalcolm@redhat.com>
Subject: Re: [PR target/78213] Do not ICE on non-empty -fself-test
Date: Mon, 14 Nov 2016 13:25:00 -0000 [thread overview]
Message-ID: <738ca5ff-976a-efd2-cfc5-daf882896cbf@redhat.com> (raw)
In-Reply-To: <20161114132013.GW3541@tucnak.redhat.com>
On 11/14/2016 02:20 PM, Jakub Jelinek wrote:
> On Mon, Nov 14, 2016 at 02:18:02PM +0100, Bernd Schmidt wrote:
>> On 11/11/2016 06:10 PM, Aldy Hernandez wrote:
>>> The problem in this PR is that -fself-test is being run on a non empty
>>> source file. This causes init_emit() to run, which sets:
>>>
>>> REG_POINTER (virtual_incoming_args_rtx) = 1;
>>>
>>> Setting REG_POINTER on the virtual incoming args, causes /f to be
>>> printed on some RTL dumps, causing the -fself-test machinery to fail at
>>> matching the expected value.
>>
>> How about always running init_emit and testing for the correct output?
>
> You mean only if -fself-test, right?
I guess.
Bernd
next prev parent reply other threads:[~2016-11-14 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 17:10 Aldy Hernandez
2016-11-11 17:24 ` Jakub Jelinek
2016-11-14 13:18 ` Bernd Schmidt
2016-11-14 13:20 ` Jakub Jelinek
2016-11-14 13:25 ` Bernd Schmidt [this message]
2016-11-17 16:52 ` Aldy Hernandez
2016-11-22 16:42 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=738ca5ff-976a-efd2-cfc5-daf882896cbf@redhat.com \
--to=bschmidt@redhat.com \
--cc=aldyh@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).