From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5624 invoked by alias); 19 Jun 2011 18:20:40 -0000 Received: (qmail 5615 invoked by uid 22791); 19 Jun 2011 18:20:39 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RFC_ABUSE_POST,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta04.emeryville.ca.mail.comcast.net (HELO qmta04.emeryville.ca.mail.comcast.net) (76.96.30.40) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 19 Jun 2011 18:20:24 +0000 Received: from omta18.emeryville.ca.mail.comcast.net ([76.96.30.74]) by qmta04.emeryville.ca.mail.comcast.net with comcast id xtrb1g0041bwxycA4uLNLu; Sun, 19 Jun 2011 18:20:22 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta18.emeryville.ca.mail.comcast.net with comcast id xuLA1g01F0BKwT48euLsFh; Sun, 19 Jun 2011 18:20:52 +0000 Subject: Re: Turn on -pie on darwin11 and later Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Mike Stump In-Reply-To: Date: Sun, 19 Jun 2011 19:43:00 -0000 Cc: Jack Howarth Content-Transfer-Encoding: quoted-printable Message-Id: <73B63A65-8FEE-42EC-A1D1-00B17FB7625E@comcast.net> References: <201106161301.03627.pedro@codesourcery.com> To: gcc-patches List X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01417.txt.bz2 On Jun 16, 2011, at 12:22 PM, Mike Stump wrote: > On Jun 16, 2011, at 5:01 AM, Pedro Alves wrote: >> On Thursday 16 June 2011 02:33:50, Mike Stump wrote: >>> BOOT_CFLAGS +=3D -mdynamic-no-pic >>> + >>> +# Ensure we don't try and use -pie, as it is incompatible with pch. >>> +BOOT_LDFLAGS=3D`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie = ;; esac;` >>=20 >> Shouldn't this use +=3D like BOOT_CFLAGS? >=20 > Yes, fixed. Thanks for the review. Also backported for gcc 4.5.4 and 4.6.1. > Index: config/mh-darwin > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- config/mh-darwin (revision 175089) > +++ config/mh-darwin (working copy) > @@ -4,4 +4,4 @@ > BOOT_CFLAGS +=3D -mdynamic-no-pic >=20 > # Ensure we don't try and use -pie, as it is incompatible with pch. > -BOOT_LDFLAGS=3D`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;;= esac;` > +BOOT_LDFLAGS +=3D `case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie= ;; esac;`