public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: "Arsen Arsenović" <arsen@aarsen.me>,
	"Arsen Arsenović via Gcc-patches" <gcc-patches@gcc.gnu.org>,
	gcc-patches@gcc.gnu.org
Cc: jason@redhat.com, jchapman@lock3software.com
Subject: Re: [PATCH] contracts: Stop relying on mangling for naming .pre/.post clones
Date: Sat, 10 Dec 2022 20:51:53 +0100	[thread overview]
Message-ID: <73FA94E8-697E-4342-9F0C-02E7487F1F43@gmail.com> (raw)
In-Reply-To: <86tu23o0u4.fsf@aarsen.me>

Hi Arsen,

On 10 December 2022 14:14:59 CET, "Arsen Arsenović via Gcc-patches" <gcc-patches@gcc.gnu.org> wrote:
>
>Arsen Arsenović <arsen@aarsen.me> writes:
>
>> Afternoon,
>>
>> This change prevents contracts from emitting wrapper functions that have the
>> same name as the original function, by moving the logic that disambiguates them
>> from the mangler into the build_contract_condition_function helper.
>>
>> Thanks, have nice day.
>
>Oh, forgot to mention; tested on x86_64-pc-linux-gnu via check-g++.
>

From a very distant POV this auto sounds really like an ugly bandaid and I, personally would have used a conditional in place argument. auto is really like c++ didn't have the guts to go straight to implicit typed LHS like python et al nor to learn from Fortran's IMPLICIT defaults from some 60 years ago by now (which might have made sense on punchcards, but IMHO not so much nowadays, at least in the light of multi lingual people).

The real change does sound plausible, but I didn't really look closely. All in all, not even a comment ;-)

Cheers,

  reply	other threads:[~2022-12-10 19:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-10 13:13 Arsen Arsenović
2022-12-10 13:14 ` Arsen Arsenović
2022-12-10 19:51   ` Bernhard Reutner-Fischer [this message]
2022-12-11 15:56     ` Arsen Arsenović
2022-12-15 15:40 ` Jason Merrill
2022-12-15 18:00   ` Arsen Arsenović
2022-12-15 20:29     ` Iain Sandoe
2022-12-17 11:30       ` Arsen Arsenović
2022-12-15 21:48     ` Jason Merrill
2022-12-17 11:30       ` Arsen Arsenović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73FA94E8-697E-4342-9F0C-02E7487F1F43@gmail.com \
    --to=rep.dot.nop@gmail.com \
    --cc=arsen@aarsen.me \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=jchapman@lock3software.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).