From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 999273858D28 for ; Tue, 1 Aug 2023 23:03:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 999273858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1bbf8cb694aso33278025ad.3 for ; Tue, 01 Aug 2023 16:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1690930988; x=1691535788; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gql9uwXgVtGHf6ESPbuSM8ZyUh2rSsUQdZR9wULlVgE=; b=MIYOKsi7K0MX4PUWpKUolhDkDSu4OkaRa5QdREoBRuCkGJN5pRwrTZzFDajOAbOEhJ QCLFgA8E7hjrc+IY7Z7Zq3NjNdal62FjVzBOdNgvIhmn2Y8HdFcl0frhEn6ZBblGdED+ MyJ5j4zXRm4nmsxS3F4Xz/kKewAZRVJhRp4nRGryWVaggo+64ma0LHkqdzF8C+XY9YcQ Z0tQqSHwa8LVVJcK0/5/VIDaxUNrfsb+cOiJUIbxxJkpE1pjEeMJYLk8qIGIapPNv+ME +akNnxy7wclGpYXdzRssFu83BRtP7dfuMwIhSOCDup+ZX8JpOqQUbxC5zsJknpX1YfM2 QiVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690930988; x=1691535788; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gql9uwXgVtGHf6ESPbuSM8ZyUh2rSsUQdZR9wULlVgE=; b=WIGBkhhAH6GUsNnMe0hknSzJODB71OnqdPMNeUydMTcNXdD8AWrmcVkZSTmo9K9AMd pwi6mXk37K0tvf/hWgRzOeR2WK+cU+7JQdOMTI6GGcJ1RvUdpH0z5vWwf7pozI6bAij7 oziyoXKxQetalfgzlF4wSDpVbgN9SjXrxrfQgp4RKI/Q8yTYmuUz5zP60mcukGRxHrc1 gUc2E2ePPS/afz1HExkHS8S76k9SmLwjygFOc6HmB7sk3KWbTawdD9LHr6POKHNw6GuL O6Fs7kAzfX74NQBlEQQOh5k1dxx5hb5DRCUaGH7OZjhBS3ast7e26yjwcjjRH3/2JfFQ B92A== X-Gm-Message-State: ABy/qLYQTRs7DEhR5hfvRuarNERRGpkkRpnsRRwelCgA1h4P0V6+Vl/3 3X21R+KzAZ4OdVVHZhEv4QHHAYHKLspXYhTo1iwNcA== X-Google-Smtp-Source: APBJJlG9JTEZXHwHLo/sszY3dEZf/5APEsWO7e/ayOR/A/+WpVYlS8ZA5ZBJxQq0OJIEAXCDt+nUHw== X-Received: by 2002:a17:902:ced1:b0:1b5:64a4:be8b with SMTP id d17-20020a170902ced100b001b564a4be8bmr17352156plg.35.1690930988524; Tue, 01 Aug 2023 16:03:08 -0700 (PDT) Received: from [10.0.16.165] ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id u3-20020a170902e80300b001b80d399730sm10936992plg.242.2023.08.01.16.03.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 16:03:08 -0700 (PDT) Message-ID: <73dc8b97-7a7b-d9a0-2e8e-b4a5aaa3ee93@rivosinc.com> Date: Tue, 1 Aug 2023 16:03:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: RISC-V: Folding memory for FP + constant case Content-Language: en-US To: Philipp Tomsich , Jeff Law , Manolis Tsamis Cc: Jivan Hakobyan , gcc-patches@gcc.gnu.org References: <3c1f0f8a-34ed-abb2-8a49-3083a2cc55d2@gmail.com> <61c9b9c2-f52e-2b4e-6d02-62c991603c39@gmail.com> <64233838-fe5e-458d-1eaf-3025b5448d85@rivosinc.com> <91c12503-c288-5b81-8941-cc62bab2ee98@gmail.com> From: Vineet Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/1/23 15:07, Philipp Tomsich wrote: > +Manolis Tsamis > > On Tue, 1 Aug 2023 at 23:56, Jeff Law via Gcc-patches > wrote: >> >> >> On 8/1/23 13:14, Vineet Gupta wrote: >> >>> I have some numbers for f-m-o v3 vs this. Attached here (vs. inline to >>> avoid the Thunderbird mangling the test formatting) >> Thanks. Of particular importance is the leela change. My recollection >> was that the f-m-o work also picked up that case. But if my memory is >> faulty (always a possibility), then that shows a clear case where >> Jivan's work picks up a case not handled by Manolis's work. > f-m-o originally targeted (and benefited) the leela-case. I wonder if > other optimizations/changes over the last year interfere with this and > what needs to be changed to accomodate this... looks like we need to > revisit against trunk. > > Philipp. > >> And on the other direction we can see that deepsjeng isn't helped by >> Jivan's work, but is helped by Manolis's new pass. >> >> I'd always hoped/expected we'd have cases where one patch clearly helped >> over the other. While the .25% to .37% improvements for the three most >> impacted benchmarks doesn't move the needle much across the whole suite >> they do add up over time. >> >> Jeff I took a quick look at Leela, the significant difference is from additional insns with SP not getting propagated. e.g.    231b6:    mv    a4,sp    231b8:    sh2add    a5,a5,a4 vs.    1e824:    sh2add    a5,a5,sp There are 5 such instances which more or less make up for the delta. -Vineet