From: Andreas Krebbel <krebbel@linux.ibm.com>
To: Robin Dapp <rdapp@linux.ibm.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] s390: Use vpdi and verllg in vec_reve.
Date: Mon, 15 Aug 2022 17:08:51 +0200 [thread overview]
Message-ID: <73e893f5-6024-7c36-9587-448e072c0ea4@linux.ibm.com> (raw)
In-Reply-To: <0791cfa8-15be-022a-6495-2e6ddbe8ca95@linux.ibm.com>
On 8/12/22 12:13, Robin Dapp wrote:
> Hi,
>
> swapping the two elements of a V2DImode or V2DFmode vector can be done
> with vpdi instead of using the generic way of loading a permutation mask
> from the literal pool and vperm.
>
> Analogous to the V2DI/V2DF case reversing the elements of a four-element
> vector can be done by first swapping the elements of the first
> doubleword as well the ones of the second one and subsequently rotate
> the doublewords by 32 bits.
>
> Bootstrapped and regtested, no regressions.
>
> Is it OK?
>
> Regards
> Robin
>
> gcc/ChangeLog:
>
> PR target/100869
> * config/s390/vector.md (@vpdi4_2<mode>): New pattern.
> (rotl<mode>3_di): New pattern.
> * config/s390/vx-builtins.md: Use vpdi and verll for reversing
> elements.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/s390/zvector/vec-reve-int-long.c: New test.
Ok. Thanks!
Andreas
prev parent reply other threads:[~2022-08-15 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 10:13 Robin Dapp
2022-08-15 15:08 ` Andreas Krebbel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73e893f5-6024-7c36-9587-448e072c0ea4@linux.ibm.com \
--to=krebbel@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdapp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).