From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id F40323847718 for ; Wed, 3 Apr 2024 11:22:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F40323847718 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F40323847718 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712143362; cv=none; b=Hg5qcJ6XgLDp/nGAclppQJSaN0ayXjXZq1KLp3cJHyYu0NKYSG0IQRhKtGdfamC9AG7lP8GBJdsFAMvvUDpRynSwEHClq9ZfnlVQeSBwr8G1LxlyrYOQ+lrzffUlOhbxnGMnumII3Ay1KggUnDSZq/JNYblORW08cBCkleqr3O0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712143362; c=relaxed/simple; bh=CXAz/iMCnyZ3nvPYxVyOYE370Ph8GyrLb+EsbcFEwhI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=UP7p+smNFC+zftLOTW4GbRNge4oj+HyCLxGcOcXtavbpN6eErNdMGVDqXYDJn0le/N3DPlUL6BHRraUg4T9ntAs+qgBhDQIyaQsmNyKnNMRAZZgymUPqpPJM566khcwS14tlBbZL4IqDRr7DGFtR/OT2UC4LqmlVXtg03rfkn0s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-41624fe40b2so2437875e9.1 for ; Wed, 03 Apr 2024 04:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1712143358; x=1712748158; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QJmVN+xhj0wOTAceSU3E97LqOFspGbZWRfKMaBIKaOg=; b=nkcJYDdoMi7VbYdBrM69G4evty997Rywe+cGbDMd6YCXzA9oXzOtXg3kbbtgbeW2iZ Z8K6yP3WTxHhj6EDi2dnlAEP76m/r1kI5b+RRRSIcMfAEfnC/A32rk3/imF8NgFFdJLN l+dr8yMc1xFel0evg21OFHL2+YEAT1K9Ig37ACM9F+AbmoMPAS5mEQHmy0vx+fl0jZJv y/Rk2Buu6m5Ba2qtM+OUP0mqbRRPJZaAzaXAZL9KhriykIFwzZbUVwUsHdtxNc9S+JB6 TyGOXgEpfDtdu5PAg5ppX4Gm2awi6kOFyzWSeypLkhhRWCp+xx071c4mVxR3uc8W03jg Og4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712143358; x=1712748158; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QJmVN+xhj0wOTAceSU3E97LqOFspGbZWRfKMaBIKaOg=; b=O8hzpyFRu7YZH4E3hK1h1+fnaY089UeUNW0kRhWDvanIOs8QR8UdPb97AFU26UMlVY /qv2knsl9SRz6Gidnxe0MjIbEuaA4lSjavpjFb4z0W+uLTAT8yaevLuZAaLRpsenHqPQ ru/QeKDEXbkkl+RPJ9hz+mg4oP8KOw3WJ96WplNkhETHP/FZ4j4Tnp3L32Zm6fGKpVXq 208EJOhxUXw4O2J4SufJFATxXa3G3qnzAX1n8Vha8MyVQnp2O8X+dwiB84pg2vkVOaHw KVeo49dvAkrmlatP5aAIr8GpsjOQZciUfUKGS6zy4wJSFv8hTmwTt+uuglQkHAU5pGco al6w== X-Gm-Message-State: AOJu0Yzs28gYH4W2W1ZKRwlrxL+0C5op0lSxJzSTZ5wIOLnf5G27R4HC GImufKyDOgYHgH/SLOTRM3lqcPzrAWwMI9sECpAIuIs3qe6IYuTIHpkXOcq3J+0= X-Google-Smtp-Source: AGHT+IEYb9wSN1L2BV4TvZEjqhy58zuS8TlldypdRdzRyyZgNvI/dMNisalTdckCbHDWyjLEQdG6xQ== X-Received: by 2002:a05:600c:212:b0:413:f3c4:4d95 with SMTP id 18-20020a05600c021200b00413f3c44d95mr4115111wmi.10.1712143356744; Wed, 03 Apr 2024 04:22:36 -0700 (PDT) Received: from [192.168.0.118] (hawk-18-b2-v4wan-167765-cust1304.vm26.cable.virginm.net. [82.41.69.25]) by smtp.gmail.com with ESMTPSA id f14-20020a05600c154e00b00414674a1a40sm21252372wmg.45.2024.04.03.04.22.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 04:22:36 -0700 (PDT) Message-ID: <73eb907a-f234-43bf-97f2-782ebb14c6ac@baylibre.com> Date: Wed, 3 Apr 2024 12:22:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch] GCN: install.texi update for Newlib change and LLVM 18 release To: Jakub Jelinek , Tobias Burnus Cc: gcc-patches References: Content-Language: en-GB From: Andrew Stubbs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/04/2024 10:27, Jakub Jelinek wrote: > On Wed, Apr 03, 2024 at 11:09:19AM +0200, Tobias Burnus wrote: >> @@ -3954,8 +3956,8 @@ on the GPU. >> To enable support for GCN3 Fiji devices (gfx803), GCC has to be configured with >> @option{--with-arch=@code{fiji}} or >> @option{--with-multilib-list=@code{fiji},...}. Note that support for Fiji >> -devices has been removed in ROCm 4.0 and support in LLVM is deprecated and will >> -be removed in LLVM 18. >> +devices has been removed in ROCm 4.0 and support in LLVM is deprecated and has >> +been removed in LLVM 18. > > Shouldn't we at configure time then detect the case where fiji can't be > supported and either error if it is included explicitly in multilib list, or > implicitly take it out from that list and arrange error to be emitted when > using -march=fiji/gfx803 ? > Sure, if one configures against LLVM 17 and then updates LLVM to 18, it will > still result in weird errors/LLVM ICEs, but at least in the common case when > one configures GCC 14 against LLVM 18 one won't suffer from those ICEs and > get clear diagnostics that fiji is sadly no longer supported. One additional point: since our departure from Siemens, we no longer have access to any Fiji devices ourselves. I plan to rip that stuff out the first chance I get (not necessarily very soon). In the meantime, Fiji is not included in the default configuration of GCC 14, so anyone enabling it is doing so explicitly and a) will have read the documentation, and b) would be surprised if Fiji were automatically excluded. We could emit an error at configure time if an unsuitable LLVM is detected, but I don't think it's worth the effort for what is a niche product that requires drivers so old they were only supported on now-EOL OS versions. I'm happy with Tobias's patch with s/LLVM is deprecated/LLVM was deprecated/. The Newlib versions are a bit awkward, but we can't recommend 4.5 until it exists. Andrew