* [RFC/RFA] [PATCH 12/12] Add tests for CRC detection and generation.
@ 2024-05-24 8:42 Mariam Arutunian
2024-05-25 18:34 ` Jeff Law
0 siblings, 1 reply; 5+ messages in thread
From: Mariam Arutunian @ 2024-05-24 8:42 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1.1: Type: text/plain, Size: 1373 bytes --]
gcc/testsuite/gcc.c-torture/compile/
* crc-11.c: New test.
* crc-15.c: Likewise.
* crc-16.c: Likewise.
* crc-19.c: Likewise.
* crc-2.c: Likewise.
* crc-20.c: Likewise.
* crc-24.c: Likewise.
* crc-29.c: Likewise.
* crc-27.c: Likewise.
* crc-3.c: Likewise.
* crc-crc32-data24.c: Likewise.
* crc-from-fedora-packages (1-24).c: Likewise.
* crc-linux-(1-5).c: Likewise.
* crc-not-crc-(1-26).c: Likewise.
* crc-side-instr-(1-17).c: Likewise.
gcc/testsuite/gcc.c-torture/execute/
* crc-(1, 4-10, 12-14, 17-18, 21-28).c: New tests.
* crc-CCIT-data16-xorOutside_InsideFor.c: Likewise.
* crc-CCIT-data16.c: Likewise.
* crc-CCIT-data8.c: Likewise.
* crc-coremark16-data16.c: Likewise.
* crc-coremark16-data16.c: Likewise.
* crc-coremark32-data32.c: Likewise.
* crc-coremark32-data8.c: Likewise.
* crc-coremark64-data64.c: Likewise.
* crc-coremark8-data8.c: Likewise.
* crc-crc32-data16.c: Likewise.
* crc-crc32-data8.c: Likewise.
* crc-crc32.c: Likewise.
* crc-crc64-data32.c: Likewise.
* crc-crc64-data64.c: Likewise.
* crc-crc8-data8-loop-xorInFor.c: Likewise.
* crc-crc8-data8-loop-xorOutsideFor.c: Likewise.
* crc-crc8-data8-xorOustideFor.c: Likewise.
* crc-crc8.c: Likewise.
Signed-off-by: Mariam Arutunian <mariamarutunian@gmail.com>
[-- Attachment #2: 0012-Add-tests-for-CRC-detection-and-generation.patch --]
[-- Type: application/x-patch, Size: 156505 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RFC/RFA] [PATCH 12/12] Add tests for CRC detection and generation.
2024-05-24 8:42 [RFC/RFA] [PATCH 12/12] Add tests for CRC detection and generation Mariam Arutunian
@ 2024-05-25 18:34 ` Jeff Law
2024-05-26 5:02 ` Mariam Arutunian
2024-05-27 6:39 ` Richard Biener
0 siblings, 2 replies; 5+ messages in thread
From: Jeff Law @ 2024-05-25 18:34 UTC (permalink / raw)
To: Mariam Arutunian, GCC Patches
On 5/24/24 2:42 AM, Mariam Arutunian wrote:
> gcc/testsuite/gcc.c-torture/compile/
>
> * crc-11.c: New test.
> * crc-15.c: Likewise.
> * crc-16.c: Likewise.
> * crc-19.c: Likewise.
> * crc-2.c: Likewise.
> * crc-20.c: Likewise.
> * crc-24.c: Likewise.
> * crc-29.c: Likewise.
> * crc-27.c: Likewise.
> * crc-3.c: Likewise.
> * crc-crc32-data24.c: Likewise.
> * crc-from-fedora-packages (1-24).c: Likewise.
> * crc-linux-(1-5).c: Likewise.
> * crc-not-crc-(1-26).c: Likewise.
> * crc-side-instr-(1-17).c: Likewise.
>
> gcc/testsuite/gcc.c-torture/execute/
>
> * crc-(1, 4-10, 12-14, 17-18, 21-28).c: New tests.
> * crc-CCIT-data16-xorOutside_InsideFor.c: Likewise.
> * crc-CCIT-data16.c: Likewise.
> * crc-CCIT-data8.c: Likewise.
> * crc-coremark16-data16.c: Likewise.
> * crc-coremark16-data16.c: Likewise.
> * crc-coremark32-data32.c: Likewise.
> * crc-coremark32-data8.c: Likewise.
> * crc-coremark64-data64.c: Likewise.
> * crc-coremark8-data8.c: Likewise.
> * crc-crc32-data16.c: Likewise.
> * crc-crc32-data8.c: Likewise.
> * crc-crc32.c: Likewise.
> * crc-crc64-data32.c: Likewise.
> * crc-crc64-data64.c: Likewise.
> * crc-crc8-data8-loop-xorInFor.c: Likewise.
> * crc-crc8-data8-loop-xorOutsideFor.c: Likewise.
> * crc-crc8-data8-xorOustideFor.c: Likewise.
> * crc-crc8.c: Likewise.
>
> Signed-off-by: Mariam Arutunian <mariamarutunian@gmail.com
> <mailto:mariamarutunian@gmail.com>>
OK once all prerequisites are approved.
jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC/RFA] [PATCH 12/12] Add tests for CRC detection and generation.
2024-05-25 18:34 ` Jeff Law
@ 2024-05-26 5:02 ` Mariam Arutunian
2024-05-27 6:39 ` Richard Biener
1 sibling, 0 replies; 5+ messages in thread
From: Mariam Arutunian @ 2024-05-26 5:02 UTC (permalink / raw)
To: Jeff Law; +Cc: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]
On Sat, May 25, 2024, 22:34 Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
> On 5/24/24 2:42 AM, Mariam Arutunian wrote:
> > gcc/testsuite/gcc.c-torture/compile/
> >
> > * crc-11.c: New test.
> > * crc-15.c: Likewise.
> > * crc-16.c: Likewise.
> > * crc-19.c: Likewise.
> > * crc-2.c: Likewise.
> > * crc-20.c: Likewise.
> > * crc-24.c: Likewise.
> > * crc-29.c: Likewise.
> > * crc-27.c: Likewise.
> > * crc-3.c: Likewise.
> > * crc-crc32-data24.c: Likewise.
> > * crc-from-fedora-packages (1-24).c: Likewise.
> > * crc-linux-(1-5).c: Likewise.
> > * crc-not-crc-(1-26).c: Likewise.
> > * crc-side-instr-(1-17).c: Likewise.
> >
> > gcc/testsuite/gcc.c-torture/execute/
> >
> > * crc-(1, 4-10, 12-14, 17-18, 21-28).c: New tests.
> > * crc-CCIT-data16-xorOutside_InsideFor.c: Likewise.
> > * crc-CCIT-data16.c: Likewise.
> > * crc-CCIT-data8.c: Likewise.
> > * crc-coremark16-data16.c: Likewise.
> > * crc-coremark16-data16.c: Likewise.
> > * crc-coremark32-data32.c: Likewise.
> > * crc-coremark32-data8.c: Likewise.
> > * crc-coremark64-data64.c: Likewise.
> > * crc-coremark8-data8.c: Likewise.
> > * crc-crc32-data16.c: Likewise.
> > * crc-crc32-data8.c: Likewise.
> > * crc-crc32.c: Likewise.
> > * crc-crc64-data32.c: Likewise.
> > * crc-crc64-data64.c: Likewise.
> > * crc-crc8-data8-loop-xorInFor.c: Likewise.
> > * crc-crc8-data8-loop-xorOutsideFor.c: Likewise.
> > * crc-crc8-data8-xorOustideFor.c: Likewise.
> > * crc-crc8.c: Likewise.
> >
> > Signed-off-by: Mariam Arutunian <mariamarutunian@gmail.com
> > <mailto:mariamarutunian@gmail.com>>
> OK once all prerequisites are approved.
>
> jeff
>
Thank you.
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC/RFA] [PATCH 12/12] Add tests for CRC detection and generation.
2024-05-25 18:34 ` Jeff Law
2024-05-26 5:02 ` Mariam Arutunian
@ 2024-05-27 6:39 ` Richard Biener
2024-05-27 15:20 ` Jeff Law
1 sibling, 1 reply; 5+ messages in thread
From: Richard Biener @ 2024-05-27 6:39 UTC (permalink / raw)
To: Jeff Law; +Cc: Mariam Arutunian, GCC Patches
On Sat, May 25, 2024 at 8:34 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 5/24/24 2:42 AM, Mariam Arutunian wrote:
> > gcc/testsuite/gcc.c-torture/compile/
> >
> > * crc-11.c: New test.
> > * crc-15.c: Likewise.
> > * crc-16.c: Likewise.
> > * crc-19.c: Likewise.
> > * crc-2.c: Likewise.
> > * crc-20.c: Likewise.
> > * crc-24.c: Likewise.
> > * crc-29.c: Likewise.
> > * crc-27.c: Likewise.
> > * crc-3.c: Likewise.
> > * crc-crc32-data24.c: Likewise.
> > * crc-from-fedora-packages (1-24).c: Likewise.
> > * crc-linux-(1-5).c: Likewise.
> > * crc-not-crc-(1-26).c: Likewise.
> > * crc-side-instr-(1-17).c: Likewise.
> >
> > gcc/testsuite/gcc.c-torture/execute/
> >
> > * crc-(1, 4-10, 12-14, 17-18, 21-28).c: New tests.
> > * crc-CCIT-data16-xorOutside_InsideFor.c: Likewise.
> > * crc-CCIT-data16.c: Likewise.
> > * crc-CCIT-data8.c: Likewise.
> > * crc-coremark16-data16.c: Likewise.
> > * crc-coremark16-data16.c: Likewise.
> > * crc-coremark32-data32.c: Likewise.
> > * crc-coremark32-data8.c: Likewise.
> > * crc-coremark64-data64.c: Likewise.
> > * crc-coremark8-data8.c: Likewise.
> > * crc-crc32-data16.c: Likewise.
> > * crc-crc32-data8.c: Likewise.
> > * crc-crc32.c: Likewise.
> > * crc-crc64-data32.c: Likewise.
> > * crc-crc64-data64.c: Likewise.
> > * crc-crc8-data8-loop-xorInFor.c: Likewise.
> > * crc-crc8-data8-loop-xorOutsideFor.c: Likewise.
> > * crc-crc8-data8-xorOustideFor.c: Likewise.
> > * crc-crc8.c: Likewise.
> >
> > Signed-off-by: Mariam Arutunian <mariamarutunian@gmail.com
> > <mailto:mariamarutunian@gmail.com>>
> OK once all prerequisites are approved.
At some point gcc.c-torture/ was considered "legacy", is that no longer
true? I'd prefer if you add these tests to gcc.dg/torture/ instead.
Richard.
> jeff
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC/RFA] [PATCH 12/12] Add tests for CRC detection and generation.
2024-05-27 6:39 ` Richard Biener
@ 2024-05-27 15:20 ` Jeff Law
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Law @ 2024-05-27 15:20 UTC (permalink / raw)
To: Richard Biener; +Cc: Mariam Arutunian, GCC Patches
On 5/27/24 12:39 AM, Richard Biener wrote:
> On Sat, May 25, 2024 at 8:34 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>>
>>
>>
>> On 5/24/24 2:42 AM, Mariam Arutunian wrote:
>>> gcc/testsuite/gcc.c-torture/compile/
>>>
>>> * crc-11.c: New test.
>>> * crc-15.c: Likewise.
>>> * crc-16.c: Likewise.
>>> * crc-19.c: Likewise.
>>> * crc-2.c: Likewise.
>>> * crc-20.c: Likewise.
>>> * crc-24.c: Likewise.
>>> * crc-29.c: Likewise.
>>> * crc-27.c: Likewise.
>>> * crc-3.c: Likewise.
>>> * crc-crc32-data24.c: Likewise.
>>> * crc-from-fedora-packages (1-24).c: Likewise.
>>> * crc-linux-(1-5).c: Likewise.
>>> * crc-not-crc-(1-26).c: Likewise.
>>> * crc-side-instr-(1-17).c: Likewise.
>>>
>>> gcc/testsuite/gcc.c-torture/execute/
>>>
>>> * crc-(1, 4-10, 12-14, 17-18, 21-28).c: New tests.
>>> * crc-CCIT-data16-xorOutside_InsideFor.c: Likewise.
>>> * crc-CCIT-data16.c: Likewise.
>>> * crc-CCIT-data8.c: Likewise.
>>> * crc-coremark16-data16.c: Likewise.
>>> * crc-coremark16-data16.c: Likewise.
>>> * crc-coremark32-data32.c: Likewise.
>>> * crc-coremark32-data8.c: Likewise.
>>> * crc-coremark64-data64.c: Likewise.
>>> * crc-coremark8-data8.c: Likewise.
>>> * crc-crc32-data16.c: Likewise.
>>> * crc-crc32-data8.c: Likewise.
>>> * crc-crc32.c: Likewise.
>>> * crc-crc64-data32.c: Likewise.
>>> * crc-crc64-data64.c: Likewise.
>>> * crc-crc8-data8-loop-xorInFor.c: Likewise.
>>> * crc-crc8-data8-loop-xorOutsideFor.c: Likewise.
>>> * crc-crc8-data8-xorOustideFor.c: Likewise.
>>> * crc-crc8.c: Likewise.
>>>
>>> Signed-off-by: Mariam Arutunian <mariamarutunian@gmail.com
>>> <mailto:mariamarutunian@gmail.com>>
>> OK once all prerequisites are approved.
>
> At some point gcc.c-torture/ was considered "legacy", is that no longer
> true? I'd prefer if you add these tests to gcc.dg/torture/ instead.
I don't recall that, but sure, it should be easy to move them over to
gcc.dg/torture. Noted for the future as well.
Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-27 15:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-24 8:42 [RFC/RFA] [PATCH 12/12] Add tests for CRC detection and generation Mariam Arutunian
2024-05-25 18:34 ` Jeff Law
2024-05-26 5:02 ` Mariam Arutunian
2024-05-27 6:39 ` Richard Biener
2024-05-27 15:20 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).