From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id D0BD53858D33 for ; Tue, 20 Feb 2024 12:03:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0BD53858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D0BD53858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708430631; cv=none; b=wwIGBTrdsJ6djzDr/dVLOdb8EPBr+a7JJXtR2EkNRWh98vKB0UHqx5fJBCgWgJeLW+P6qm2C53vQWA4mtgBAftmBTBCywLtRWspkSM6EPJ+1wE5FnhOeWSoaHZudL/0N3jeUx1IXZT4FUKh4r+9k7uwqnA4GqGshvKXuwpTOhx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708430631; c=relaxed/simple; bh=kwqFRPbABTxBCl/eHaJM7Q2TcLqvhZiWfTScmL3s9Ss=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=m2pQeU26qjxMXUjYM43Fw4Er+VnS4kpb3+4gkNX1zfEICvYmW6vnq1sMloKszK3t8Pt9wPCUPLl5bxJ1ynW3NChago1bXpJX6/TgL6nDycTsSsnT3FQZzQewXTDpCZZtENOWD7Z7XYOEOpqkB7HcGKvT3AxQCkXrLUNa+GkKE5o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcOqe-0000hm-Q3 for gcc-patches@gcc.gnu.org; Tue, 20 Feb 2024 07:03:48 -0500 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8CxmegcldRlfDgPAA--.20316S3; Tue, 20 Feb 2024 20:03:40 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxzxMcldRl4Lw8AA--.36127S3; Tue, 20 Feb 2024 20:03:40 +0800 (CST) Subject: Re: LoongArch: Backport r14-4674 "LoongArch: Delete macro definition ASM_OUTPUT_ALIGN_WITH_NOP."? To: Xi Ruoyao Cc: gcc-patches@gcc.gnu.org, WANG Xuerui , Jiajie Chen , Chenghua Xu References: <9b08cb2a-a193-3da9-9e28-50740898062e@loongson.cn> <74d30af4a8d6366e2b47496c32462243d00406a9.camel@xry111.site> <92ff9d8c-f1e4-5be4-72eb-4d3569b92eae@loongson.cn> <0c35a60aa584ce78bcb58c1dd601e08ee6d6bf55.camel@xry111.site> From: chenglulu Message-ID: <7405b3d0-15ce-f292-6ed4-dc6d708f3660@loongson.cn> Date: Tue, 20 Feb 2024 20:03:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <0c35a60aa584ce78bcb58c1dd601e08ee6d6bf55.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8AxzxMcldRl4Lw8AA--.36127S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7Aw1Dtw1xWry3Kry7WF1xWFX_yoW8Cw18pF WDt3WYkF90kFn7tws7K34avry3trsxtayUXw4DJFW8XrsIyryqgr4Yvrs09Fy29r4kGr1Y vw1xt343Xr10yFXCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9ab4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv 67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C2 67AKxVWUtVW8ZwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI 8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWU CwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r 1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsG vfC2KfnxnUUI43ZEXa7IU8P5r7UUUUU== Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9,NICE_REPLY_A=-3.297,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2024/2/20 下午7:54, Xi Ruoyao 写道: > On Tue, 2024-02-20 at 19:50 +0800, chenglulu wrote: >> 在 2024/2/20 下午7:31, Xi Ruoyao 写道: >>> On Tue, 2024-02-20 at 19:25 +0800, Xi Ruoyao wrote: >>>> On Tue, 2024-02-20 at 10:07 +0800, chenglulu wrote: >>>> >>>>> So I think that without worrying about performance and ensuring that >>>>> there is no problem >>>>> >>>>> with binutils, I think we can make the following modifications: >>>>> >>>>>     -/* "nop" instruction 54525952 (andi $r0,$r0,0) is >>>>>     -   used for padding.  */ >>>>>     +/* ".align num,,4" will insert "nop"(andi $r0,$r0,0) into padding by >>>>>     +   default.  */ >>>>>      #define ASM_OUTPUT_ALIGN_WITH_NOP(STREAM, LOG) \ >>>>>     -  fprintf (STREAM, "\t.align\t%d,54525952,4\n", (LOG)) >>>>>     +  fprintf (STREAM, "\t.align\t%d,,4\n", (LOG)) >>>>> >>>>> What do you think of it? >>>> Unfortunately it will cause warnings with GAS 2.41 or earlier like >>>> >>>> t1.s:1: Warning: expected fill pattern missing >>>> t1.s:5: Warning: expected fill pattern missing >>>> >>>> And AFAIK these things may cause many test failures due to "excessive >>>> errors" if running the GCC test suite with these earlier GAS versions. >>>> Maybe we'll have to add some autoconf-based probing for the linker >>>> anyway? >>> Or just silence the warning passing "--no-warn" to the assembler but I'm >>> highly unsure if this is really a good idea :(. >>> >> I am not opposed to adding detection code, but I looked at this problem >> today >> >> and I think this change is the smallest change. I asked Meng Qinggang and he >> >> said that the warning of GAS 2.41 can be removed. > Yes, but we cannot change a released binutils-2.41 tarball and Binutils > folks don't make point releases like GCC. > OK, I agree with you. I will backpoint r14-4674 and r14-5434 to gcc12 and gcc13.