From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 192DD3858D35 for ; Wed, 15 Feb 2023 19:05:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 192DD3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x633.google.com with SMTP id o8so18849350pls.11 for ; Wed, 15 Feb 2023 11:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OsmOpHcSwX33cqISe7x7EZUnx+hIssBIeQb5ZH+J2Wc=; b=FL7DGD8ZVwalO+NRU6efoMtt7YBnKwFCYxiiqKgXALt/RuUXVjBme15D6ZI1PPjKeF CQEZOCDDMkYgACNHVpyMnzw1OY8SFr8FbLprcS6596hRtbl5w4vX9PBLPqm9N2FOmVt3 pfr3S4w4IK4mLPy9k0TZvj9rvbSrHKjTtQHDzGEY0XJ3ED8aDtYkkfV0yFagRhGfBhuF Hgs9HdpM+egOpknvpmWxNn16TMxkH87qC8c1U3FJ/TZyt7hO2s5K5b+tKaBtejFCvcjG ppB5kApY4Ceqsa4jKkDaVcETuutER8XRtfr3N1/23c+e5Unpm+7qwVzuFttIAFhL/Qsn 1v5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OsmOpHcSwX33cqISe7x7EZUnx+hIssBIeQb5ZH+J2Wc=; b=FAhJ9w0E3AUAQbD6rSKtI3muJZkvWAWB6Ln8TGWdFonRERXIjP9kVoJyfvxrPbYPIg KQHhQZFvUck9pRQ1yma3iYQDUBOflAA5UhQW2TV6N2XZ+3eTADk45KUTZi8P1+AnEzYW r7F6qYWUKaEkhW9qcA8rI5laMJqwDPP6L/pB5n7pYWlNVOqFFJWy07gVWycuTf9rKY2J qY6tb9C2nw0t/6bIq5alb+TRLolzxAGPuPW+WZvWMI+F9iazmlu18rrafS/uldPtaZ17 Ad/0gVrzOLVK5C5H8DfaqcFUgIIgEEBi0t6MAGOSLLjNNi+tLD7Y1MNFwRkk/h0UWfA4 kDlg== X-Gm-Message-State: AO0yUKVORbbpFA2u48kAw/l30Rxq31s4mmyGhhCQ0y1Ps0ljp5r1cuaq nxwO5QDppqIF8sCrUR+ok2w= X-Google-Smtp-Source: AK7set/fqpGlRWgXg3xiLcQNO3Re0uooH+5XKkWqNvczgCPMnMCM7Ej3uD/0LCHE/5Rwtf8VDUjr2Q== X-Received: by 2002:a17:902:dad1:b0:199:4934:9d33 with SMTP id q17-20020a170902dad100b0019949349d33mr4096532plx.15.1676487937618; Wed, 15 Feb 2023 11:05:37 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id d6-20020a170902c18600b0019a83f2c99bsm8738956pld.28.2023.02.15.11.05.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 11:05:37 -0800 (PST) Message-ID: <7426a87a-42a3-de86-c67f-5063f0b5cd65@gmail.com> Date: Wed, 15 Feb 2023 12:05:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] Fix PR target/90458 Content-Language: en-US To: Eric Botcazou , gcc-patches@gcc.gnu.org References: <8221231.NyiUUSuA9g@fomalhaut> From: Jeff Law In-Reply-To: <8221231.NyiUUSuA9g@fomalhaut> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/15/23 08:24, Eric Botcazou via Gcc-patches wrote: > Hi, > > this is the incompatibility of -fstack-clash-protection with Windows SEH. Now > the Windows ports always enable TARGET_STACK_PROBE, which means that the stack > is always probed (out of line) so -fstack-clash-protection does nothing more. > > Tested on x86-64/Windows and Linux, OK for all active branches? > > > 2023-02-15 Eric Botcazou > > * config/i386/i386.cc (ix86_compute_frame_layout): Disable the > effects of -fstack-clash-protection for TARGET_STACK_PROBE. > (ix86_expand_prologue): Likewise. > OK. THanks for taking care of this. I let it languish far too long. jeff