public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Qing Zhao <qing.zhao@oracle.com>
To: Richard Biener <rguenther@suse.de>
Cc: Richard Sandiford <richard.sandiford@arm.com>,
	Kees Cook <keescook@chromium.org>,
	Gcc-patches Qing Zhao via <gcc-patches@gcc.gnu.org>
Subject: Re: [patch for gcc12 stage1][version 2] add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc
Date: Tue, 27 Apr 2021 10:10:39 -0500	[thread overview]
Message-ID: <74826C7C-D512-4CC1-9AB8-5F76086790FC@oracle.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2104270827000.9200@zhemvz.fhfr.qr>



> On Apr 27, 2021, at 1:30 AM, Richard Biener <rguenther@suse.de> wrote:
> 
>> 
>> equivalent in all respects.  And if we were trying to make them
>> equivalent, we'd need to do much more than this.
>> 
>> The same applies to the pattern case.  If “x” is initialised to a pattern
>> that happens to point to a real decl, we don't have to preserve the
>> order of accesses to the decl wrt accesses to “*x” (especially since
>> we're hoping that “*x” will trap).
>> 
>> I think for aliasing purposes, the .DEFERRED_INIT return value is still
>> analogous to an undefined SSA name, even though we will later generate
>> code to initialise it.
> 
> (only replying to this part, I'll look at the next revised patch series)

Okay, thanks.

> 
> Since .DEFERRED_INIT does not produce any pointers and is not a real
> initialization you don't need to do anything in PTA - but you might
> want to ignore it to not pessimize it by the default handling.  Thus
> 
> +  if (gimple_call_internal_p (t, IFN_DEFERRED_INIT))
> +    {
> +      find_func_aliases_for_deferred_init (t);
> +      return;
> +    }
> 
> should simply return and find_func_aliases_for_deferred_init can be 
> removed.

Okay. Will do that.

thanks.

Qing


  reply	other threads:[~2021-04-27 15:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24 21:21 Qing Zhao
2021-04-07 14:44 ` Qing Zhao
2021-04-07 22:19 ` Kees Cook
2021-04-08 15:22   ` Qing Zhao
2021-04-23 19:05 ` Richard Sandiford
2021-04-23 19:33   ` Kees Cook
2021-04-26 15:09   ` Qing Zhao
2021-04-26 17:47     ` Richard Sandiford
2021-04-26 20:02       ` Qing Zhao
2021-04-27  6:30       ` Richard Biener
2021-04-27 15:10         ` Qing Zhao [this message]
2021-05-05 17:29     ` Qing Zhao
2021-05-05 14:41   ` Qing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74826C7C-D512-4CC1-9AB8-5F76086790FC@oracle.com \
    --to=qing.zhao@oracle.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=keescook@chromium.org \
    --cc=rguenther@suse.de \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).