From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id D625C3858C31 for ; Thu, 14 Mar 2024 08:59:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D625C3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D625C3858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710406756; cv=none; b=H4QxBCsOnDsHQDT18iNifZ1woaPDvcqxXbx78aIjoWLgFIYkv7CIuaaMB1PVdlv2QIsbevhyBTx2nEyA6k0BlEuhDpnO3KzcHM6LqhvwH89zREEKv/E1aIzeFfDHzDYdb8B3LL5RyVl6vG8fpJyjP1dvdiwPFO8tKYLzcF+6okk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710406756; c=relaxed/simple; bh=8086cNnSt4NqSyIVt0A+r+FU9xeVcu7Ti2bZvTLMe50=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=ZzTelZ2aibyeLVcwXJJWZiAdzjs+xK/ayQHsWSK1uX983rqIKWZv22c8Z3McR/N85ii0koOgR1wg1RXxsS4pYCKPpW19S+6JjMnzf2tx4AFMzTgK7j/TnClzvSR63A9ozADwJ6MJX2fJpzdp4jFLG0/VquRgW22FXnfAKdC6VA8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B778B1F822; Thu, 14 Mar 2024 08:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710406752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LiKwTBQvJICEh2LLIyyVyxW4vy86v2BGwgPZxblqub0=; b=NVg8INP+kNFsXycvL4HK168FUBJsFZ9nwuqv9icQJlb06HhUPGlmzAK5gVXtYRQCsftDsj CWfNwRljuqBjhP42C7pQDGR5XXJVKlMVWQQ9/ES5ga0mNqQMv7cV1X8qTkqqk/HKi11wwD C2EkYVyRiVZ+KQh8NRKvBrgVNFBI2jA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710406752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LiKwTBQvJICEh2LLIyyVyxW4vy86v2BGwgPZxblqub0=; b=qIqAglcopo8Yu5LQli00qfj23bx68jvZ/2l/gv2MX5S8p5WPVtJ3lqO6tuRb1C3z0uCPXs KawgY7RhElukVHBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710406752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LiKwTBQvJICEh2LLIyyVyxW4vy86v2BGwgPZxblqub0=; b=NVg8INP+kNFsXycvL4HK168FUBJsFZ9nwuqv9icQJlb06HhUPGlmzAK5gVXtYRQCsftDsj CWfNwRljuqBjhP42C7pQDGR5XXJVKlMVWQQ9/ES5ga0mNqQMv7cV1X8qTkqqk/HKi11wwD C2EkYVyRiVZ+KQh8NRKvBrgVNFBI2jA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710406752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LiKwTBQvJICEh2LLIyyVyxW4vy86v2BGwgPZxblqub0=; b=qIqAglcopo8Yu5LQli00qfj23bx68jvZ/2l/gv2MX5S8p5WPVtJ3lqO6tuRb1C3z0uCPXs KawgY7RhElukVHBA== Date: Thu, 14 Mar 2024 09:59:12 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] bitint: Fix up adjustment of large/huge _BitInt arguments of returns_twice calls [PR113466] In-Reply-To: Message-ID: <74930234-p163-pqn4-4r73-7s578313238q@fhfr.qr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -1.28 X-Spamd-Result: default: False [-1.28 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.17)[-0.867]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.00)[42.22%] X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 14 Mar 2024, Jakub Jelinek wrote: > On Thu, Mar 14, 2024 at 09:48:45AM +0100, Richard Biener wrote: > > Ugh. OK, but I wonder whether we might want to simply delay > > fixing the CFG for inserts before returns-twice? Would that make > > things less ugly? > > You mean in lower_call just remember if we added anything before > ECF_RETURNS_TWICE call (or say add such stmt into a vector) and > then fix it up before the end of the pass? Yeah, or just walk BBs with abnormal preds, whatever tracking is easier. > I can certainly try that and see what is shorter/more maintainable. > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)