From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66928 invoked by alias); 30 Oct 2017 12:17:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 66919 invoked by uid 89); 30 Oct 2017 12:17:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=UD:eu X-HELO: mail-yw0-f176.google.com Received: from mail-yw0-f176.google.com (HELO mail-yw0-f176.google.com) (209.85.161.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Oct 2017 12:17:37 +0000 Received: by mail-yw0-f176.google.com with SMTP id t71so11319949ywc.3 for ; Mon, 30 Oct 2017 05:17:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Qe9L7leVrI/2dZ+lyYIHwP0Iv95b/kT/qELU+c1BDKQ=; b=UWlbpmWAXnxvTj097V/1jUIKe7BYGpd3hXIWsQzJtKuZ/gLmCOoagjXa6wzUM8St13 mOWoWvXwrpNEbMe2gJ+ZvlYrn+YiMIe/JnyHz5SsbiUqNuGd15ws5iXU33wkVbkCSVCw EqMPPyicSwYPUHM3H9Y1ETUYDAiskEYGqv8//503l7DSoo0YqKR4fePPlu9O6HgzfS4H umFbnkuaV/KTw2mlph0JmM34OsM8DVnY+Yhdi3YhiY6c5KWRxuUhU5kxHCAI+7slMBB8 r/OnV/GzZahJlv4sUeLs9up5Yh6jHl79/SECDCReb3jH/VOH+a9gQJ0h1nlicuLXAf0A MYcg== X-Gm-Message-State: AMCzsaWgbd9ozq2Eiloy880SDSzlMEFpVt5l/9/vD9oBC/dIyEpXHav4 JjYJeU5UgSMgnyNv8FMRVgY= X-Google-Smtp-Source: ABhQp+SESoXSBHNZC3TnVPYROfl4N6QhhghNHhkpYYuW3DyIsLgk95rEYb2MnNCBzGsS/cP7Wgwfsw== X-Received: by 10.13.216.75 with SMTP id a72mr5715867ywe.303.1509365855627; Mon, 30 Oct 2017 05:17:35 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a3:20fb:7500:e7fb:4a6f:2254? ([2620:10d:c091:200::3:68fe]) by smtp.googlemail.com with ESMTPSA id o186sm7135937ywo.44.2017.10.30.05.17.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Oct 2017 05:17:35 -0700 (PDT) Subject: Re: [PATCH 2/7] GCOV: introduce usage of terminal colors. To: marxin , gcc-patches@gcc.gnu.org References: Cc: David Malcolm From: Nathan Sidwell Message-ID: <7498ccab-6b8f-569f-81fe-66c2c3fe978b@acm.org> Date: Mon, 30 Oct 2017 12:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg02185.txt.bz2 On 10/26/2017 04:11 AM, marxin wrote: > I consider using colors in context of gcov as very useful. There's > example for tramp3d: > https://pste.eu/p/Tl2D.html nice! > gcc/ChangeLog: > > 2017-10-23 Martin Liska > > * color-macros.h: New file. > * diagnostic-color.c: Factor out color related to macros to > color-macros.h. > * doc/gcov.texi: Document -k option. > * gcov.c (INCLUDE_STRING): Include string.h. > (print_usage): Add -k option. > (process_args): Parse it. > (pad_count_string): New function. > (output_line_beginning): Likewise. > (DEFAULT_LINE_START): New macro. > (output_lines): Support color output. The gcov changes are ok. I guess David has the review ball for the diagnostic refactoring? nathan -- Nathan Sidwell