From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Nathan Sidwell <nathan@acm.org>, gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Fix xvalue COND_EXPR handling (PR c++/88103)
Date: Mon, 03 Dec 2018 19:44:00 -0000 [thread overview]
Message-ID: <74c055da-473a-9a34-15fc-badc3c13e504@redhat.com> (raw)
In-Reply-To: <20181202130722.GP12380@tucnak>
On 12/2/18 8:07 AM, Jakub Jelinek wrote:
> On Sat, Dec 01, 2018 at 07:11:08PM -0500, Jason Merrill wrote:
>>> On the following testcase, build_conditional_expr_1 tries hard to make sure
>>> that if both arguments are xvalue_p (or one is and the other throw) the
>>> result is still xvalue_p. But, later on we call unary_complex_lvalue,
>>> which does rationalize_conditional_expr which changes it from
>>> cond ? x : y to *(cond ? &x : &y) and that change turns something formerly
>>> xvalue_p into newly lvalue_p.
>>>
>>> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,
>>> ok for trunk?
>>>
>>> 2018-11-29 Jakub Jelinek <jakub@redhat.com>
>>>
>>> PR c++/88103
>>> * typeck.c (unary_complex_lvalue): If a COND_EXPR is xvalue_p, make
>>> sure the result is as well.
>>>
>>> * g++.dg/cpp0x/rv-cond3.C: New test.
>>>
>>> --- gcc/cp/typeck.c.jj 2018-11-27 09:48:58.506103668 +0100
>>> +++ gcc/cp/typeck.c 2018-11-29 21:00:33.900636750 +0100
>>> @@ -6503,7 +6503,16 @@ unary_complex_lvalue (enum tree_code cod
>>> /* Handle (a ? b : c) used as an "lvalue". */
>>> if (TREE_CODE (arg) == COND_EXPR
>>> || TREE_CODE (arg) == MIN_EXPR || TREE_CODE (arg) == MAX_EXPR)
>>> - return rationalize_conditional_expr (code, arg, tf_warning_or_error);
>>> + {
>>> + tree ret = rationalize_conditional_expr (code, arg, tf_warning_or_error);
>>> + /* Preserve xvalue kind. */
>>> + if (xvalue_p (arg))
>>> + {
>>> + tree reftype = cp_build_reference_type (TREE_TYPE (arg), true);
>>> + ret = cp_convert (reftype, ret, tf_warning_or_error);
>>
>> Is there a reason not to use the 'move' function here?
>
> That doesn't work at all. move doesn't call cp_convert, but
> build_static_cast (though for the same reference && type).
> But while cp_convert only adds NOP_EXPR around it, build_static_cast adds
> a target_expr, addr_expr around that, nop_expr cast to the reference && type
> and finally indirect_ref that the caller doesn't expect, because it adds it
> by itself, e.g. in
> 2424 if (temp)
> 2425 object = cp_build_fold_indirect_ref (temp);
So the caller is trying to take the address of the COND_EXPR, which
should have POINTER_TYPE. And then indirecting that gives an lvalue, as
it should. The bug is in the caller, build_class_member_access_expr.
Jason
next prev parent reply other threads:[~2018-12-03 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 21:52 Jakub Jelinek
2018-12-02 0:11 ` Jason Merrill
2018-12-02 13:07 ` Jakub Jelinek
2018-12-03 19:44 ` Jason Merrill [this message]
2018-12-03 21:36 ` Jakub Jelinek
2018-12-03 21:58 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c055da-473a-9a34-15fc-badc3c13e504@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).