From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 3E68D3858439; Wed, 8 Dec 2021 23:12:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E68D3858439 Received: by mail-pl1-x62b.google.com with SMTP id u17so2557538plg.9; Wed, 08 Dec 2021 15:12:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=c5anJgI5UNWCHfnfbRsCCPUJ7eI+n6lz0a5Bw6ISIks=; b=A9/n2ti22Pb5HV4OO71z7g4Ppc6ya+swPq5GSOTCMJIKCW5FlROpUv0CNereoJX1+8 4AgnI+1dJ4tNex2uYDeYjNLNQOmwSsqEoD3kwzKZl/c1+Hd+Dl3drH8TCEVi9FSltkk8 aW+HNliM0xTsNcmTW22vPi21Ox3WFa5C4YiBxqTDz2fro5ECg3WA3ra6sWXSPsLVCZq8 dvL2dFvoRafoxqH4dXz+6MhUV1zrAyIwfZ0F5rWx8twchdemT6pFiZMXxL9vsElexGkx aIM+IHNzlZaOo/aOCSOB35HeMSLwASWVoBdC28GyHUGS9aTAlAg5pFfEQ9MeL+UAMtOe zPPQ== X-Gm-Message-State: AOAM531UZtPetUSVnXRNoNBfwozh+U44hcW/elVZNVq7QLeG6eVN3ybs mOEfftwoWU+2Eh3Ih1rTMPYVXSbnm+qfuA== X-Google-Smtp-Source: ABdhPJw0DyPruIEwa/aztUrbS4d5dW194pqbFCU791BHz2NntC4dPA17EGt4v4Jk7eqiW1+tR2fGJg== X-Received: by 2002:a17:902:728e:b0:143:a388:868b with SMTP id d14-20020a170902728e00b00143a388868bmr63440366pll.33.1639005126351; Wed, 08 Dec 2021 15:12:06 -0800 (PST) Received: from [192.168.1.15] (65-130-80-28.slkc.qwest.net. [65.130.80.28]) by smtp.gmail.com with ESMTPSA id y190sm4503766pfb.203.2021.12.08.15.12.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Dec 2021 15:12:06 -0800 (PST) Message-ID: <74d2af86-c1c4-0842-b319-09e76b3bf633@gmail.com> Date: Wed, 8 Dec 2021 16:12:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PR103302] skip multi-word pre-move clobber during lra Content-Language: en-US To: Alexandre Oliva , gcc-patches@gcc.gnu.org Cc: zsojka@seznam.cz, wilson@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 23:12:08 -0000 On 12/7/2021 10:37 PM, Alexandre Oliva via Gcc-patches wrote: > If we emit clobbers before multi-word moves during lra, we get > confused if a copy ends up with input or output replaced with each > other: the clobber then kills the previous set, and it gets deleted. > > This patch avoids emitting such clobbers when lra_in_progress. > > Regstrapped on x86_64-linux-gnu. Verified that, applied on a riscv64 > compiler that failed the test, the asm statements are no longer dropped > in the reload dumps. Running a x86_64-x-riscv64 regression testing now. > Ok to install? > > > for gcc/ChangeLog > > PR target/103302 > expr.c (emit_move_multi_word): Skip clobber during lra. > > for gcc/testsuite/ChangeLog > > PR target/103302 > * gcc.target/riscv/pr103302.c: New. OK.  Nit in the ChangeLog.  You forgot a '*' before the expr.c entry. jeff