From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 723BC3853804 for ; Wed, 23 Mar 2022 22:33:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 723BC3853804 Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-53-laDmJWzxOk2D5j4R39c1Nw-1; Wed, 23 Mar 2022 18:33:42 -0400 X-MC-Unique: laDmJWzxOk2D5j4R39c1Nw-1 Received: by mail-qv1-f71.google.com with SMTP id 33-20020a0c8024000000b0043d17ffb0bdso2277882qva.18 for ; Wed, 23 Mar 2022 15:33:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Cfvi1AlDgRSz3GCvvD7uEXYwa8i6C+Fpwa0rA8ZfaIk=; b=HzUtelepMnTJEy8yqj4fvZvCuC+BgIvfC6P/SA/grJs7opMRO2cGaB2FkS7Rc6rCk2 qW/yBClWpzjUBGFk+sJ+ksf8xGkSjKvZTXiSrbztG7O+SQp3WZRI/MeJt2hkHC+s5Ro1 pd3E2XXe+zQmy1vlf60tL+y0pSidpuBjdcBPFnIC/bBzuln1+X1VD8WBYx9hJF3MRDX3 y8GkIbL4H9H7qPij2yo0wT1yXt3L4BjaCPWRXQvaCa90yGKJ2AGBOoqk9LutU7OVZ/ZB KUFrSa4tpDOdOUiXpxK4SI45TdWn12NvakVIwWNiVg/1gW7atCYAL0W+dT9z2W2oC/Yt mmrA== X-Gm-Message-State: AOAM5323RlWBIa9BGwhZSubKrG4xgOxdAalD2qNWZWBp8pJe+SA3W62C 3cTZMtox/5MUDvOWewVdGBxnxTPABOMxOeAhkv+YrXJcD5aBUQ6T3nFqoq14/1ezWh7KI7irODX 61SJjMECM1E4WNJ7SlQ== X-Received: by 2002:ae9:e891:0:b0:47b:a53f:5f00 with SMTP id a139-20020ae9e891000000b0047ba53f5f00mr1476823qkg.693.1648074821409; Wed, 23 Mar 2022 15:33:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUWvMo0rrs99FJAPY+ErMAtESm94xVdvI/XVN4D0bxUHRWI6ap//h7yuqfEhM7FEeEzLfBhA== X-Received: by 2002:ae9:e891:0:b0:47b:a53f:5f00 with SMTP id a139-20020ae9e891000000b0047ba53f5f00mr1476813qkg.693.1648074821130; Wed, 23 Mar 2022 15:33:41 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id d11-20020a05620a166b00b0067e380258e7sm626823qko.73.2022.03.23.15.33.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 15:33:40 -0700 (PDT) Message-ID: <74f322a9671d38ef5928bce69987e0de531a75ec.camel@redhat.com> Subject: Re: [PATCH] Docs: Document that taint analyzer checker stops other checkers From: David Malcolm To: Avinash Sonawane Cc: gcc-patches@gcc.gnu.org Date: Wed, 23 Mar 2022 18:33:38 -0400 In-Reply-To: <20220323114709.08fa7e04@optimus> References: <20220322234308.0e686151@optimus> <20220323114455.288e19be@optimus> <20220323114709.08fa7e04@optimus> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2022 22:33:52 -0000 On Wed, 2022-03-23 at 11:47 +0530, Avinash Sonawane wrote: > Apologies! Forgot to attach the patch v2. > > Done now. Thanks for the patch! (forgetting to attach it is something of a rite of passage) The content of the v2 patch looks good to me; I tried regenerating the manpage and I think it's a nice improvement in readability. I double- checked the options and I think you got it all correct. I wondered if there's a dedicated syntax for adding a cautionary note to a texinfo document, but there doesn't seem to be, so that part of the patch is good as-is. This is almost ready to push to trunk, but there are a couple of extra tasks needed to be done: (a) the patch needs a ChangeLog entry in its commit message to pass our git hooks, giving a brief description of what the change is. See https://gcc.gnu.org/codingconventions.html#ChangeLogs and you can use ./contrib/gcc-changelog/git_check_commit.py HEAD to test that the ChangeLog message in the git commit will be pushable. (b) the patch is now sufficiently large that it might be above the threshold where the FSF cares about copyright, so please add a sign-off line to the patch to certify that you wrote it (and various other legal niceties). See https://gcc.gnu.org/dco.html Some more notes on GCC patches can be seen at: https://gcc.gnu.org/contribute.html Thanks again for the patch; let me know if anything's unclear. Dave