From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 299283858D37; Thu, 16 Nov 2023 19:30:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 299283858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 299283858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700163040; cv=none; b=mSx1b9m4AUQ9iyAQuN5X00ym0uOKghCnslGmrHH9B481fQNx+1WjS6Wr5S+gXANVGQR1VabgaRy2M0JOg+ucY+z3gwKm9LEkQC/Sf8hnKxWOHmrWRXUbRYTLx9oXtsbLgQVT2fB2MkEf//lcHHhk31WDpjpZF0F5wqKSQHhl4+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700163040; c=relaxed/simple; bh=qVBdO8aw9GziUitNw6lyI8bzISFP2qJSs6+tu1dAAA4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=eGP9Hg/DWCv+cpswVoD+oF1nTn8Q+iI3yZG11azgLT+yLd1cObLYvLSC8CWhcIK4jlb+JKjwrICEfJjABpbNK076DUlffNTuewAQ8esfdJ0X9DBtTzB085nvgwbByidR88B0N0bC4XymbVP9G4SOV0IDAPkQIFUUzdS7MUQKDQY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1700163034; x=1700767834; i=anlauf@gmx.de; bh=qVBdO8aw9GziUitNw6lyI8bzISFP2qJSs6+tu1dAAA4=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=Q5A6xXGsmyh4YNbESenfdrBSO0Ay4+eUaoKHkQdqZD1qD2mQsdJs8wmrciOvObfG XMLIRn819FkFmiVE2KeGwVEcPkwY97D3S025LGKH5IonA9RqS7bnIaKY4Vqk26+Xg z8ShzuQONLkizy6E32bZusXYaWk2wzkdvBJ7uzQbh3P2m6g2dzoBwCb2OC0ZYNiIH MFeyLV/8HvR3rWeJqH6i7+WVoY1dXyrPgq/by7m0nphcHjvR0fzvAApkzgX1KAsie Tt/+f3lxYKDxjEE4S/jAjT7rUXMirFuOHswYLIZiZ0JiEs6WDRJXcjC5s5H9M0RlF EInUJ1sdM/rwBsM2+A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.232.146.227]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MnJlc-1rkhnq2M9k-00jHkT; Thu, 16 Nov 2023 20:30:34 +0100 Message-ID: <750b022e-0291-4d35-9cd1-0957023cbb4a@gmx.de> Date: Thu, 16 Nov 2023 20:30:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch] Fortran: Accept -std=f2023 support, update line-length for Fortran 2023 To: Tobias Burnus , gcc-patches , fortran Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:5O4KmOOXMGK/HCLd5v1oP0bg7xP6xZFgnVJXrnO1y+kkKuI3XGq mTMymyBaQkUy4h371pDDMuG2/SSkZnE+jpKPeYiyiroNQHrYCW+nz7rrlC/h1i8v0eihoC4 OeFrdFFhLhYyOMjVzUTKuNpIZIgfHSE2D8f5MUiJn5uiyLOShRjoBQbS+JS13ImsP95gaGJ M64MIq7todz/+wPl1giVQ== UI-OutboundReport: notjunk:1;M01:P0:4SG1oAk6oXA=;8G8V4CUntA9QUgB7jE9GW54PRsa ah/OAYH0aNvQLyDUzc0knlW79IKsRMlH1otSyxXSUAi6txxVUl7kuX2cOTqp524FE1BKu2B1y /FP2N6YfGGqH96v/aYqMA9dXzUK5aZL7tK/smx/x2NPz5HX9Gpa5F7rCMmWcLiIjfA5f+3/DR EDefkFGksugkpu/WYj5c/j4DMiMQkyA77p7olpHDGvBSpccuXZoUcerpccFAhRT9fWGO+j+kV ioyY8isoMmRDguklbmSIPOKY7vRmAo65fH+NuyMFLMeDJiPY1dSRY2xicQ+1vcO+6sjHvKL2e fkXeRIuAcnFCQzkpgqgekN2ebzoEbKRSePVgw6ACVuYVD3j+18yv1IbPR9ogkD7jvcu+j+Jt5 t0OCt9Y+6YFSjgEIA18QwVhq6vkdQWR/S0GCxfjg+fA7u1o5p3+R3FdsXy72WO/P7Ck47aGln eVxwsFEK0veKu3FGvS7NXUP/3ObaG+Fp0xaShVHJ6GdW2dowo7qIF+Hs1aDYQ0WB/B3ejVpOB YgTh/hjmhAN2YC8W6FPlflkqE/MnawznXMZsqji2lZYB8Z2rQJe2cOE4002VyP1GKfASU9S/3 33RLrTC2UYpTHdyZDGO9PmRwR9EwNSAP/rMBzm9l2hotao6+2JL3sYjzYCzVRjE/2p0W502bJ QDvsPs8YRhgK78ccaWEOeCuTqj7Dc5Q1Q/0xEW0cNloz7nacK68HEV4Dvl4A1aYamNi/M4R3w GcbleB3s3ZKwCSj4W4G0RvZuVW7+yyRsaVBtqK9hx5WZG5h1tS9f4KxMp09OCxAsJsuWHre79 SRzytTcbQYTXSNUKS7r5sFxS/rDIfuWRM6a0CRaxybWaOi+eVFxevYcxu4sQ6I8rnplCIIvPd Uq5h/BF7f572wdwATXl0zTBMG9VMTBmBV84GyzOZ5E94zxxYekMRQ1SOW0aXHuEVaeKhJMWkL D5eqevds+OqLf7p+S9c/YvIqTpE= X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tobias, On 11/16/23 14:01, Tobias Burnus wrote: > This adds -std=3Df2023, which is mostly a prep patch for future changes. > > However, Fortran 2023, https://j3-fortran.org/doc/year/23/23-007r1.pdf > changes two things which is taken > care in this patch: > > (A) In "6.3.2.1 Free form line length": > > Fortran 2018: "If a line consists entirely of characters of default kind > (7.4.4), it shall contain at most 132 characters" > Fortran 2023: "A line shall contain at most ten thousand characters." > > (B) In "6.3.2.6 Free form statements": > Fortran 2018: "A statement shall not have more than 255 continuation > lines." > Fortran 2023: "A statement shall not have more than one million > characters." this is really a funny change: we're not really prepared to handle this. According to the standard one can have 999999 lines with only "&" and then an ";", but then only 100 lines with 10000 characters. There is a similar wording for fixed-form which you overlooked: 6.3.3.5 Fixed form statements Fortran 2023: "A statement shall not have more than one million characters= " Please adjust the fixed-form limits in your patch. If you think that we need testcases for fixed-form, add them, or forget them. I don't bother. > I have not added a testcase for exceeding the latter but otherwise there > are new > tests and I had to add a couple of -std=3Df2018 to existing tests. > > Comments, suggestions, approval? I have the following comments: - there are existing testcases continuation_5.f, continuation_6.f, thus I suggest to rename your new continuation_{5,6}.f90 to continuation_17.f90+ . - I don't understand your new testcase line_length_14.f90 . This is supposed to test -std=3Dgnu, but then -std=3Dgnu is not a standard but a moving target, which is why you had to adjust existing testcases. So what does it buy us beyond line_length_1{2,3}.f90 ? > Tobias > > PS: I find it funny that -std=3Dc23, -std=3Dc++23 and -std=3Df2023 will = get > added in the same GCC release. :-) > PPS: I did not bother adding .f23 as file extension; I believe that also > .f18 is unsupported. I never use extensions other than .f90 for portable code. With the above fixed, I am fine with your patch. Thanks, Harald > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe = 201, > 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: > Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; > Registergericht M=C3=BCnchen, HRB 106955 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 657F93858C60 for ; Thu, 16 Nov 2023 19:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 657F93858C60 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 657F93858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700163051; cv=none; b=M0MhCROPk4hF3zAjhT14kWmG2TjgSIImNBYN5ihz02aqpqwPN2hpepSbIMsWGmNwZg6aE7oqieXCpzglgVU8X6HbOJ21EwLy7WN2pM/dQq4Y3TTI58lt5fsZHgR8cuO5taBBf2eblVXtiKhBFqb3G/DPOO6G1AbDqSfl8gGU8LU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700163051; c=relaxed/simple; bh=+wOxrtGQvlj+0NTN5Rf66O4D/lgbPCbNyH3RM8/FqFc=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=qDfBoxkK4YqU5uwKz5yPQqpDtahRzzWIcZYraNHYnayhTyJRbes1vZXBJwvcO8gz2rT7KyRt8zL3Gqh/wlfd9WwQZ+/2CMLfV8oXob34Vjg8zHKb6oKfLaYtJbdswb5lXtAuwq/Z1/Vu7M8QALK9qH/FB+VstGreooBFpCV4FBQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1r3i4b-0001SB-S2 for gcc-patches@gcc.gnu.org; Thu, 16 Nov 2023 20:30:46 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: [Patch] Fortran: Accept -std=f2023 support, update line-length for Fortran 2023 Date: Thu, 16 Nov 2023 20:30:32 +0100 Message-ID: <750b022e-0291-4d35-9cd1-0957023cbb4a@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20231116193032.xoyUT0QNktBTzf5_2s_Mg-DUSQb1gDHAB6oigbrOCCU@z> Hi Tobias, On 11/16/23 14:01, Tobias Burnus wrote: > This adds -std=f2023, which is mostly a prep patch for future changes. > > However, Fortran 2023, https://j3-fortran.org/doc/year/23/23-007r1.pdf > changes two things which is taken > care in this patch: > > (A) In "6.3.2.1 Free form line length": > > Fortran 2018: "If a line consists entirely of characters of default kind > (7.4.4), it shall contain at most 132 characters" > Fortran 2023: "A line shall contain at most ten thousand characters." > > (B) In "6.3.2.6 Free form statements": > Fortran 2018: "A statement shall not have more than 255 continuation > lines." > Fortran 2023: "A statement shall not have more than one million > characters." this is really a funny change: we're not really prepared to handle this. According to the standard one can have 999999 lines with only "&" and then an ";", but then only 100 lines with 10000 characters. There is a similar wording for fixed-form which you overlooked: 6.3.3.5 Fixed form statements Fortran 2023: "A statement shall not have more than one million characters" Please adjust the fixed-form limits in your patch. If you think that we need testcases for fixed-form, add them, or forget them. I don't bother. > I have not added a testcase for exceeding the latter but otherwise there > are new > tests and I had to add a couple of -std=f2018 to existing tests. > > Comments, suggestions, approval? I have the following comments: - there are existing testcases continuation_5.f, continuation_6.f, thus I suggest to rename your new continuation_{5,6}.f90 to continuation_17.f90+ . - I don't understand your new testcase line_length_14.f90 . This is supposed to test -std=gnu, but then -std=gnu is not a standard but a moving target, which is why you had to adjust existing testcases. So what does it buy us beyond line_length_1{2,3}.f90 ? > Tobias > > PS: I find it funny that -std=c23, -std=c++23 and -std=f2023 will get > added in the same GCC release. :-) > PPS: I did not bother adding .f23 as file extension; I believe that also > .f18 is unsupported. I never use extensions other than .f90 for portable code. With the above fixed, I am fine with your patch. Thanks, Harald > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, > 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: > Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; > Registergericht München, HRB 106955