From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 013543858C54 for ; Fri, 21 Jul 2023 05:22:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 013543858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36L59BKZ019524; Fri, 21 Jul 2023 05:22:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : references : cc : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=UQBVhncmRrDtepsh8e+EunGWnjA2AtUbdNbje2YJDZk=; b=D4EShaE3BqCOzu1CF2Dbp5R1NOD+qu7AIMUuFsX+o95xjVLnKySTdM5yLpnQZCaR0WE6 AW3JJ5FSkTBVOWQVK3Yfcf4JXwemBJ6d/j3EIRvuIUEV+LJKOR26lXS/uuNok/acu/uV txigmHDMsLJomeiSX5It31ZrAC4VQuVzui17XPt53dP+Q9uN6QJm0u/2r3H9YG1svoRv GEiV0lcVlAzCSDC/ma33a9wYWHrDPrM/o6QF2z/2cqPqiKSB5YO9WAQfoDjmudotJYg0 UbSeSf+cJEiUltQEiCaIciVH7tBOu74eFqSHH/xzCTFEO8StEDdSAURPQBrKhFinMBJJ LA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rxqs4d20t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jul 2023 05:22:52 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36L5IbIY015413; Fri, 21 Jul 2023 05:22:52 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rxqs4d20c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jul 2023 05:22:52 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36L3KJsb017218; Fri, 21 Jul 2023 05:22:51 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3rv5ss4tgw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jul 2023 05:22:51 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36L5Mn5218153988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Jul 2023 05:22:49 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 78B9020043; Fri, 21 Jul 2023 05:22:49 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B978720040; Fri, 21 Jul 2023 05:22:47 +0000 (GMT) Received: from [9.177.28.8] (unknown [9.177.28.8]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 21 Jul 2023 05:22:47 +0000 (GMT) Message-ID: <7557306e-9b6c-78db-c705-90e36ec5a647@linux.ibm.com> Date: Fri, 21 Jul 2023 13:22:45 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] testsuite: Add a test case for PR110729 Content-Language: en-US To: richard.sandiford@arm.com References: Cc: Fangrui Song , Richard Biener , GCC Patches From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UQcund8ZqK-VBrdirqlPf1nISLSAcCMa X-Proofpoint-ORIG-GUID: STnachwu3fmrv-xOjvazNmtVh46tQ-9Q Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-21_02,2023-07-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 phishscore=0 mlxlogscore=970 spamscore=0 mlxscore=0 clxscore=1015 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307210046 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2023/7/20 20:34, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi, >> >> As PR110729 reported, there was one issue for .section >> __patchable_function_entries with -ffunction-sections, that >> is we put the same symbol as link_to section symbol for all >> functions wrongly. The commit r13-4294 for PR99889 has >> fixed this with the corresponding label LPFE* which sits in >> the function_section. >> >> As Fangrui suggested[1], this patch is to add a bit more test >> coverage. I didn't find a good way to check all linked_to >> symbols are different, so I checked for LPFE[012] here. >> >> [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624866.html >> >> Tested well on x86_64-redhat-linux, powerpc64-linux-gnu >> P7/P8/P9 and powerpc64le-linux-gnu P9/P10. >> >> Is it ok for trunk? >> >> BR, >> Kewen >> ----- >> PR testsuite/110729 >> >> gcc/testsuite/ChangeLog: >> >> * gcc.dg/pr110729.c: New test. > > OK, thanks. Thanks Richard! Pushed as r14-2693. BR, Kewen