public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Stump <mikestump@comcast.net>
To: Dimitris Papavasiliou <dpapavas@gmail.com>
Cc: "gcc-patches@gcc.gnu.org Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope
Date: Fri, 25 Apr 2014 03:20:00 -0000	[thread overview]
Message-ID: <757BB622-2CA8-4C9A-BCA9-AAD1FDF8F14F@comcast.net> (raw)
In-Reply-To: <5359999C.7090607@gmail.com>

On Apr 24, 2014, at 4:09 PM, Dimitris Papavasiliou <dpapavas@gmail.com> wrote:
> On 04/24/2014 07:00 PM, Mike Stump wrote:
>> On Feb 6, 2014, at 1:25 AM, Dimitris Papavasiliou <dpapavas@gmail.com> wrote:
>>> This is a patch regarding a couple of Objective-C related dialect options and warning switches.
>> 
>> Ok.
>> 
>> Committed revision 209753.
>> 
>> If you could, please add documentation and a test case.
> 
> Thanks for taking the time to look at this, although to be honest I didn't expect a straight merge into the trunk.

Don’t submit changes you don’t want!  :-)

> I'll add documentation and test cases as soon as I figure out how.

Just copy testsuite/objc.dg/private-2.m into shadow-1.m and then `fix’ it to test what you want.  If you need one with and one without a flag, copy it twice and use something like:

// { dg-options "-Wshadow" }        

on it.  Type make RUNTESTFLAGS=dg.exp=shadow-1.m check-objc to test it.

For the doc, just find a simple option in the part of the manual you want to put it in, and copy it.  We document the non-default, (Wno-shadow-ivar for example) options.

  reply	other threads:[~2014-04-25  1:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06  9:22 Dimitris Papavasiliou
2014-02-13 14:19 ` [PING][PATCH] " Dimitris Papavasiliou
2014-02-20 10:08   ` [PING^2][PATCH] " Dimitris Papavasiliou
2014-02-27  9:41     ` [PING^3][PATCH] " Dimitris Papavasiliou
2014-03-06 17:41       ` [PING^4][PATCH] " Dimitris Papavasiliou
2014-03-13  9:52         ` Dimitris Papavasiliou
2014-03-23  1:32           ` [PING^6][PATCH] " Dimitris Papavasiliou
2014-03-28 10:11             ` [PING^7][PATCH] " Dimitris Papavasiliou
2014-04-03 15:29               ` [PING^8][PATCH] " Dimitris Papavasiliou
2014-04-24 10:39                 ` Dimitris Papavasiliou
2014-04-24 20:29                   ` Jakub Jelinek
2014-04-25  0:17                     ` Dimitris Papavasiliou
2014-04-25  1:07                       ` Mike Stump
2014-04-25 11:40                         ` Dimitris Papavasiliou
2014-04-24 16:03 ` [PATCH] " Mike Stump
2014-04-24 23:16   ` Dimitris Papavasiliou
2014-04-25  3:20     ` Mike Stump [this message]
2014-04-25 16:50       ` Dimitris Papavasiliou
2014-04-25 16:53         ` Mike Stump
2014-04-28 10:37           ` Dimitris Papavasiliou
2014-05-05  7:31             ` Dimitris Papavasiliou
2014-05-12  7:49               ` Dimitris Papavasiliou
2014-05-12 16:25             ` Mike Stump
2014-05-12 18:57               ` Dimitris Papavasiliou
2014-05-12 19:14                 ` Mike Stump
2014-05-12 20:53             ` Mike Stump
2014-05-13 14:17               ` Dimitris Papavasiliou
  -- strict thread matches above, loose matches on Subject: below --
2013-06-09 21:44 Dimitris Papavasiliou
2013-06-24 12:09 ` Dimitris Papavasiliou
2013-07-02  8:05   ` Dimitris Papavasiliou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=757BB622-2CA8-4C9A-BCA9-AAD1FDF8F14F@comcast.net \
    --to=mikestump@comcast.net \
    --cc=dpapavas@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).