From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 45DB9385E457 for ; Sat, 9 Mar 2024 11:25:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45DB9385E457 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45DB9385E457 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709983559; cv=none; b=v73C7mmSryHxQnwBD5UC6WZJvz6WzlzJjfFDo+B5hC38cdRB0yQuN8pDJJHYXrqJvYx+k6VO/VeRGOYnLOaSjvq5dkKSOH85HqvQlu7oVKtd4YMMQtPR169CRqDBDlt+g2tCEzXuR431WlY57CH2mroUdZnWy7u35P6xrUUwnng= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709983559; c=relaxed/simple; bh=8yM4ZbAYpHgqgftgUJ70i40nKVEHGriKg3zNE8kvXEc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: Mime-Version:Subject:Date:Message-Id:To; b=Z8Q54Dy3ALv6OWAimtj7ZmjvrY7wDldlS2gNK5T8e44KbbIbprQcnryWqF+ipfi9OVyjWgflE7wrVU8XtECV37WihOBP01N6EdpIp7S3HV0UmNDot1zypeSWuSOj3DxXWmz0nCi8zet9M7HGAJBi7F6DfV0Y400jD5mSvJTO0Ws= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 24ABF1FE6E; Sat, 9 Mar 2024 11:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709983557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fEOiTD3H06MqO8DtmiSDZjw8QtiUPgtN9FROwYCz6Fw=; b=UsejvsU4C7lj1tGuIywEGxW0UTWgKw258nYN74TDtDcR7+KugOTwuxeRYekm9M07A4pWNf Nv9PAbzyzQvS0B+Ad/ac4BWFRHfUDEhJyhUlmbWHXyZ6lYewBnMNrGq9bB1TCuSZDWn2eK YOO+BcwK93Peuhhm/Dgnlb8S1wdhjvQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709983557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fEOiTD3H06MqO8DtmiSDZjw8QtiUPgtN9FROwYCz6Fw=; b=aoD4jD8w4zRPn2VDZ0TDuLLpnqGQ/FMobJrMPbMDINi6UYFQ3O6C1jteTXF+nZbUOmsow1 oTOTaK4lB2b6QXBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709983557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fEOiTD3H06MqO8DtmiSDZjw8QtiUPgtN9FROwYCz6Fw=; b=UsejvsU4C7lj1tGuIywEGxW0UTWgKw258nYN74TDtDcR7+KugOTwuxeRYekm9M07A4pWNf Nv9PAbzyzQvS0B+Ad/ac4BWFRHfUDEhJyhUlmbWHXyZ6lYewBnMNrGq9bB1TCuSZDWn2eK YOO+BcwK93Peuhhm/Dgnlb8S1wdhjvQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709983557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fEOiTD3H06MqO8DtmiSDZjw8QtiUPgtN9FROwYCz6Fw=; b=aoD4jD8w4zRPn2VDZ0TDuLLpnqGQ/FMobJrMPbMDINi6UYFQ3O6C1jteTXF+nZbUOmsow1 oTOTaK4lB2b6QXBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 176E5133D1; Sat, 9 Mar 2024 11:25:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uXu3BUVH7GVOGAAAD6G6ig (envelope-from ); Sat, 09 Mar 2024 11:25:57 +0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] bitint: Avoid rewriting large/huge _BitInt vars into SSA after bitint lowering [PR114278] Date: Sat, 9 Mar 2024 12:25:42 +0100 Message-Id: <75DCD6B5-A571-46F4-B735-F5C9DE2F0949@suse.de> References: Cc: gcc-patches@gcc.gnu.org In-Reply-To: To: Jakub Jelinek X-Mailer: iPhone Mail (21E219) X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UsejvsU4; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aoD4jD8w X-Spamd-Result: default: False [-1.84 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; URIBL_BLOCKED(0.00)[suse.de:dkim,tree-ssa.cc:url]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; BAYES_HAM(-0.03)[55.63%]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Spam-Score: -1.84 X-Rspamd-Queue-Id: 24ABF1FE6E X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 09.03.2024 um 09:28 schrieb Jakub Jelinek : >=20 > =EF=BB=BFHi! >=20 > The following testcase ICEs, because update-address-taken subpass of > fre5 rewrites > _BitInt(128) b; > vector(16) unsigned char _3; >=20 > [local count: 1073741824]: > _3 =3D MEM [(char * {ref-all})p_2(D)]; > MEM [(char * {ref-all})&b] =3D _3; > b =3D{v} {CLOBBER(eos)}; > to > _BitInt(128) b; > vector(16) unsigned char _3; >=20 > [local count: 1073741824]: > _3 =3D MEM [(char * {ref-all})p_2(D)]; > b_5 =3D VIEW_CONVERT_EXPR<_BitInt(128)>(_3); > but we can't have large/huge _BitInt vars in SSA form after the bitint > lowering except for function arguments loaded from memory, as expansion > isn't able to deal with those, it relies on bitint lowering to lower > those operations. > The following patch fixes that by not clearing TREE_ADDRESSABLE for > large/huge _BitInt vars after bitint lowering, such that we don't > rewrite them into SSA form. >=20 > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? >=20 Ideally we=E2=80=99d clear TREE_ADDRESSABLE but set DECL_NOT_GIMPLE_REG, I t= hink the analysis where we check the base would be a more appropriate place t= o enforce that. Richard=20 > 2024-03-09 Jakub Jelinek >=20 > PR tree-optimization/114278 > * tree-ssa.cc (maybe_optimize_var): Punt on large/huge _BitInt > vars after bitint lowering. >=20 > * gcc.dg/bitint-99.c: New test. >=20 > --- gcc/tree-ssa.cc.jj 2024-01-03 11:51:39.902615009 +0100 > +++ gcc/tree-ssa.cc 2024-03-08 14:24:11.844821915 +0100 > @@ -1753,7 +1753,11 @@ maybe_optimize_var (tree var, bitmap add > /* Global Variables, result decls cannot be changed. */ > if (is_global_var (var) > || TREE_CODE (var) =3D=3D RESULT_DECL > - || bitmap_bit_p (addresses_taken, DECL_UID (var))) > + || bitmap_bit_p (addresses_taken, DECL_UID (var)) > + || (TREE_CODE (TREE_TYPE (var)) =3D=3D BITINT_TYPE > + /* Don't change large/huge _BitInt vars after _BitInt lowering. */= > + && (cfun->curr_properties & PROP_gimple_lbitint) !=3D 0 > + && TYPE_PRECISION (TREE_TYPE (var)) > MAX_FIXED_MODE_SIZE)) > return; >=20 > bool maybe_reg =3D false; > --- gcc/testsuite/gcc.dg/bitint-99.c.jj 2024-03-08 14:26:17.658069942 += 0100 > +++ gcc/testsuite/gcc.dg/bitint-99.c 2024-03-08 14:25:36.292645965 +010= 0 > @@ -0,0 +1,26 @@ > +/* PR tree-optimization/114278 */ > +/* { dg-do compile { target bitint } } */ > +/* { dg-options "-O2 -fno-tree-dce -fno-tree-dse -fno-tree-ccp" } */ > +/* { dg-additional-options "-mavx2" { target i?86-*-* x86_64-*-* } } */ > + > +void > +foo (void *p) > +{ > + _BitInt(64) b =3D *(_BitInt(64) *) __builtin_memmove (&b, p, sizeof (_B= itInt(64))); > +} > + > +#if __BITINT_MAXWIDTH__ >=3D 128 > +void > +bar (void *p) > +{ > + _BitInt(128) b =3D *(_BitInt(128) *) __builtin_memmove (&b, p, sizeof (= _BitInt(128))); > +} > +#endif > + > +#if __BITINT_MAXWIDTH__ >=3D 256 > +void > +baz (void *p) > +{ > + _BitInt(256) b =3D *(_BitInt(256) *) __builtin_memmove (&b, p, sizeof (= _BitInt(256))); > +} > +#endif >=20 > Jakub >=20