From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1A343385276D for ; Tue, 30 Aug 2022 13:32:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A343385276D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661866325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8FirTWbHJUx1iWU2XiT6m1FUmgT5UUUikTjAUrjTtN0=; b=XgExj+O+rVVrtnqMzEIdIcWye79cDqQ+t8cyVvhzaAKxQI4OkTOKTvzGBmaAAMU2Ph/Ppi XplLktEn7XqezJ8XatWmKI/keiE0eJhNXtpcjNNuBYrO0ltrlC8o7MDVx6itNI3EUcW7xd SrdIFfiSLedjW8xyhKVvdhO3MQelUbY= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-563-FBWD1NZaNpaipi-TDfXntw-1; Tue, 30 Aug 2022 09:32:04 -0400 X-MC-Unique: FBWD1NZaNpaipi-TDfXntw-1 Received: by mail-qt1-f199.google.com with SMTP id s2-20020ac85cc2000000b00342f8ad1f40so8714345qta.12 for ; Tue, 30 Aug 2022 06:32:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=8FirTWbHJUx1iWU2XiT6m1FUmgT5UUUikTjAUrjTtN0=; b=QDiF3QXgDTLB1YU0wOgad5M4Yx1rQ3CEsXXSSlRNXn7PYhGGJtZkwCf+UUQRAbnDEU OVTIaO+tQWXj7MRMREtS0lgx7ibAsPJe3xuSylwet2TQ8Lh3rVhNQDen3KoPP5AOuleR ebHxOqARw5ILSD7Wacgcxz2ptBL5/x6nYFBK8hD64DPCd4aNN8P/EKVSvd3F1kTpicfK Q/N7eoIRmDDMjzL/l8TXnRmh+4Wi2KWPZAewAAr2jdLnUHSL3qdCkacM6aubUq5leYjf GPApwsNB0a+Sl9KnTNTdyisjR8e7N4D9OoFvdMOiqM/KzxVNvA73XZqVa+TzRY3sTzTQ Rsjg== X-Gm-Message-State: ACgBeo2ctOwiFWXc+FBipixzSD/W5qMc35xvdjBo75OO2LwW6CvnMCgW CvBXNwWtDZ6/jrXZPjT3xzMBfhMkAipkQG/0aWZiXAW1LnghOP5I8OtBNyYRylyDKmyuJ4p8B+4 vx+TMOpwnw7kvqMDjNA== X-Received: by 2002:ad4:5cea:0:b0:497:c55:edb3 with SMTP id iv10-20020ad45cea000000b004970c55edb3mr14876182qvb.99.1661866323771; Tue, 30 Aug 2022 06:32:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR5ldttcCwj5M4p5vC0cHX3n/4m+vq2XFWeL8wWQcVr6v7M4/mWAhlE/TSOtmqp/ERHMYqDAXg== X-Received: by 2002:ad4:5cea:0:b0:497:c55:edb3 with SMTP id iv10-20020ad45cea000000b004970c55edb3mr14876159qvb.99.1661866323449; Tue, 30 Aug 2022 06:32:03 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id q21-20020a05620a0d9500b006b555509398sm8143589qkl.136.2022.08.30.06.32.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 06:32:02 -0700 (PDT) Message-ID: <75dcc9dd-5b82-c999-7d9f-294737432f2a@redhat.com> Date: Tue, 30 Aug 2022 09:32:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [Patch] add more C++ name hints. v2 To: Ulrich Drepper , gcc-patches@gcc.gnu.org References: From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/22/22 15:09, Ulrich Drepper via Gcc-patches wrote: > This is the second version of the proposed patch to add more identifiers to > the known list to give hints about #include and version numbers. > > Marek looked through the first version and found it acceptable but remarked > that the list is getting long and the sequential search performed by the > current code might not be adequate. Especially because I offered to add > even more known names to the list. > > This second version replaces the current lookup implementation with a > gperf-generated hash function. Since gperf is already a dependency for > maintainers the use of the tool itself shouldn't be a problem. > > I followed the existing practice for the cfns.gperf file and its use so, if > the handling of that file works, so should the handling of the new file, > std-name-hint.gperf. > > Please let me know if this is acceptable. I built a compiler with this > code and tested the hinting. OK, thanks. > contrib/ChangeLog > * gcc_update (files_and_dependencies): Add gcc/cp/std-name-hint.h > depend on gcc/cp/std-name-hint.gperf. > > gcc/cp/ChangeLog > * Make-lang.in: Add rule to build std-name-hint.h. > * name-lookup.cc (struct std_name_hint): Remove definition. > Instead... > Include "std-name-hint.h". > (get_std_name_hint): Remove hints array and lookup code. Instead > call > std_name_hint_lookup::find. > * std-name-hint.gperf: New file. > * std-name-hint.h: New file.