From: "Martin Liška" <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Cc: Andrew MacLeod <amacleod@redhat.com>, Aldy Hernandez <aldyh@redhat.com>
Subject: [PATCH (pushed)] Mitigate clang warnings:
Date: Mon, 7 Nov 2022 09:51:08 +0100 [thread overview]
Message-ID: <75e3842a-f9d2-b90a-5e19-30afcf0f1fa6@suse.cz> (raw)
gcc/range-op.cc:1752:16: warning: 'wi_fold' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
gcc/range-op.cc:1757:16: warning: 'wi_op_overflows' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
gcc/range-op.cc:1759:16: warning: 'op1_range' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
gcc/range-op.cc:1763:16: warning: 'op2_range' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
gcc/range-op.cc:1928:16: warning: 'wi_fold' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
gcc/range-op.cc:1933:16: warning: 'wi_op_overflows' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
gcc/ChangeLog:
* range-op.cc: Add final override keywords.
---
gcc/range-op.cc | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/gcc/range-op.cc b/gcc/range-op.cc
index 25c004d8287..5e94c3d2282 100644
--- a/gcc/range-op.cc
+++ b/gcc/range-op.cc
@@ -1753,17 +1753,18 @@ public:
const wide_int &lh_lb,
const wide_int &lh_ub,
const wide_int &rh_lb,
- const wide_int &rh_ub) const;
+ const wide_int &rh_ub) const final override;
virtual bool wi_op_overflows (wide_int &res, tree type,
- const wide_int &w0, const wide_int &w1) const;
+ const wide_int &w0, const wide_int &w1)
+ const final override;
virtual bool op1_range (irange &r, tree type,
const irange &lhs,
const irange &op2,
- relation_trio) const;
+ relation_trio) const final override;
virtual bool op2_range (irange &r, tree type,
const irange &lhs,
const irange &op1,
- relation_trio) const;
+ relation_trio) const final override;
} op_mult;
bool
@@ -1929,9 +1930,10 @@ public:
const wide_int &lh_lb,
const wide_int &lh_ub,
const wide_int &rh_lb,
- const wide_int &rh_ub) const;
+ const wide_int &rh_ub) const final override;
virtual bool wi_op_overflows (wide_int &res, tree type,
- const wide_int &, const wide_int &) const;
+ const wide_int &, const wide_int &)
+ const final override;
virtual bool fold_range (irange &r, tree type,
const irange &lh, const irange &rh,
relation_trio trio) const final override;
--
2.38.0
reply other threads:[~2022-11-07 8:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e3842a-f9d2-b90a-5e19-30afcf0f1fa6@suse.cz \
--to=mliska@suse.cz \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).