From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id D29283858D28 for ; Mon, 7 Feb 2022 15:48:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D29283858D28 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 217Egc45021350; Mon, 7 Feb 2022 15:48:29 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e22st7x2d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 15:48:29 +0000 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 217FlVXt031809; Mon, 7 Feb 2022 15:48:29 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e22st7x1t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 15:48:29 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 217FhWeb004799; Mon, 7 Feb 2022 15:48:28 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma04dal.us.ibm.com with ESMTP id 3e1gvag0uf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 15:48:28 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 217FmQKe34013518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Feb 2022 15:48:26 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CEA9124064; Mon, 7 Feb 2022 15:48:26 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 87D2F12406C; Mon, 7 Feb 2022 15:48:25 +0000 (GMT) Received: from [9.211.95.26] (unknown [9.211.95.26]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 7 Feb 2022 15:48:25 +0000 (GMT) Message-ID: <76110a86-82e1-84af-0168-bf0c766487ac@linux.ibm.com> Date: Mon, 7 Feb 2022 09:48:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Reply-To: wschmidt@linux.ibm.com Subject: Re: [PATCH 7/8] rs6000: vec_neg built-ins wrongly require POWER8 To: gcc-patches@gcc.gnu.org Cc: dje.gcc@gmail.com, segher@kernel.crashing.org References: <16a48501c2e15d0a781ead8b44ca912dae90d717.1643390744.git.wschmidt@linux.ibm.com> From: Bill Schmidt In-Reply-To: <16a48501c2e15d0a781ead8b44ca912dae90d717.1643390744.git.wschmidt@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: g_4XxjahKsbcODkk0007zMQbDsHIsd0L X-Proofpoint-ORIG-GUID: kmcyWpiLoYYOpOttKfD9ZB6Yjc-6sWUq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 phishscore=0 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202070097 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2022 15:48:33 -0000 Hi Segher, Thanks for all the reviews for this series!  I'd like to gently ping the last two patches. BR, Bill On 1/28/22 11:50 AM, Bill Schmidt via Gcc-patches wrote: > As the subject states. Fixing this is accomplished by moving the built-ins > to the correct stanzas, [altivec] and [vsx]. > > Bootstrapped and tested on powerpc64le-linux-gnu with no regressions. > Is this okay for trunk? > > Thanks, > Bill > > > 2022-01-27 Bill Schmidt > > gcc/ > * config/rs6000/rs6000-builtin.def (NEG_V16QI): Move to [altivec] > stanza. > (NEG_V4SF): Likewise. > (NEG_V4SI): Likewise. > (NEG_V8HI): Likewise. > (NEG_V2DF): Move to [vsx] stanza. > (NEG_V2DI): Likewise. > --- > gcc/config/rs6000/rs6000-builtins.def | 36 +++++++++++++-------------- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def > index 2bb997a5279..c8f0cf332eb 100644 > --- a/gcc/config/rs6000/rs6000-builtins.def > +++ b/gcc/config/rs6000/rs6000-builtins.def > @@ -410,6 +410,18 @@ > const vss __builtin_altivec_nabs_v8hi (vss); > NABS_V8HI nabsv8hi2 {} > > + const vsc __builtin_altivec_neg_v16qi (vsc); > + NEG_V16QI negv16qi2 {} > + > + const vf __builtin_altivec_neg_v4sf (vf); > + NEG_V4SF negv4sf2 {} > + > + const vsi __builtin_altivec_neg_v4si (vsi); > + NEG_V4SI negv4si2 {} > + > + const vss __builtin_altivec_neg_v8hi (vss); > + NEG_V8HI negv8hi2 {} > + > void __builtin_altivec_stvebx (vsc, signed long, void *); > STVEBX altivec_stvebx {stvec} > > @@ -1175,6 +1187,12 @@ > const vsll __builtin_altivec_nabs_v2di (vsll); > NABS_V2DI nabsv2di2 {} > > + const vd __builtin_altivec_neg_v2df (vd); > + NEG_V2DF negv2df2 {} > + > + const vsll __builtin_altivec_neg_v2di (vsll); > + NEG_V2DI negv2di2 {} > + > void __builtin_altivec_stvx_v2df (vd, signed long, void *); > STVX_V2DF altivec_stvx_v2df {stvec} > > @@ -2118,24 +2136,6 @@ > const vus __builtin_altivec_nand_v8hi_uns (vus, vus); > NAND_V8HI_UNS nandv8hi3 {} > > - const vsc __builtin_altivec_neg_v16qi (vsc); > - NEG_V16QI negv16qi2 {} > - > - const vd __builtin_altivec_neg_v2df (vd); > - NEG_V2DF negv2df2 {} > - > - const vsll __builtin_altivec_neg_v2di (vsll); > - NEG_V2DI negv2di2 {} > - > - const vf __builtin_altivec_neg_v4sf (vf); > - NEG_V4SF negv4sf2 {} > - > - const vsi __builtin_altivec_neg_v4si (vsi); > - NEG_V4SI negv4si2 {} > - > - const vss __builtin_altivec_neg_v8hi (vss); > - NEG_V8HI negv8hi2 {} > - > const vsc __builtin_altivec_orc_v16qi (vsc, vsc); > ORC_V16QI orcv16qi3 {} >