From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 191C23858D35 for ; Fri, 9 Jun 2023 21:44:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 191C23858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6513e7e5d44so1924676b3a.0 for ; Fri, 09 Jun 2023 14:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686347070; x=1688939070; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YSYWEqhJbZr5KXDxddC15/4PuxfTQ5zfpfTI7MlO5JM=; b=fGg2A9sZchjTEba+tlE27/GgFM6HUBrpEKEDZvxd91/j8S0VZy9kDvYrSmSE9t41Tt GwbOYBX5Xl7YyS2mYklzVY98fBd/F629501H5eQG2I3gLEpkgDyQZhx5tlRExSm+V6II YQTuUKdMG+2XdiM3ZLaXnvsK93vcTcdRh6ofUV/yCVMUeCql0PHJsIkL3EqWDzoOlxax HhCD1Es0gBtRvwBzMj2TCEvEaMJJ/Bk7vpFT2s5wveaSZpG7ThoBxxBplCARIjPw9xzG Nfd73rmhw1gbeY1BKUlsndFDaOaZivxGKifA8y2uzk5pYB+74l0KNf1g+OjUIq+WU1Lv J0Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686347070; x=1688939070; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YSYWEqhJbZr5KXDxddC15/4PuxfTQ5zfpfTI7MlO5JM=; b=bouqA37TshsGRuwTJmurwtYYWHlIJdB3yBKx+kJD73fkA7QaYGQV3rEgYCCCC5h7t1 h1wRgGp8CdlHjse9ifEj/SIK9IcZ+JU2h9FfEDAU+sGSvXVNOwHZmsEib0y2ZEjs5vh+ 92PZmjXc7hOIB1/3ih+hLo+RKm8V3rkVQvc4G/HcoXrAuMIH1iM+8vt/3VPvUkPHIwNf ekgYxB4POOGoAzLCI0nKgeM0YTKAniXfPpyZ1simrId5Tw7Xt2sjHkKxWFbdDisi1hR6 s5NWWCMLhZtSEYd/eA1ybcAYrkoJWpTUe84I48WfW99alO7Jyqg+NW/2FDdKT7CHEh3j e+VQ== X-Gm-Message-State: AC+VfDwifZpBoh9RzejOelhkNIkaxV1pSppKs83m7xuQXJyfllNCr24y 0IOEZLJNEpL6zENN4A4JL5M= X-Google-Smtp-Source: ACHHUZ66vqtG7QSjTYVhDAYpQPdox4rghyNvxWTmODrtWKckWgMd9xB3+3ihqTvKUv1uufEoMBjmCg== X-Received: by 2002:a05:6a00:228e:b0:64d:41d5:d160 with SMTP id f14-20020a056a00228e00b0064d41d5d160mr2938815pfe.20.1686347069713; Fri, 09 Jun 2023 14:44:29 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id e15-20020aa7824f000000b0066355064acbsm3032554pfn.104.2023.06.09.14.44.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 14:44:29 -0700 (PDT) Message-ID: <76443f30-50c3-d144-0379-2fc81d1ee342@gmail.com> Date: Fri, 9 Jun 2023 15:44:28 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] MATCH: Fix zero_one_valued_p not to match signed 1 bit integers Content-Language: en-US To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20230609172753.3164342-1-apinski@marvell.com> From: Jeff Law In-Reply-To: <20230609172753.3164342-1-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/9/23 11:27, Andrew Pinski via Gcc-patches wrote: > So for the attached testcase, we assumed that zero_one_valued_p would > be the value [0,1] but currently zero_one_valued_p matches also > signed 1 bit integers. > This changes that not to match that and fixes the 2 new testcases at > all optimization levels. > > OK for GCC 13? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > PR tree-optimization/110165 > PR tree-optimization/110166 > > gcc/ChangeLog: > > * match.pd (zero_one_valued_p): Don't accept > signed 1-bit integers. > > gcc/testsuite/ChangeLog: > > * gcc.c-torture/execute/pr110165-1.c: New test. > * gcc.c-torture/execute/pr110166-1.c: New test. OK. Jeff