From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id BDB3B3851C0F for ; Mon, 28 Jun 2021 08:15:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDB3B3851C0F Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15S82Yov158763; Mon, 28 Jun 2021 04:15:25 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39faeq8hqd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Jun 2021 04:15:25 -0400 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15S82ohE159776; Mon, 28 Jun 2021 04:15:24 -0400 Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 39faeq8hpc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Jun 2021 04:15:24 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15S8BwCv017263; Mon, 28 Jun 2021 08:15:22 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma01fra.de.ibm.com with ESMTP id 39duv88bdb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Jun 2021 08:15:22 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15S8FJLH21692802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Jun 2021 08:15:19 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 16B1DA4137; Mon, 28 Jun 2021 08:15:19 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 01B47A4155; Mon, 28 Jun 2021 08:15:17 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.147.143]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 28 Jun 2021 08:15:16 +0000 (GMT) Subject: Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support To: Segher Boessenkool Cc: GCC Patches , David Edelsohn , Bill Schmidt , will schmidt , cel@us.ibm.com, Michael Meissner References: <32c02216-9f50-8b1b-9d5d-43a769c3c149@linux.ibm.com> <20210622185602.GD5077@gate.crashing.org> <2fc5b902-9c0b-89b2-c526-ce6a6f638757@linux.ibm.com> <20210623165850.GG5077@gate.crashing.org> <675c530f-13dc-df82-cfd1-dd4b07e4a546@linux.ibm.com> <20210624193653.GK5077@gate.crashing.org> From: "Kewen.Lin" Message-ID: <766cae11-b4f1-b705-587d-e2d35d91cde4@linux.ibm.com> Date: Mon, 28 Jun 2021 16:15:15 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210624193653.GK5077@gate.crashing.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: nebNYGmSBsUnInYdaqVJVmMOIEk_5ExS X-Proofpoint-ORIG-GUID: RtrfGLYTOs-UC8md45fr7C9lubEVIhvX X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-06-28_05:2021-06-25, 2021-06-28 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106280055 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 08:15:28 -0000 on 2021/6/25 上午3:36, Segher Boessenkool wrote: > On Thu, Jun 24, 2021 at 05:32:20PM +0800, Kewen.Lin wrote: >> on 2021/6/24 上午12:58, Segher Boessenkool wrote: >>> On Wed, Jun 23, 2021 at 12:17:07PM +0800, Kewen.Lin wrote: >>>>>> +#ifdef FLOAT128_HW_INSNS_ISA3_1 >>>>>> TFtype __floattikf (TItype_ppc) >>>>>> __attribute__ ((__ifunc__ ("__floattikf_resolve"))); >>>>> >>>>> I wonder if we now need TItype_ppc at all anymore, btw? >>>> >>>> Sorry that I don't quite follow this question. >>> >>> I thought it may do the same as just TItype now, but the ifunc stuff >>> probably makes it different still :-) >> >> Ah, thanks for the clarification! If I read it right, TItype is defined >> with __attribute__ ((mode (TI))) while TItype_ppc is defined with >> __attribute__ ((__mode__ (__TI__))), the later writing looks special. > > I managed to read things wrong, I thought there was some ifunc stuff in > the definition of TItype_ppc. Of course there is not, it is just > setting the mode. > > mode(__TI__) is just the more portable way of writing mode(TI), the > latter will not work if something #define's TI (you cannot do that with > __TI__, you are not allowed to by the C standard, in application code). > Yeah, thanks for the note. It looks better to update the generic macro with this ppc style "__" writting and remove ppc one. :-) One related bug PR101235 was just opened, I noticed the culprit commit was backported to GCC11, is it OK to backport this fix to GCC 11 if everything goes well in one more week? BR, Kewen