public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Anatoly Sokolov <aesok@post.ru>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Richard Henderson <rth@redhat.com>,
	gcc-patches@gcc.gnu.org, 	<ebotcazou@libertysurf.fr>
Subject: Re[2]: [SPARC] Hookize  PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P
Date: Wed, 04 May 2011 17:44:00 -0000	[thread overview]
Message-ID: <768470406.20110504213221@post.ru> (raw)
In-Reply-To: <yddei4fehrr.fsf@manam.CeBiTec.Uni-Bielefeld.DE>

Hi.

> Richard Henderson <rth@redhat.com> writes:

>> On 04/27/2011 11:13 AM, Anatoly Sokolov wrote:
>>>         * config/sparc/sparc.h (PRINT_OPERAND, PRINT_OPERAND_ADDRESS,
>>>         PRINT_OPERAND_PUNCT_VALID_P): Remove.
>>>         * config/sparc/sparc-protos.h (print_operand): Remove declaration.
>>>         * config/sparc/sparc.c (TARGET_PRINT_OPERAND_PUNCT_VALID_P,
>>>         TARGET_PRINT_OPERAND, TARGET_PRINT_OPERAND_ADDRESS): Define.
>>>         (print_operand): Rename to...
>>>         (sparc_print_operand): ...this. Make static. Adjust
>>>         sparc_print_operand function call.
>>>         (sparc_print_operand_punct_valid_p, sparc_print_operand_address): New
>>>         functions.

> This patch broke Solaris 2/SPARC bootstrap which still uses
> print_operand in sparc/sol2.h (ASM_OUTPUT_CALL).  A bootstrap with the
> obvious fix is currently running.

> What is so hard about running grep when removing/renaming symbols???

Sorry for my mistake. I think that the patch is obvious, but I have no 
capability to test it. 


        * config/sparc/sol.h (ASM_OUTPUT_CALL): Use print_operand target
        hook.


Index: gcc/config/sparc/sol2.h
===================================================================
--- gcc/config/sparc/sol2.h     (revision 173212)
+++ gcc/config/sparc/sol2.h     (working copy)
@@ -172,7 +172,7 @@
   do                                                           \
     {                                                          \
       fprintf (FILE, "\tcall\t");                              \
-      print_operand (FILE, XEXP (DECL_RTL (FN), 0), 0);        \
+      targetm.asm_out.print_operand (FILE, XEXP (DECL_RTL (FN), 0), 0);        \
       fprintf (FILE, "\n\tnop\n");                             \
     }                                                          \
   while (0)

Anatoly.

  parent reply	other threads:[~2011-05-04 17:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27 18:43 Anatoly Sokolov
2011-04-28 16:18 ` Richard Henderson
2011-05-03 19:07   ` Rainer Orth
2011-05-03 19:18     ` Joseph S. Myers
2011-05-04 11:54       ` Rainer Orth
2011-05-04 12:02         ` Joseph S. Myers
2011-05-26 11:49           ` Completing toplevel libgcc move (Was: Re: [SPARC] Hookize PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P) Rainer Orth
2011-05-26 13:24             ` Joseph S. Myers
2011-05-26 13:31               ` Completing toplevel libgcc move Rainer Orth
2011-05-04 17:44     ` Anatoly Sokolov [this message]
2011-05-04 17:44       ` [SPARC] Hookize PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P Rainer Orth
2011-05-05  9:15         ` Rainer Orth
2011-05-13  7:02           ` Re[2]: " Anatoly Sokolov
2011-05-19 13:00             ` Rainer Orth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=768470406.20110504213221@post.ru \
    --to=aesok@post.ru \
    --cc=ebotcazou@libertysurf.fr \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).