From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id A0DB63858C52 for ; Fri, 26 Aug 2022 02:51:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0DB63858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27Q2UFoW007910; Fri, 26 Aug 2022 02:51:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=sG8lnRHsTiBSeFQX2jiDXAA6WAt5BNtcUuGReamPG8Y=; b=hlUBccSWK1gcMGJ61jPp+t38iwZ4NehKBYHkAoDMG+zMbNQ15/OzSINZy/pJxm1J8jUV 8r1fhl1atHhuFA/FuQFD/T8D7xOEPplVDOo8yLZLRJ1y+aUgnJAWJJVk7ejKT07Jm3hL 4m+HT8ZTVy2J7VH/bvXH45yES4fy69Xgfmg9e7tePQs7FMTvrLlWUZCnLJSerl5YcYct RfdP6+tLt+oELGOboVfwAtZmIcjKaO3jr1hcXaa/eQQ3fMptnEwFTxf2grrsbEPS3gwl NBEvQyfr/l7cu80TsouLiN1AyQXwQ4qlqah6vvtbBy9RMpyRGQRHxFsrj0aNgA4PkJEe 9Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j6newgda5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Aug 2022 02:51:39 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27Q2gIXQ004844; Fri, 26 Aug 2022 02:51:39 GMT Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j6newgd9j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Aug 2022 02:51:39 +0000 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27Q2aYEO017647; Fri, 26 Aug 2022 02:51:37 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma06fra.de.ibm.com with ESMTP id 3j2pvjd7yj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Aug 2022 02:51:37 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27Q2pXIp38601174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Aug 2022 02:51:33 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DA77511C0E7; Fri, 26 Aug 2022 02:51:18 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DA72611C0DE; Fri, 26 Aug 2022 02:51:16 +0000 (GMT) Received: from [9.200.41.99] (unknown [9.200.41.99]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 26 Aug 2022 02:51:16 +0000 (GMT) Message-ID: <7698cb5b-ccf6-d766-7a92-501d725e69c5@linux.ibm.com> Date: Fri, 26 Aug 2022 10:51:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions Content-Language: en-US To: HAO CHEN GUI , David Edelsohn Cc: gcc-patches , Peter Bergner , Segher Boessenkool References: <2ffb2ff4-540d-3bcf-4e4e-478acbdd910d@linux.ibm.com> <20220823142620.GU25951@gate.crashing.org> <55bbac6d-7595-df10-0a2b-e09ca25f90f5@linux.ibm.com> <8177d3a3-ec97-c15e-dddd-ec88930757dd@linux.ibm.com> <4edae9bd-4a0e-449e-08ed-6029f4ad8745@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <4edae9bd-4a0e-449e-08ed-6029f4ad8745@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 2bN7tQNJsLE3lZiMAhsGm4FbQnJjebtK X-Proofpoint-ORIG-GUID: Stmdl9aGzA3ZxCF7zYt_RuxDiUcecW-a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-25_11,2022-08-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=999 phishscore=0 spamscore=0 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208260008 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2022/8/26 10:42, HAO CHEN GUI wrote: > Hi David, > > On 25/8/2022 下午 10:01, David Edelsohn wrote: >> On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin wrote: >>> >>> on 2022/8/25 11:37, HAO CHEN GUI wrote: >>>> Hi, >>>> >>>> On 24/8/2022 下午 1:24, Kewen.Lin wrote: >>>>> Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" all the time, but still >>>>> having that has_arch_ppc64 effective target on aix? >>>>> >>>>> I'd expect has_arch_ppc64 check to fail on aix 32bit, the error will not be a problem (turning >>>>> into an UNSUPPORTED then)? >>>> >>>> I tested it on AIX. "has_arch_ppc64" fails with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" on >>>> 32-bit AIX environment. It works as we expected. >>> >>> Nice, thanks for your time on testing. >>> >>>> >>>> Also I found that AIX and Darwin are skipped for bfp test. So in testcase, it's no need to care >>>> about them. Not sure if it's intention. >>>> >>>> In bfp.exp >>>> >>>> # Exit immediately if this isn't a PowerPC target or if the target is >>>> # aix or Darwin. >>>> if { (![istarget powerpc*-*-*] && ![istarget rs6000-*-*]) >>>> || [istarget "powerpc*-*-aix*"] >>>> || [istarget "powerpc*-*-darwin*"] } then { >>>> return >>>> } >>> >>> I can't find a hint about why we wanted to disable bfp testing on aix, it looks like a overkill to me. >>> >>> Could you help to further test if all test cases in this small bucket available on aix? >>> >>> Maybe it can give us some evidences on why it's intentional or not. >>> >>> Hi David & Segher, >>> >>> Do you have some insights on this? >> >> AIX (and Darwin) are not Linux and not ELF. There is no support for >> BPF. All of the tests fail, so they are skipped. > > Thanks so much for your info. +1! But I guessed the name BFP (short for IEEE binary fp IMHO) was misread as BPF (eBPF)? > > Here are test results on P7 AIX7.1. I tested all scalar-extract-sig-* and scalar-insert-exp-* cases in > "testsuite/powerpc/bfp" fold. All compiling cases pass except those use __ieee128. The runnable cases > fail as expected. p9vector is not supported on P7 servers. Thanks for testing again. > > So the __ieee128 blocks Binary floating-point on AIX? We can add one extra effective target ppc_ieee128_ok for them, aix is already excluded in the check. BR, Kewen