public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Alexandre Oliva <aoliva@gcc.gnu.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Problems with strub tests
Date: Tue, 19 Dec 2023 21:40:32 -0700	[thread overview]
Message-ID: <76a02442-290a-4929-b566-035753afd859@gmail.com> (raw)


So the strub tests in c-c++-common are problematical.  They get run 
twice, once for C, once for C++.  Yet the name of the test is the same 
in both runs. (by the name, I mean the name emitted into the dejagnu 
summary and log files).

Thus if you have a test in there which passes in one context, but fails 
in the other, comparison tools like contrib/compare_tests may 
erroneously report the tests as both a test which now fails, but passed 
before and a test which now passes but failed before.

It looks like some of the strub tests are currently known to fail with 
C++ and are triggering this problem


Ideally we'd include the c or c++ in the test name depending on which 
context its being run within.  That would be sufficient to resolve these 
problems and avoid them in the future.  It would also be sufficient to 
get all the tests to the point where their behavior is the same for both 
languages.

Not sure if the latter is reasonably in the cards or not.  If it's not 
likely to land soon, any change you could look at the framework for 
c-c++-common and get the names unique across the two times they're run?

A third option would be to change the compare_tests tool to somehow 
distinguish between the C and C++ tests.  Not sure how feasible that is.

Thanks,
Jeff

             reply	other threads:[~2023-12-20  4:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20  4:40 Jeff Law [this message]
2023-12-20  6:31 ` [PATCH] compare_tests: distinguish c-c++-common results by tool Alexandre Oliva
2023-12-20 17:17   ` Jeff Law
2024-01-07  1:51 ` Problems with strub tests Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76a02442-290a-4929-b566-035753afd859@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=aoliva@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).