From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by sourceware.org (Postfix) with ESMTPS id 44546384AB40 for ; Sat, 1 Jun 2024 04:40:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44546384AB40 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 44546384AB40 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::734 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717216849; cv=none; b=PNM7sHQSRRAENKKy7yUrS9PTQFW8iKvI74jr/aZhkUyQLXSoA/dgmM+HsoiPK4bb/kcM7YJzKATE2dF/TcKrGxWxjKMSNZRvXmwreECylx76FHL2gcvaIWTGO/yeoBhm8s5INmP7O1l8k6joP5qmXuh5Gk65gRQg3Oda5NjrEh8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717216849; c=relaxed/simple; bh=emzmEW6rJBrAQPjOs+ktbXvQZzkuIJ42ZOGWkOCKMmE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=p2JTBvy/LuSo+7qC0CpoXvpGiG39SO7pXaTs9cDt3mzqIdL/FSzL/hXw/TH4bFiWZhX8dWvTNE70x5Em/yCb69KL4au1vDklJdUCj0owZV7zQZRVFZ9eXAdNjqCzurK/acsgy4pMhZimNM03dPvGuOiixIIYRNQ5cjrvdNEQ5kE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-794ab28c3d4so210010785a.3 for ; Fri, 31 May 2024 21:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717216847; x=1717821647; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NAib4NG5AhQTqqiJzgmAotjyrL9CpgiLnVmTBfYJmfM=; b=eiShiJWyEYzF3w3koy4X9HIp5SGD1D/OBWHJsRaOH8nf07lqHCrnI894bLcF70/AQ5 M5RXKIhSe5w28XhnTd+N9MgGwOqrNdaFHUQkPOyfx9wPXxIemnDWrEbmkWvBrMWJDcYJ nyIWtUUFWhfFwfMZC0rttbtXspCtJZ3QXQaWml1E9BLRQX6XBAVQkveED1sSGIIf269z 0umjTbfZRrIi7Bpzp1u4ccoy+PBx5PD2a4zA0KVaoXmMqFwr6VwpXk0GxleWqky88B65 qbQwfNMD11JW4V9ZIokLRtLtEPA1geo/+Za8H7zx400UQgJqTi2Afiqwfw3wN54xZDVh 4PNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717216847; x=1717821647; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NAib4NG5AhQTqqiJzgmAotjyrL9CpgiLnVmTBfYJmfM=; b=Mq0qmLKOsyrYU5QPoZrLw84HJpei0PED4VqtJei3a5JylNYJU/bccQZfznA8ijt6o0 Db94a5iRlgPf0QdWz1FqS2wtFYA4e3CrxYG3PAPTMEeJ0KRkmUilgoVVGz2aSue+FwKx 2OvUhLo6vVjISVF0wBHG3pjI6sEHOTkEYGKQHmQnc4+uFnzsaaol325iKhmEm1REtCKF 2fVRRRIfy3KxklHRjnSCTuT5kPNEyZlZQD6oU4xaw2inwRgJ/RBUOlg3rcz0tnLQAEUC xoRbxf3BKAILd3sHtwR1YWxHYrq5PsDuLWc5uedGL6YAvyccZ+OuiB/SCIZEr+bTxJ8Y Ht9Q== X-Forwarded-Encrypted: i=1; AJvYcCUMVI19NzpnOog6P2WKvnAt3A10xdWnvSyUBsisf9c4SOPXfoF5z9f+6kKFeWrUIphr94ow9MpP7cM82lUVcQkXGk8KrVjv+A== X-Gm-Message-State: AOJu0YyBlsf+SdkOI0mRD5CZkNOGt8/pXockVjXqtxfhfTSqfnq22042 45h4DG/Yl7ydheJ+DjSlv+Z5lUKp/4IyCOf+FwQhu9BRtkvFMcTVJIsqpA== X-Google-Smtp-Source: AGHT+IHTT6clHW0WreghSeXS0kDtd9IhA7bDQliNvcTyNR3hSGK3EHnxA9+7qt+IPmltSWahKobbEw== X-Received: by 2002:a05:620a:89c:b0:792:aac4:287 with SMTP id af79cd13be357-794f5c8cd0emr359549185a.34.1717216847510; Fri, 31 May 2024 21:40:47 -0700 (PDT) Received: from [192.168.3.58] ([216.181.162.155]) by smtp.gmail.com with ESMTPSA id af79cd13be357-794f2f12a6fsm109130385a.33.2024.05.31.21.40.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 May 2024 21:40:47 -0700 (PDT) Message-ID: <76bc5ed5-c6e0-423b-ace9-3f2a78d58474@gmail.com> Date: Fri, 31 May 2024 22:40:43 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH 5/5][v3] RISC-V: Avoid inserting after a GIMPLE_COND with SLP and early break Content-Language: en-US To: Richard Biener , gcc-patches@gcc.gnu.org References: <20240531134404.12930132C2@imap1.dmz-prg2.suse.org> From: Jeff Law In-Reply-To: <20240531134404.12930132C2@imap1.dmz-prg2.suse.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/31/24 7:44 AM, Richard Biener wrote: > When vectorizing an early break loop with LENs (do we miss some > check here to disallow this?) we can end up deciding to insert > stmts after a GIMPLE_COND when doing SLP scheduling and trying > to be conservative with placing of stmts only dependent on > the implicit loop mask/len. The following avoids this, I guess > it's not perfect but it does the job fixing some observed > RISC-V regression. > > * tree-vect-slp.cc (vect_schedule_slp_node): For mask/len > loops make sure to not advance the insertion iterator > beyond a GIMPLE_COND. Note this patch may depend on others in the series. I don't think the pre-commit CI tester is particularly good at handling that, particularly if the other patches in the series don't have the tagging for the pre-commit CI. What most likely happened is this patch and only this patch was applied against the baseline for testing. There are (manual) ways to get things re-tested. I'm hoping Patrick and Edwin automate that procedure relatively soon. Until that happens you have to email patchworks-ci@rivosinc.com with a URL for the patch in patchwork that you want retested. Jeff