From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] --target-help: align with --help=target
Date: Wed, 6 Apr 2022 09:27:53 -0600 [thread overview]
Message-ID: <76c07fd9-c966-4d47-b1e7-4e9a279f44aa@gmail.com> (raw)
In-Reply-To: <ccb1bfcc-74a4-5ec6-7916-60a94b815ead@suse.cz>
On 3/31/2022 12:56 AM, Martin Liška wrote:
> Hi.
>
> Before the patch we have:
>
> $ gcc-11 --help | grep target-help
> --target-help Display target specific command line options.
> $ gcc-11 --help=common | grep target-help
> --target-help Alias for --help=target.
>
> and --target-help prints undocumented options (that was reported in
> the PR).
>
> After my change we do:
>
> $ gcc --help | grep target-help
> --target-help Display target specific command line
> options (including assembler and linker options).
> $ gcc --help=common | grep target-help
> --target-help Display target specific command line
> options (including assembler and linker options).
>
> and the undocumented options are not printed.
>
> Ready to be installed after tests?
> Thanks,
> Martin
>
> PR driver/105096
>
> gcc/ChangeLog:
>
> * common.opt: Document properly based on what it does.
> * gcc.cc (display_help): Unify with what we have in common.opt.
> * opts.cc (common_handle_option): Do not print undocumented
> options.
OK
jeff
prev parent reply other threads:[~2022-04-06 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 6:56 Martin Liška
2022-04-06 15:27 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76c07fd9-c966-4d47-b1e7-4e9a279f44aa@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).