From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 21BA6383981F for ; Wed, 6 Apr 2022 15:27:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 21BA6383981F Received: by mail-pl1-x62f.google.com with SMTP id c23so2299796plo.0 for ; Wed, 06 Apr 2022 08:27:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ZmdlmTVM/3tGvVAwZNcNm58ytAf295ihXCoJh+xF1cg=; b=g3McJNPqE3hf8dBIyX7jDgp9Oky8GqBdCMj02uS+T35RojhUolH4I0oJ26QMYauI0V DB8xpwzPDWm4hQyWHhz81Tw46rvbs6aoawsmBsitKy3dPAOTfObZqsy3Md1gdk1lL+PV +RogKsuWpws+Xx9AI9Clb8eJP2x870SUzqc+3PTAG6qiH8aNAnHWeeuyyi4i/yEkc+Al +HBAuc7E0yho2K9/C6Q84C0fs3WSihEuOXeBSvLhOASd6Mr4ikRzvVqWswNpPtXXreAO qJ9mn2yLIronHAIsfyWkP0S4J6xXOIPtasI3XdygidAu5HPH2mhGEMPFJGreIknFnPgG jHog== X-Gm-Message-State: AOAM530mxkH05iGT9pWWyuAGSysXvpZCWmF23ttj4yjDnccV9W3q33Hq eVnxJ3B60lVBwEjumpRcPKUCa5jjtHif9w== X-Google-Smtp-Source: ABdhPJwJaeE+GtwEc/3BPrL7OdgX3iSOQobIcJB5tH9XQSAwmEUHmfnPjxlbAXbPs24Cg3X95t2Kkw== X-Received: by 2002:a17:902:740b:b0:156:9eed:d2d4 with SMTP id g11-20020a170902740b00b001569eedd2d4mr9236792pll.80.1649258874976; Wed, 06 Apr 2022 08:27:54 -0700 (PDT) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id hk16-20020a17090b225000b001ca00b81a95sm6336293pjb.22.2022.04.06.08.27.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 08:27:54 -0700 (PDT) Message-ID: <76c07fd9-c966-4d47-b1e7-4e9a279f44aa@gmail.com> Date: Wed, 6 Apr 2022 09:27:53 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] --target-help: align with --help=target Content-Language: en-US To: gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SCC_BODY_URI_ONLY, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 15:27:57 -0000 On 3/31/2022 12:56 AM, Martin Liška wrote: > Hi. > > Before the patch we have: > > $ gcc-11 --help | grep target-help >   --target-help            Display target specific command line options. > $ gcc-11 --help=common | grep target-help >   --target-help               Alias for --help=target. > > and --target-help prints undocumented options (that was reported in > the PR). > > After my change we do: > > $ gcc --help | grep target-help >   --target-help            Display target specific command line > options (including assembler and linker options). > $ gcc --help=common | grep target-help >   --target-help               Display target specific command line > options (including assembler and linker options). > > and the undocumented options are not printed. > > Ready to be installed after tests? > Thanks, > Martin > >     PR driver/105096 > > gcc/ChangeLog: > >     * common.opt: Document properly based on what it does. >     * gcc.cc (display_help): Unify with what we have in common.opt. >     * opts.cc (common_handle_option): Do not print undocumented >     options. OK jeff