From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 859D23858D28 for ; Wed, 26 Apr 2023 02:24:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 859D23858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1a95aef9885so30550385ad.1 for ; Tue, 25 Apr 2023 19:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682475893; x=1685067893; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VKeaZ376LSdDQrtkkYMSqjaLZKGaLBxU1NDjfIUOX+Q=; b=ka59omw0cA6aB03Lq08Uw8LTOiBsCsJ+YgoTkXF9JvCQ67QnQxq0D7pglxoCvM2alt kMjyt9d4hoZ+Qph9haaM+g1MUW7UYMXnVrX93Kp9k8F8EzTPmtGin/LUk3bxepDuB+sZ KGWX8K2RBRacjIyEb8QCVz86eOeMbIg9ykCspV7PJD9ut2MCfTEqeRR08V8DlupRlJBe L7JxeO6zUn1MzCaHo+7ZifXZ4iXg33x+qAsZi6ToLmSAGhcLiP20cTOMCUM3/6AuKUZX N/zGGnP2egarVuI2+oz+KlighcAEGeoSD60gNnTLOF89oeomtnqVrvP23y6g3nYLvrjM yCSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682475893; x=1685067893; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VKeaZ376LSdDQrtkkYMSqjaLZKGaLBxU1NDjfIUOX+Q=; b=laur3L50O0ATlILn6ZSs9OKzqHtSpGyF2JCt91PlMhgpgo+flEsiMM2J7GcrmyNF/9 7tLf9RLLgvDskAI1d40CM/bckoSS9nPcfFmyLOlKfGRh0w7cnlvFiuLnxCKVe+af8umJ zrpT94vLyaa8kKJdn6XJYE7ZixEsVDNMdHE8l1tNbnZAsnDfPap13H+FHdtRGqtDNpHx IepJb1MkbKZMg5jc8zbun0lC8ME+a0MJlbRf+xR+YxNTP3QcehXZxUtNxtGh3jJ8NFiP mHjNbqbDe/EKheC71szoqQh8KCQ7zt68Gk/IsFSPwuI8QyDT2irqJvwD5kc86u6CJ2wv m8iw== X-Gm-Message-State: AAQBX9f5mLr2LFUyaRa6U+9aoEmfyh+QCo9qas5E5Dn3P1Q10CNxmstk cV8ugacVmhADAAtwRnBYFCs= X-Google-Smtp-Source: AKy350Yp4DVvdp28CVI6a0I6fCP2bjAukQBGFko327e+CFbQRPwtscj6v/nnElxzO5URGXjkb3pccA== X-Received: by 2002:a17:903:1209:b0:1a6:4606:6e06 with SMTP id l9-20020a170903120900b001a646066e06mr24220381plh.17.1682475893157; Tue, 25 Apr 2023 19:24:53 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id az1-20020a170902a58100b0019cbe436b87sm8886165plb.81.2023.04.25.19.24.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 19:24:52 -0700 (PDT) Message-ID: <770f5e42-0293-dc79-e87b-4c59ed785647@gmail.com> Date: Tue, 25 Apr 2023 20:24:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [xstormy16 PATCH] Add support for byte and word swapping instructions. Content-Language: en-US To: Roger Sayle , 'GCC Patches' References: <019e01d977b3$6ea3cc20$4beb6460$@nextmovesoftware.com> From: Jeff Law In-Reply-To: <019e01d977b3$6ea3cc20$4beb6460$@nextmovesoftware.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/25/23 14:20, Roger Sayle wrote: > > This patch adds support for xstormy16's swpb (swap bytes) and swpw (swap > words) instructions. The most obvious application of these to implement > the __builtin_bswap16 and __builtin_bswap32 intrinsics. > > Currently, __builtin_bswap16 is implemented as: > foo: mov r7,r2 > shl r7,#8 > shr r2,#8 > or r2,r7 > ret > > but with this patch becomes: > foo: swpb r2 > ret > > Likewise, __builtin_bswap32 now becomes: > foo: swpb r2 | swpb r3 | swpw r2,r3 > ret > > Finally, the swpw instruction on its own can be used to exchange > two word mode registers without a temporary, so a new pattern and > peephole2 have been added to catch this. As described in the > PR rtl-optimization/106518, register allocation can (in theory) > be more efficient on targets that provide a swap/exchange instruction. > The slightly unusual swap naming matches that used in i386.md. > > This patch has been tested by building a cross-compiler to xstormy16-elf > from x86_64-pc-linux-gnu, and confirming the new test cases pass. > Ok for mainline? > > > 2024-04-25 Roger Sayle > > gcc/ChangeLog > * config/stormy16/stormy16.md (bswaphi2): New define_insn. > (bswapsi2): New define_insn. > (swaphi): New define_insn to exchange two registers (swpw). > (define_peephole2): Recognize exchange of registers as swaphi. > > gcc/testsuite/ChangeLog > * gcc.target/xstormy16/bswap16.c: New test case. > * gcc.target/xstormy16/bswap32.c: Likewise. > * gcc.target/xstormy16/swpb.c: Likewise. > * gcc.target/xstormy16/swpw-1.c: Likewise. > * gcc.target/xstormy16/swpw-2.c: Likewise. OK. And like prior patches, if it causes any problems in wider testing, we'll know ~24hrs after the bits go in. jeff