From: Tobias Burnus <tobias@codesourcery.com>
To: Harald Anlauf <anlauf@gmx.de>, <fortran@gcc.gnu.org>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] Fortran: Various CLASS + assumed-rank fixed [PR102541]
Date: Mon, 11 Oct 2021 13:32:38 +0200 [thread overview]
Message-ID: <7729ef81-e678-0ea8-1159-9513dccd6049@codesourcery.com> (raw)
In-Reply-To: <6c3386a2-0d52-d15a-0aff-d8435e2cbbae@gmx.de>
Hi Harald,
On 10.10.21 21:27, Harald Anlauf via Fortran wrote:
> just some random remarks from initially browsing your patch.
Thanks for browsing the patch :-)
> - leftover from debugging?
Yes.
> - code that could be shortened/made slightly more readable:
> ...
> Is there a reason to not use strcmp (comp->name, "_data") == 0?
Just (pre-mature) optimization. I think the latter is clearer; I will
change it.
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2021-10-11 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 0:43 Tobias Burnus
2021-10-06 10:24 ` PING - (Re: [Patch] Fortran: Various CLASS + assumed-rank fixed [PR102541]) Tobias Burnus
2021-10-11 20:13 ` PING**2 " Tobias Burnus
2021-10-10 19:27 ` [Patch] Fortran: Various CLASS + assumed-rank fixed [PR102541] Harald Anlauf
2021-10-11 11:32 ` Tobias Burnus [this message]
2021-10-11 20:20 ` Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7729ef81-e678-0ea8-1159-9513dccd6049@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).