From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id DA1BF3858D32 for ; Wed, 12 Apr 2023 13:29:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA1BF3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6354dce93d2so1171090b3a.0 for ; Wed, 12 Apr 2023 06:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681306177; x=1683898177; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0muK/TTTmo6vfg6lGD/qc+8fui8/T0D5tYuldpcYsgg=; b=IXPJ17a3vtKrN7wYaFCvuc9SGiCXP7zwTZ9RPs569AFHjMxj6Hgd/UkWpIJoX0G+vX 5G/huPVSKWk17iHS4sHVQcntOVeQTYkfnuoZDt2R51Qo9EgyOc0VL4/Hebdezga9P6qr OYELpsjApuxeb0lMjJeZS1nZSTn6xAP1FG9jKeptWP+YPTI7w9Yy1klmVJnVQPa4sVcv iZpi/VNVjE0re/30a3H/A5qkn6LmMLYw+RvgtBNJ32zc5p6SXc6KlPzLbaA5N75sLH0M 4vjTLtQLQSOEjH3ICJxtAPmlOByUcn2Ij8C2AeCd91c3bkvnQb9Y/H9gkCRU+SodynoY Tbhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681306177; x=1683898177; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0muK/TTTmo6vfg6lGD/qc+8fui8/T0D5tYuldpcYsgg=; b=BBdY+sONA/ChjULcf2xmvTp9PK2fs0H1UUvkOw3pJFfetWFjhNl7jpKICVv1t0O4cL 4Nh3OxFEPKr2aHi+BBQOcZdDqM9OvlkGzNQQ/n2zvb47acbTuNj9bidX6if07YddFxgl J/YzPbh7bzX6u4m5B8+tmIit42kW6j4LK6G5jypTqMsKj84R8r3viQ9V0cfsIzF4NkLM Rf+nHBx23iD5XCq6PaAobmgcdniiXLz903f7kUzN27rX8u6TtkYxVhkP9XTVtudnBCpC AyQQwPKgvb7SQgoMlv9RmIva9b9vOklPDYwZj/XUpTViAiqdmuXh1wK0re5T+RlZnpY3 PD4w== X-Gm-Message-State: AAQBX9eM+TMSMGT1V0F0CyLQEiCU/84d04fhlRnDUDHb5PB85zA3Q7JH A8Jd9lLOGF8pOdiWNEalaAY= X-Google-Smtp-Source: AKy350aTX9iaSy4Y3Ks4hYBY897P94NglpIsCHOmpstd5FCIGOwPVa3JqTj/7eOQZ6hnC2+ZSARVFg== X-Received: by 2002:aa7:9e1a:0:b0:639:b8d5:f17a with SMTP id y26-20020aa79e1a000000b00639b8d5f17amr6593306pfq.2.1681306177404; Wed, 12 Apr 2023 06:29:37 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id u5-20020a62ed05000000b0062a56e51fd7sm11645324pfh.188.2023.04.12.06.29.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 06:29:36 -0700 (PDT) Message-ID: <77648fcb-984d-6d1c-994a-597c7d8062ea@gmail.com> Date: Wed, 12 Apr 2023 07:29:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] combine: Fix simplify_comparison AND handling for WORD_REGISTER_OPERATIONS targets [PR109040] Content-Language: en-US To: Jakub Jelinek Cc: Eric Botcazou , gcc-patches@gcc.gnu.org, Richard Biener , Richard Sandiford References: <2220543.iZASKD2KPV@fomalhaut> <3412470.QJadu78ljV@fomalhaut> <8d3c3861-c291-e762-a2a8-0b520f39a7e3@gmail.com> <965831db-ac9e-cc5e-3459-08b6b70fd577@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/23 00:21, Jakub Jelinek wrote: > On Tue, Apr 11, 2023 at 07:26:07PM -0600, Jeff Law wrote: >> I did bootstrap on riscv, but not a regression test, that's spinning right >> now. >> >> Jeff > >> diff --git a/gcc/combine.cc b/gcc/combine.cc >> index 22bf8e1ec89..c41d8a09b3b 100644 >> --- a/gcc/combine.cc >> +++ b/gcc/combine.cc >> @@ -10055,9 +10055,10 @@ simplify_and_const_int_1 (scalar_int_mode mode, rtx varop, >> >> /* See what bits may be nonzero in VAROP. Unlike the general case of >> a call to nonzero_bits, here we don't care about bits outside >> - MODE. */ >> + MODE unless WORD_REGISTER_OPERATIONS is true. */ > > I would have expected something like > WORD_REGISTER_OPERATIONS && known_le (GET_MODE_PRECISION (mode), BITS_PER_WORD) > as the condition to use word_mode, rather than just > WORD_REGISTER_OPERATIONS. In both spots. Because larger modes should be > used as is, not a narrower word_mode instead of them. Agreed. Jeff