From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <amonakov@ispras.ru>
Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84])
 by sourceware.org (Postfix) with ESMTPS id 6F0593858D32
 for <gcc-patches@gcc.gnu.org>; Sun, 15 May 2022 10:09:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F0593858D32
Received: from [10.10.3.121] (unknown [10.10.3.121])
 by mail.ispras.ru (Postfix) with ESMTPS id 9263140D4004;
 Sun, 15 May 2022 10:09:25 +0000 (UTC)
Date: Sun, 15 May 2022 13:09:24 +0300 (MSK)
From: Alexander Monakov <amonakov@ispras.ru>
To: Rui Ueyama <rui314@gmail.com>
cc: =?ISO-8859-15?Q?Martin_Li=A8ka?= <mliska@suse.cz>, 
 GCC Patches <gcc-patches@gcc.gnu.org>, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] lto-plugin: add support for feature detection
In-Reply-To: <CACKH++Y3pd7945CB4DuR4_wzL=fTpgMEx6f0ptNY-n8WVEtzmw@mail.gmail.com>
Message-ID: <7788e58e-ce41-d25b-eefe-5f9c966a2ff2@ispras.ru>
References: <63633ead-aa7e-c424-9851-ac332ac13df3@suse.cz>
 <27841a42-baef-d53e-c601-ad265030854d@suse.cz>
 <cabc1aa6-6895-f66-f372-b54478ff8a36@ispras.ru>
 <e576db11-bb6f-f866-7ebb-b3d218391c06@suse.cz>
 <c9f66e9b-29ab-f7eb-78d6-2270ebcb7d22@ispras.ru>
 <ec985643-642f-979d-2c59-7e23543ade09@suse.cz>
 <CAFiYyc0AkfsqK5VxiSGG1kQN9GVirgiK8AEie5XdGvoZ9bchSg@mail.gmail.com>
 <CAFiYyc22y-rDGuJ6g=mWEDjcW+uaMRLkXitxYYZgzR+Jse8MPQ@mail.gmail.com>
 <da61b59-4588-cd97-5ce1-b8c51f7a33a4@ispras.ru>
 <ccdd53c7-5596-f6bb-4a9c-2d77d1641bd0@suse.cz>
 <80f37f2-efdf-673-a8f4-69f2d5842ea2@ispras.ru>
 <CACKH++ZOA09Jsw9CD8F5U9ZoRCBYFNKYPhF8ZZKxPuEG7aniQA@mail.gmail.com>
 <9de185b3-914-8522-7eb-40b802d4651@ispras.ru>
 <CACKH++YwDR-QsD_fv5Ku1w8TTrXK5N14=8LuHh02jYgbokr+Tw@mail.gmail.com>
 <d1d63bdc-1646-5c44-8dad-2c4ae97b93@ispras.ru>
 <CACKH++Y3pd7945CB4DuR4_wzL=fTpgMEx6f0ptNY-n8WVEtzmw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 15 May 2022 10:09:37 -0000

On Sun, 15 May 2022, Rui Ueyama wrote:

> > Makes sense, but I still don't understand why mold wants to discover in
> > advance whether the plugin is going to use get_symbols_v3. How would it
> > help with what mold does today to handle the _v2 case?
> 
> Currently, mold restarts itself to reset the internal state of the plugin.
> If we know in advance that get_symbols_v3 is supported, we can avoid that
> restart. That should make the linker a bit faster. Also, restarting the
> linker is a hack, so we want to avoid it if possible.

Can you simply restart the linker on first call to get_symbols_v2 instead?

Alexander