From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id ADF58398AC23 for ; Sun, 20 Nov 2022 16:21:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ADF58398AC23 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-xd2e.google.com with SMTP id e189so7146955iof.1 for ; Sun, 20 Nov 2022 08:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wUy8fSsr99TcjeuYNbiXY46ds1H3R2moBCA9rVbTiVQ=; b=IAd0RDVFUErKT+ry47xccz4HLw54V7yvcj6SxwDzRhtk4a/62fPxiO5nH1mrEr/HVi 59d4dU3jX0/4FFeNYHElEhKd9CreHO45e4KWxX4OFHUTdejXG+hfu1ad6CBwQvPcR2Tk cyVxAs6vgssOcW3vM+Bbz8ExQoOVSEecyksXqvnydANiDeQYCTnJYaicgkygiNDwq7Is a2/GeO4X3q42ZeFO6HllbnU5gTijxrZsaaZnYMCHm9SkVUiX47vm2WFRwpPCczNIVkOz sIasJBxd4AciR5tDznlzHsEKJVsSdvQZ7pQOaPOIR6mLKuRhKPr6bjrXMbXrxFz9onLL ORXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wUy8fSsr99TcjeuYNbiXY46ds1H3R2moBCA9rVbTiVQ=; b=vFTGksIa5LbFi6FOmMDGewVplbtGzpAnUJ7ARVvbml3N+N/nfER4mzn20tWOdlBtQ8 dVhLg/ePcq2heXl8WKK94yWd0sjCwz+TBKGWCVsRQQrbFjE1rWc66bfxdq/DR/nnD4vB Le01gy0tyGuQqJOIY/WvPhN5YdzHyi2reytggVTocR4qJ1hKTYXpWxEn6w1cB8c4shh+ 7zJBa4JSGsYAXCH0t9sBiNUfrAI/7Dtb+PkCeTpTrZeo6b5CgXe+30oJLY/AUieqce2r ld9L2rqyPKuM6C0Hu6hM0Ap/7hvremba4YAw6XqVhkvudxNqpLakxQ6AQ7buwtufCSyP 44/w== X-Gm-Message-State: ANoB5pko5zB4ZExPv004Yer37jv3sxlIitp90dZbNpSV9mem4sW4s5QB y8T+Dr14UNQX1yDw4U4vUQnYQyTn13U= X-Google-Smtp-Source: AA0mqf45qHpbHjVq/mouhZnW0UWwYkDTbiLljBmmmF7ymqio2dHhdjoG6785+IKA+I1398/s9wOKRQ== X-Received: by 2002:a02:b118:0:b0:363:eba9:4e81 with SMTP id r24-20020a02b118000000b00363eba94e81mr6623086jah.69.1668961261810; Sun, 20 Nov 2022 08:21:01 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id 7-20020a921307000000b00300b9b7d594sm3164050ilt.20.2022.11.20.08.21.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 08:21:01 -0800 (PST) Message-ID: <77fa8b8d-9528-2e4e-6681-e67907bf6b37@gmail.com> Date: Sun, 20 Nov 2022 09:20:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] testsuite: Add filter for target socket support Content-Language: en-US To: Dimitar Dimitrov , gcc-patches@gcc.gnu.org References: <20221120100257.281467-1-dimitar@dinux.eu> From: Jeff Law In-Reply-To: <20221120100257.281467-1-dimitar@dinux.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/20/22 03:02, Dimitar Dimitrov wrote: > The new analyzer tests for sockets are failing on embedded targets. > The newlib and avr-libc C libraries do not support sockets. > > At first I considered a coarse filtering on the existing > effective_target_freestanding check. But seeing how lib/target-supports.exp > is slowly turning into a copy of autotools, I kept the tradition and added > a new fine grained "socket" filter. > > I also considered adding effective_target_posix, but could not > figure out a reliable C code to perform the check. > > Testing done: > - No changes in gcc.sum for x86_64-pc-linux-gnu, with or without this > patch. > - Filtered cases are now UNSUPPORTED instead of failing on AVR and PRU > backends. > > Ok for trunk? > > gcc/ChangeLog: > > * doc/sourcebuild.texi (sockets): Document new check. > > gcc/testsuite/ChangeLog: > > * gcc.dg/analyzer/fd-accept.c: Require sockets. > * gcc.dg/analyzer/fd-bind.c: Ditto. > * gcc.dg/analyzer/fd-connect.c: Ditto. > * gcc.dg/analyzer/fd-datagram-socket.c: Ditto. > * gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c: > Ditto. > * gcc.dg/analyzer/fd-glibc-byte-stream-socket.c: Ditto. > * gcc.dg/analyzer/fd-glibc-datagram-client.c: Ditto. > * gcc.dg/analyzer/fd-glibc-datagram-socket.c: Ditto. > * gcc.dg/analyzer/fd-listen.c: Ditto. > * gcc.dg/analyzer/fd-manpage-getaddrinfo-client.c: Ditto. > * gcc.dg/analyzer/fd-mappage-getaddrinfo-server.c: Ditto. > * gcc.dg/analyzer/fd-meaning.c: Ditto. > * gcc.dg/analyzer/fd-socket-meaning.c: Ditto. > * gcc.dg/analyzer/fd-socket-misuse.c: Ditto. > * gcc.dg/analyzer/fd-stream-socket-active-open.c: Ditto. > * gcc.dg/analyzer/fd-stream-socket-passive-open.c: Ditto. > * gcc.dg/analyzer/fd-stream-socket.c: Ditto. > * gcc.dg/analyzer/fd-symbolic-socket.c: Ditto. > * lib/target-supports.exp (check_effective_target_sockets): New > check. OK jeff