* [PATCH] Fix r242743 change of gcc/system.h
@ 2017-03-19 21:20 Gunther Nikl
2017-03-19 21:24 ` Paolo Bonzini
2017-03-27 18:02 ` Jeff Law
0 siblings, 2 replies; 4+ messages in thread
From: Gunther Nikl @ 2017-03-19 21:20 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: gcc-patches
Hello Paolo!
Building older GCC releases with clang tends to issue warnings. This
can be annoying especially when they originate from a header. While
backporting r242743 I noticed that the non-C++ cases of the changed
macro definitions in gcc/system.h are broken. Since GCC trunk is build
in C++ mode this is not an issue, but should be fixed nevertheless I
think.
Regards,
Gunther
gcc:
2017-03-XX Gunther Nikl <gnikl@users.sourceforge.net>
* system.h (HAVE_DESIGNATED_INITIALIZERS,
HAVE_DESIGNATED_UNION_INITIALIZERS): Fix non C++ case.
Index: gcc/system.h
===================================================================
--- gcc/system.h (revision 246106)
+++ gcc/system.h (working copy)
@@ -581,7 +581,7 @@ extern int vsnprintf (char *, size_t, const char *
#define HAVE_DESIGNATED_INITIALIZERS 0
#else
#define HAVE_DESIGNATED_INITIALIZERS \
- (((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
+ ((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
#endif
#endif
@@ -590,7 +590,7 @@ extern int vsnprintf (char *, size_t, const char *
#define HAVE_DESIGNATED_UNION_INITIALIZERS (GCC_VERSION >= 4007)
#else
#define HAVE_DESIGNATED_UNION_INITIALIZERS \
- (((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
+ ((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
#endif
#endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix r242743 change of gcc/system.h
2017-03-19 21:20 [PATCH] Fix r242743 change of gcc/system.h Gunther Nikl
@ 2017-03-19 21:24 ` Paolo Bonzini
2017-03-22 17:16 ` Gunther Nikl
2017-03-27 18:02 ` Jeff Law
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2017-03-19 21:24 UTC (permalink / raw)
To: Gunther Nikl; +Cc: gcc-patches
On 19/03/2017 22:17, Gunther Nikl wrote:
> Hello Paolo!
>
> Building older GCC releases with clang tends to issue warnings. This
> can be annoying especially when they originate from a header. While
> backporting r242743 I noticed that the non-C++ cases of the changed
> macro definitions in gcc/system.h are broken. Since GCC trunk is build
> in C++ mode this is not an issue, but should be fixed nevertheless I
> think.
>
> Regards,
> Gunther
Of course! If you have commit access, you can commit this as obvious I
think.
What is the warning like?
Paolo
>
> gcc:
> 2017-03-XX Gunther Nikl <gnikl@users.sourceforge.net>
>
> * system.h (HAVE_DESIGNATED_INITIALIZERS,
> HAVE_DESIGNATED_UNION_INITIALIZERS): Fix non C++ case.
>
>
> Index: gcc/system.h
> ===================================================================
> --- gcc/system.h (revision 246106)
> +++ gcc/system.h (working copy)
> @@ -581,7 +581,7 @@ extern int vsnprintf (char *, size_t, const char *
> #define HAVE_DESIGNATED_INITIALIZERS 0
> #else
> #define HAVE_DESIGNATED_INITIALIZERS \
> - (((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
> + ((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
> #endif
> #endif
>
> @@ -590,7 +590,7 @@ extern int vsnprintf (char *, size_t, const char *
> #define HAVE_DESIGNATED_UNION_INITIALIZERS (GCC_VERSION >= 4007)
> #else
> #define HAVE_DESIGNATED_UNION_INITIALIZERS \
> - (((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
> + ((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
> #endif
> #endif
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix r242743 change of gcc/system.h
2017-03-19 21:24 ` Paolo Bonzini
@ 2017-03-22 17:16 ` Gunther Nikl
0 siblings, 0 replies; 4+ messages in thread
From: Gunther Nikl @ 2017-03-22 17:16 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: gcc-patches
Paolo Bonzini <bonzini@gnu.org>:
>
> On 19/03/2017 22:17, Gunther Nikl wrote:
> > Hello Paolo!
> >
> > Building older GCC releases with clang tends to issue warnings. This
> > can be annoying especially when they originate from a header. While
> > backporting r242743 I noticed that the non-C++ cases of the changed
> > macro definitions in gcc/system.h are broken. Since GCC trunk is
> > build in C++ mode this is not an issue, but should be fixed
> > nevertheless I think.
> >
> > Regards,
> > Gunther
>
> Of course! If you have commit access, you can commit this as obvious
> I think.
No, I don't have commit access. Please commit the patch for me. Thanks.
> What is the warning like?
Sorry, I don't have the warning available :-/ I noticed that there
appears to be a problem because of a patch to the FreeBSD sources back
in September of the last year.
Regards,
Gunther
> > gcc:
> > 2017-03-XX Gunther Nikl <gnikl@users.sourceforge.net>
> >
> > * system.h (HAVE_DESIGNATED_INITIALIZERS,
> > HAVE_DESIGNATED_UNION_INITIALIZERS): Fix non C++ case.
> >
> >
> > Index: gcc/system.h
> > ===================================================================
> > --- gcc/system.h (revision 246106)
> > +++ gcc/system.h (working copy)
> > @@ -581,7 +581,7 @@ extern int vsnprintf (char *, size_t, const
> > char * #define HAVE_DESIGNATED_INITIALIZERS 0
> > #else
> > #define HAVE_DESIGNATED_INITIALIZERS \
> > - (((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
> > + ((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
> > #endif
> > #endif
> >
> > @@ -590,7 +590,7 @@ extern int vsnprintf (char *, size_t, const
> > char * #define HAVE_DESIGNATED_UNION_INITIALIZERS (GCC_VERSION >=
> > 4007) #else
> > #define HAVE_DESIGNATED_UNION_INITIALIZERS \
> > - (((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
> > + ((GCC_VERSION >= 2007) || (__STDC_VERSION__ >= 199901L))
> > #endif
> > #endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix r242743 change of gcc/system.h
2017-03-19 21:20 [PATCH] Fix r242743 change of gcc/system.h Gunther Nikl
2017-03-19 21:24 ` Paolo Bonzini
@ 2017-03-27 18:02 ` Jeff Law
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2017-03-27 18:02 UTC (permalink / raw)
To: Gunther Nikl, Paolo Bonzini; +Cc: gcc-patches
On 03/19/2017 03:17 PM, Gunther Nikl wrote:
> Hello Paolo!
>
> Building older GCC releases with clang tends to issue warnings. This
> can be annoying especially when they originate from a header. While
> backporting r242743 I noticed that the non-C++ cases of the changed
> macro definitions in gcc/system.h are broken. Since GCC trunk is build
> in C++ mode this is not an issue, but should be fixed nevertheless I
> think.
>
> Regards,
> Gunther
>
>
> gcc:
> 2017-03-XX Gunther Nikl <gnikl@users.sourceforge.net>
>
> * system.h (HAVE_DESIGNATED_INITIALIZERS,
> HAVE_DESIGNATED_UNION_INITIALIZERS): Fix non C++ case.
Thanks. Installed.
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-27 17:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-19 21:20 [PATCH] Fix r242743 change of gcc/system.h Gunther Nikl
2017-03-19 21:24 ` Paolo Bonzini
2017-03-22 17:16 ` Gunther Nikl
2017-03-27 18:02 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).