public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Add quotes for -fconstexpr-depth= in an error message.
@ 2018-08-29  8:27 Martin Liška
  2018-09-12 10:17 ` Martin Liška
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Liška @ 2018-08-29  8:27 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hi.

That's just simple patch that wraps an option name
in an error message into apostrophes.

Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.

Ready to be installed?
Martin

gcc/cp/ChangeLog:

2018-08-28  Martin Liska  <mliska@suse.cz>

	* constexpr.c (cxx_eval_call_expression): Add quotes
	to -fconstexpr-depth=.
---
 gcc/cp/constexpr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[-- Attachment #2: 0001-Add-quotes-for-fconstexpr-depth-in-an-error-message.patch --]
[-- Type: text/x-patch, Size: 536 bytes --]

diff --git a/gcc/cp/constexpr.c b/gcc/cp/constexpr.c
index f646519135f..15ec13e3cb1 100644
--- a/gcc/cp/constexpr.c
+++ b/gcc/cp/constexpr.c
@@ -1669,7 +1669,7 @@ cxx_eval_call_expression (const constexpr_ctx *ctx, tree t,
     {
       if (!ctx->quiet)
 	error ("%<constexpr%> evaluation depth exceeds maximum of %d (use "
-	       "-fconstexpr-depth= to increase the maximum)",
+	       "%<-fconstexpr-depth=%> to increase the maximum)",
 	       max_constexpr_depth);
       *non_constant_p = true;
       result = error_mark_node;


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Add quotes for -fconstexpr-depth= in an error message.
  2018-08-29  8:27 [PATCH] Add quotes for -fconstexpr-depth= in an error message Martin Liška
@ 2018-09-12 10:17 ` Martin Liška
  2018-09-12 10:30   ` Nathan Sidwell
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Liška @ 2018-09-12 10:17 UTC (permalink / raw)
  To: gcc-patches; +Cc: Nathan Sidwell, Jason Merrill

PING^1

On 8/29/18 10:27 AM, Martin Liška wrote:
> Hi.
> 
> That's just simple patch that wraps an option name
> in an error message into apostrophes.
> 
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
> 
> Ready to be installed?
> Martin
> 
> gcc/cp/ChangeLog:
> 
> 2018-08-28  Martin Liska  <mliska@suse.cz>
> 
> 	* constexpr.c (cxx_eval_call_expression): Add quotes
> 	to -fconstexpr-depth=.
> ---
>  gcc/cp/constexpr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Add quotes for -fconstexpr-depth= in an error message.
  2018-09-12 10:17 ` Martin Liška
@ 2018-09-12 10:30   ` Nathan Sidwell
  0 siblings, 0 replies; 3+ messages in thread
From: Nathan Sidwell @ 2018-09-12 10:30 UTC (permalink / raw)
  To: Martin Liška, gcc-patches; +Cc: Jason Merrill

On 9/12/18 6:17 AM, Martin Liška wrote:
> PING^1
> 

>> gcc/cp/ChangeLog:
>>
>> 2018-08-28  Martin Liska  <mliska@suse.cz>
>>
>> 	* constexpr.c (cxx_eval_call_expression): Add quotes
>> 	to -fconstexpr-depth=.

ok, thanks


-- 
Nathan Sidwell

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-12 10:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29  8:27 [PATCH] Add quotes for -fconstexpr-depth= in an error message Martin Liška
2018-09-12 10:17 ` Martin Liška
2018-09-12 10:30   ` Nathan Sidwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).