From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by sourceware.org (Postfix) with ESMTPS id 364123858D37 for ; Tue, 27 Sep 2022 03:30:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 364123858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xen0n.name DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1664249409; bh=GhYQeHZYlMn81p4SbSmgDaFGHEdhQy5Ag/hIQRDL8KE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iNuEWSrzsKBs3xhxgdsQiyxo5GtG3XJrFm9ZFCeUdFcG6N0719BgZjdbAbPylrc4D uDjgWPEGwcvOqehyPuHsZ0FY6662K58nJKZTvbMYGGw68Erwx5UN6Lr5P6g83IlJUU 7aPuq03fgFXpEBytzgG+65dYMeG099lS4bY5GUlE= Received: from [192.168.71.110] (unknown [116.236.142.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id CA676600CF; Tue, 27 Sep 2022 11:30:08 +0800 (CST) Message-ID: <7861c25d-3397-43d9-f29a-7a3252dd5d49@xen0n.name> Date: Tue, 27 Sep 2022 11:30:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:107.0) Gecko/20100101 Thunderbird/107.0a1 Subject: Re: [PATCH] Libvtv-test: Fix the problem that scansarif.exp cannot be found in libvtv regression test. Content-Language: en-US To: Lulu Cheng , gcc-patches@gcc.gnu.org, mliska@suse.cz, dmalcolm@redhat.com Cc: xry111@xry111.site, xuchenghua@loongson.cn References: <20220927031639.186950-1-chenglulu@loongson.cn> From: WANG Xuerui In-Reply-To: <20220927031639.186950-1-chenglulu@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022/9/27 11:16, Lulu Cheng wrote: > r13-967 add ARRIF output format. However libvtv does not add support. "SARIF support was added in r13-967 but libvtv wasn't updated." (Tip: always remember that English, unlike Chinese, isn't a "topic-prominent" language, meaning you should almost never put the "topic" at subject position of the sentence. IOW, if you find your English to be a perfect 1:1 mapping to some Chinese sentence, which is the case here, it's highly likely you need to improve it somehow. This is by no means personal, but the same pattern of broken English has been appearing in your and your teammates' commits since forever, so I'm afraid I have to point out.) > > commit 6cf276ddf22066af780335cd0072d2c27aabe468 > Author: David Malcolm > Date: Thu Jun 2 15:40:22 2022 -0400 > > diagnostics: add SARIF output format And I don't think this reference is necessary, r13-967 is already a precise description. > > libvtv/ChangeLog: > > * testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of scansarif.exp. "Load scansarif.exp." -- another example of redundant expression (no pun intended on "expression"). > --- > libvtv/testsuite/lib/libvtv-dg.exp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libvtv/testsuite/lib/libvtv-dg.exp b/libvtv/testsuite/lib/libvtv-dg.exp > index b140c194cdc..454d916e556 100644 > --- a/libvtv/testsuite/lib/libvtv-dg.exp > +++ b/libvtv/testsuite/lib/libvtv-dg.exp > @@ -12,6 +12,8 @@ > # along with this program; if not, write to the Free Software > # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. > > +load_gcc_lib scansarif.exp > + > proc libvtv-dg-test { prog do_what extra_tool_flags } { > return [gcc-dg-test-1 libvtv_target_compile $prog $do_what $extra_tool_flags] > } Otherwise LGTM.