From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id AC44D3858C50 for ; Thu, 7 Apr 2022 19:41:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC44D3858C50 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 237I6eUA024505 for ; Thu, 7 Apr 2022 19:41:52 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com with ESMTP id 3f6f1td6f8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 07 Apr 2022 19:41:52 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 237JYbKg013868 for ; Thu, 7 Apr 2022 19:41:51 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2174.outbound.protection.outlook.com [104.47.58.174]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3f97ttsfw1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 07 Apr 2022 19:41:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dY8+AG8Ehh6Ewu2KuHwXqbAxPkd2QqH129O6oPqy/yBupuJ63hyj3K/LqRZSoydHiNrgd1zpFXSAP6XYXiNYfSZSc1+D5bFyr/ssQ4DTEJQG5fX3OIXSgFIa8+zZCBUy7y0XuMK5mlVAh/4S69PikNyvGVcNHjhHIyjsidT3UV18XorXeMJqCIziokdMNTOVUQZaFv+udEpaFwWb809HIgHPfZpGLmdd1ZEV9N3Acb9flniepOhlrBCNbPQd1NYUO9+yQlFU9HYDWtDf4XH5RBpGPpS1cL04CtJRn055AXam6Go+/7VhGVzigOuL9MGwemV+8lr2WLTTIYqueGiaSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IaZljkFwGeEbEDA4fG3hq2M9muVg5fhPf1HqYKtGKIs=; b=gYoJYtZFtKm7VxLp09tFJUHffnMN3rehC1QGGIwUjTkqDS2hL34OJxdruJkvx8zf92bJkfMUROiOB6Wl3Y4TSyBmMumGtBeReoKeOANXzrYyIuuwiY7lnAZsFRFXT973l5ATsUElIgYsMppPX/ndM648JS4pQEd3bgUlJkImp9kakS/2wgisFF5KSysIGDIAl8fmic5fpJFf0r5tVPMYmz4WyX46xWXUStSKRaZ+V70y/l+a+p51hpWt2Jl/mwiD1QytQEQiMEMb1FB3H0mv+IknU8BkcAvzL9SXsvi7TH8mSgAGdeZUAKo3w7Bjt9o1OyfKhta1gTqgbEIe3CFGxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BN6PR1001MB2147.namprd10.prod.outlook.com (2603:10b6:405:2e::26) by BN0PR10MB5304.namprd10.prod.outlook.com (2603:10b6:408:129::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 19:41:49 +0000 Received: from BN6PR1001MB2147.namprd10.prod.outlook.com ([fe80::3417:eba4:fac7:a4e8]) by BN6PR1001MB2147.namprd10.prod.outlook.com ([fe80::3417:eba4:fac7:a4e8%3]) with mapi id 15.20.5144.021; Thu, 7 Apr 2022 19:41:49 +0000 Subject: Re: [PATCH 0/3] Fix PR debug/105089 From: Indu Bhagat To: gcc-patches@gcc.gnu.org References: <20220330233135.1762317-1-indu.bhagat@oracle.com> Message-ID: <787914a7-b950-cbd2-5c72-bbef4510ef67@oracle.com> Date: Thu, 7 Apr 2022 13:04:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <20220330233135.1762317-1-indu.bhagat@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR08CA0032.namprd08.prod.outlook.com (2603:10b6:4:60::21) To BN6PR1001MB2147.namprd10.prod.outlook.com (2603:10b6:405:2e::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 913730a0-3f9a-47eb-0dee-08da18cea800 X-MS-TrafficTypeDiagnostic: BN0PR10MB5304:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XFgiHMdKij6k+F7TjbnRSElBlcFgslECJqaZFD0c23uJIsWB4qacWHKEncHKrIWcgwIlTPTjuTbjB7owLocInyWsU7xhJPtrmqNZ7xIqg/hX+iUUq1mKsT/iomIKve6kKL2fN4IUu3jyj9vkMK19PHvjZltBVD01UvE4hGeA/kf3d6++j8haHxUs66lT1OcyE+4D5MB/3Q24RXNVySCQl2B1839tKnvRwJxnbRR7Was/qxTdM9Mbapi8rwb3AmIH/NZBHzEeERltwo5lGu5+PDzjwir8W0NXnbsQXlQTR1Nc3QHUM47zSnCiOZtNN/YuqO2jhl50bCQxCCzHe+FWR5vk3M+02sdKPspCq7/OCWJwJWvuSjkBp2Vbhz9osAusB2GQjA+1oOgslTwALj0qr2FUzN24eIeXo723e6Ku+ggDYOXH4tu1Aj2Ad6NO+9ISf3+q7oZwr0pNSPUUHcEC5KTZdsqc7+zqjIdSN3xRVYN+tA7FixxkNzbT4JE/DD2VGL1pUVfHAbe4gCx/oC7LkzOhTPMr2x/+CmfT0/CO0SP0Gkv+DP1QHiyTYta1jJrynPpLDcTYPDbjrJg29/eInbWd9+UZuX9SnvwqF3DVpyU7NrrNOLaMRZsDqK6OuiLVaMKjMnkIVUwTTeVprx2b4+Z3AzWXwq/EJCpxHXgbPshcwcMHebvwFJ4GzB2Insy9pZsnbIHN2zdJ+YwItYB2hDpepDK7IOLHCJWnCVUHqOk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1001MB2147.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(31686004)(66556008)(316002)(38100700002)(8676002)(66946007)(6486002)(6916009)(6506007)(53546011)(6512007)(36756003)(2616005)(6666004)(8936002)(2906002)(508600001)(86362001)(83380400001)(186003)(31696002)(5660300002)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjhzZWYrNXN2REptSVlscnY0RkM5ZVJBV2NmQ20rT3FPUHRrVFJBT2dnNkFx?= =?utf-8?B?VzIvVlRyclZwM0RPK3JXNjJZaTZITUJmVWxzaTlSVUhQT25xL0Iva2JVYU0x?= =?utf-8?B?aFZVaDJDZVBkRVE1eGV3d3NkMGpYbllwYlVMR1JKcHVST2NYM1hORElIcWhI?= =?utf-8?B?K1EvRzM2WWh0bU5xUEF4a05lL0xGWVFqc21LRzB3OHpIM0p0WDU0RVBSVkZI?= =?utf-8?B?RURwVlFNWStycHdwa0FlUlVqaTJtVGxyYW1aLzhrNGFzQW5menlUNnI2MmJh?= =?utf-8?B?UHdjMU9zck1BQmFCaEpLS0tJRno0UzBCVi9oSHJObHpzRkxtUUxmcGtSK0FF?= =?utf-8?B?QlUrUUp5dGdJbmNrMmV0eVNHZzJ2QS9PcWkzQ1Z2YUszNFRNaFRTZ1RCM1JN?= =?utf-8?B?WWs0ek54dW9ORS8rRU5HQ09RY2xrMkd3NjNBTGVtWGh3TW0zZExIejhEaUw5?= =?utf-8?B?NDQrKzBuYzgzeGhNczJtWklLKzY2YzJLU1FrL0tLRHpWTEw2cEw0Vmd5S2tN?= =?utf-8?B?V0ZzVUI1ZDJBN0pySG9SMlhKUi9DMVFyaXpZdlZhUmJYNjJlak4wYkN3QkJ1?= =?utf-8?B?S0RyNk5ZMCttZ2Rab01IWkQwdkFRamhOTExrVFA4aENUMEdWR1hxK2NGWTU1?= =?utf-8?B?VW5xazBhZHAwRHp0eUo4cS9oTFBXbmdzZm1VSmVtOUdWUC9BcVNBcGJBRDAy?= =?utf-8?B?TzBmNzlVdnNEVkdYVnRJUStvaWlJb2lCL2xuSEJFRldlMnVLSkErWjJKaFEz?= =?utf-8?B?U2dMdmFSbTZwbmZWRWcxM0VSenBpYkE4ZXM1aDBKejZjN0xiaVFncEg1WlFS?= =?utf-8?B?cjFZNnUxV3pocnJ6NWhzZy9kd3VqdEZsNmUzYWcwdkwyN05tSS9Fdm5sbEt2?= =?utf-8?B?clc2WjNCL0RqUERsUVVPS1p5QUJuQXI4NmVnWFV6NGF5NlNONitPK2V1dXNy?= =?utf-8?B?OFZjM0tqNDcvb2NqZE1oMDZOaDVVZUh1K1NOVzI5c3NwNXd5M2dMdG0vRW5L?= =?utf-8?B?dmhMSGVZMW1qUms1ekNweXRzbGhnODFWZHJVRTBaajhNM2Rud2xjUWQ1TmFt?= =?utf-8?B?ZUdCUVNwV01ZUWF1RkJtOGJ4Z1htUWpvWFA3ZlQ5Z2RrU002elBJMzFTelFQ?= =?utf-8?B?ZG44c0FVdml1S1lrODVHakYxU25QZmRPL1lPcDBURHZNMXFWRFN0M1BEL1c3?= =?utf-8?B?V0p5RkdsU28zZXJsWGFoTzA2ZWVFYzBid1pleHpUbnlzcTZPb0YrckJKZmhn?= =?utf-8?B?N1UxVXhPOU9nWlJtdTRZNElhVWFqRm5JbExId0RRc2picXV0aVhZeVgwK3lu?= =?utf-8?B?bFd3emNtUHFpTUlqcDBNbVp5c0FCYlJYUkhxdHRScVNiRHMyNlNiZXN5NW5o?= =?utf-8?B?Y1pBR2FzMG9UYm8rT3ozem5Jblhoc29wS2tRcDRYT0ExQjUxWHZ2TVRwOW1q?= =?utf-8?B?N2oxd05BYWwvWTFkRVJYUTdBUlJYd3FwZGhUVldTUm5RNTRZWGVBd2xhWjF6?= =?utf-8?B?Rm5uWnpkQkVEbVYyVm9MQVNjbVFPc1dkVkpOTHpmZ3FzOU5qaTJ4dWxIbjd1?= =?utf-8?B?Q0xJM1NrL2tZblEwVEdaeGY4OUplL3Y2OC9ZQUhJYXFtckV1SEcrZmhYUTZS?= =?utf-8?B?UGVUZmN0S3piOS9HQy9HTzUwdEJOTTVSR01Ca1g4NUhGRUkxUi80WW80NkNu?= =?utf-8?B?czc1UmkyVFRkMU5pRm9KbDdDaGppdTFxL2VxUmx3cXN0OXZJdWtteHhQRkNG?= =?utf-8?B?Q2d1ellqRkRFZ3BXVU5Obi9hR1dhbVU5QXN4TEhnd3VjeG9jek96Tm40SFBi?= =?utf-8?B?VXRLOWRCeHhRaTd1aU5wckhUV2tHZ25kVzQxeGp0Myt6NHhWNGF3UWpsRkVO?= =?utf-8?B?VVdMVkRoYkl3bzVhdS9xOXNKcG1GV0VQU014K2NIVWxaTWhCNUY2WU1FTVpL?= =?utf-8?B?VFpDNGVRRWIydVhGMDJZWER4ek9MOUZqSmxPaFNSS1kwVkRjNklmUDcyV1U0?= =?utf-8?B?SSt4UUtidFY1M1c3SkhoLzB1REVCM1BRTGZNZEtNeXVNQVIvSFRVVHlReFlx?= =?utf-8?B?VXdRNXh4OVBXWS8yNWJaUDhNU3BOYmE2R0tYaEIxemt2Sk5KNlA2NkNKUHZT?= =?utf-8?B?clhHYTNDUkJsN245V0pJYUxVc3UydTBrcjd4WHdoN1FlWDFweTJkSWowdXV6?= =?utf-8?B?L0VkelpYSm5yZmQ0bEJkcmphWVNpL0RyV2JQaTRxSEkyUU5UVXM0MC9LUFkv?= =?utf-8?B?MWpROEdFS04yT1dHYnVhSHJxM1ZrZ2dvTDFobmUyaFlqZVcwUE5YVXJWMjYr?= =?utf-8?B?Z05sSnFVbk1WbzQxNDZSeHJDUklBcHRCNURjMmxHNHZ4bkJqMFo1UEtwdGx2?= =?utf-8?Q?Am7p+ID+jytlcHpA9fE/9CtEeyubvabEu6ZoU?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 913730a0-3f9a-47eb-0dee-08da18cea800 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2147.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 19:41:49.3970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a+9XPTYg7+Jd7vC2wEL2KZdy8RbEkaRnDQ3zjmuSYaJsv3TmKOHN8TdOdEsVRivufRsTHrZAU93JMRZHePGPGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5304 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425, 18.0.850 definitions=2022-04-07_01:2022-04-07, 2022-04-07 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204070064 X-Proofpoint-ORIG-GUID: RfI1gS6BZh5pX3JXpT2bxOHO_aOGEijc X-Proofpoint-GUID: RfI1gS6BZh5pX3JXpT2bxOHO_aOGEijc X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 19:41:56 -0000 ping On 3/30/22 4:31 PM, Indu Bhagat wrote: > Hello, > > This patch set fixes PR debug/105089. > > [PS: The first patch in the series "ctfc: get rid of the static variable in > ctf_list_add_ctf_vars" is unrelated to the PR and is combined here only for > ease of review.] > > As noted in the PR debug/105089, gcc is emitting two CTF variable records > where it sees an extern variable with declaration and definition in the same > compilation unit. > > The CTF format format does not distinguish between the non-defining decl vs. > the defining decl, so the correct behaviour wrt the compiler generating the > type for such extern variables is to simply emit the type of the defining > declaration. > > Testing Notes: > -- bootstrapped and reg tested on x86_64 and aarch64 > -- built binutils package with -gctf (with CTF-capable linker) on x86_64, no > CTF errors reported. > > Thanks, > > Indu Bhagat (3): > ctfc: get rid of the static variable in ctf_list_add_ctf_vars () > CTF for extern variable fix [PR105089] > Refactor and update CTF testcases [PR105089] > > gcc/ctfc.cc | 62 ++++++++++++++++++- > gcc/ctfc.h | 8 ++- > gcc/ctfout.cc | 28 ++++++--- > gcc/dwarf2ctf.cc | 18 +++++- > gcc/testsuite/gcc.dg/debug/ctf/ctf-array-2.c | 22 +++---- > gcc/testsuite/gcc.dg/debug/ctf/ctf-array-5.c | 17 +++++ > .../gcc.dg/debug/ctf/ctf-variables-3.c | 22 +++++++ > 7 files changed, 147 insertions(+), 30 deletions(-) > create mode 100644 gcc/testsuite/gcc.dg/debug/ctf/ctf-array-5.c > create mode 100644 gcc/testsuite/gcc.dg/debug/ctf/ctf-variables-3.c >