public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <burnus@net-b.de>
To: Andre Vehreschild <vehre@gmx.de>,
	Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target
Date: Wed, 19 Aug 2020 14:51:28 +0200	[thread overview]
Message-ID: <78b99997-f3dd-1f73-625e-818868e53244@net-b.de> (raw)
In-Reply-To: <20200818193349.09639c4a@vepi2>

Hi Andre,

thanks for the comments.

Am 18.08.20 um 19:33 schrieb Andre Vehreschild:

> +	case OMP_DEVICE_TYPE_HOST:
> +	  MIO_NAME (ab_attribute) (AB_OMP_DEVICE_TYPE_NOHOST, attr_bits);
> Why also NOHOST here?

Copy and paste error. Well spotted. Thanks!
(I wonder why it didn't show up in the testcase;
probably because I generated the module in the same
translation unit, I'd guess.)

> @@ -426,6 +426,8 @@ build_common_decl (gfc_common_head *com, tree union_type,
> bool is_init) /* If there is no backend_decl for the common block, build it.  */
>    if (decl == NULL_TREE)
>      {
> +      tree clauses = NULL_TREE;
> Would you mind using "omp_clauses" or the like here?

I thought about this – but due to indentation, I think I
used 'clauses'. But looking again at the patch, this
must have been either 'c' or for some other patch as
"omp_clauses" should work as well.

I will later update the patch for the items.

Tobias


  reply	other threads:[~2020-08-19 12:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07 15:03 Tobias Burnus
2020-08-18  7:11 ` *PING* / " Tobias Burnus
2020-08-18 17:33 ` Andre Vehreschild
2020-08-19 12:51   ` Tobias Burnus [this message]
2020-08-20  9:51     ` Tobias Burnus
2020-08-20 16:10       ` Andre Vehreschild
2020-08-26  7:33         ` Tobias Burnus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78b99997-f3dd-1f73-625e-818868e53244@net-b.de \
    --to=burnus@net-b.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tobias@codesourcery.com \
    --cc=vehre@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).